From nobody Sun May 5 14:09:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1638545410; cv=none; d=zohomail.com; s=zohoarc; b=UnhCEOOC9zjTSXU7LIgtJbqdLBIfB8OYikoIaIjqiTxlpjVkY9FOkVe+HkOJrdv4OMHK4ET80joXHJQUI5R1vPK+P+1TaBe86YgsoUuiCkCJaL1W+4Vr6fk84RLfnrbcaH7dvNfN5C5Tgf//Aa7pqvYzlfJcrNdwroNu5u4MBYw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1638545410; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=rr0ksSICSZTNTPFmmdfg4WXhtgjrGS4i365qS5K8Lx8=; b=TIgKyWzYZkwo7MVy5q1ltyvr5yIHGGCfksRJjmsO4qr+PgK3ZspySJ0/X6aikccpfuJMFcH3QgaiV3Pu2qxPEXpMhrBdhlexazYXzgEaYTYOUrIjaGFn+vQJO2DHQZ3lHLx3mw5s1N8zg+HTYqAj/kZZjjEqAgF1RWX+NWV+2iw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1638545410948409.81997077069343; Fri, 3 Dec 2021 07:30:10 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-489-Wh74yBBFN1e82r8UUHBKjg-1; Fri, 03 Dec 2021 10:30:07 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4E07E846348; Fri, 3 Dec 2021 15:30:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EEB2F45D6C; Fri, 3 Dec 2021 15:29:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1ADAA4BB7C; Fri, 3 Dec 2021 15:29:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B3FQpjk001005 for ; Fri, 3 Dec 2021 10:26:51 -0500 Received: by smtp.corp.redhat.com (Postfix) id A96781B5AA; Fri, 3 Dec 2021 15:26:51 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.43.2.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id 31CF860843 for ; Fri, 3 Dec 2021 15:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638545409; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=rr0ksSICSZTNTPFmmdfg4WXhtgjrGS4i365qS5K8Lx8=; b=WTmA40pQdbcsHwXF87FSGKs+cfZ2Ac0rM4OrmL+30I6TFixQhlA/1aKSPZZOgNBnuVaSnp mmQlWfZNVtRoXURtC4JJqh3JXYI0J6S0V3qJPGZbzGpqfpkUd1YN2dvOz8IjnTN4rZcQAf G88zK+B648Kgc+0nmducgsYRZV5s2Qw= X-MC-Unique: Wh74yBBFN1e82r8UUHBKjg-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH] libxl: libxlLoggerFileFree: remove redundant NULL assignment Date: Fri, 3 Dec 2021 16:26:49 +0100 Message-Id: <38929464c5770ae21a4dcfd679bae50d5e90f41b.1638545202.git.jtomko@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1638545412282100001 The 'file' pointer is already zeroed in virFileFclose and never read again. Signed-off-by: J=C3=A1n Tomko --- Pushed as trivial. src/libxl/libxl_logger.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libxl/libxl_logger.c b/src/libxl/libxl_logger.c index 44ee5a95da..4708553f29 100644 --- a/src/libxl/libxl_logger.c +++ b/src/libxl/libxl_logger.c @@ -53,7 +53,6 @@ libxlLoggerFileFree(void *payload) { FILE *file =3D payload; VIR_FORCE_FCLOSE(file); - file =3D NULL; } =20 G_GNUC_PRINTF(5, 0) static void --=20 2.31.1