From nobody Thu Apr 25 04:38:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1578914555; cv=none; d=zohomail.com; s=zohoarc; b=mVSD5uuava9BpvZGSupp+IPvzWIZjiMRMlre2X/7LzrsiyoHGDP/v8+rpAKxdqfFWS8yfF3Omg8/4Us4JRThbjeVVq+czxbQlzcpYYupXH4GURaj46LCXtaIvNbvNdRhTJsICejuIrAH9edCKFIzkwoe0xI3L9VS4lc1VjcSPG4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578914555; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=C69Gflxnc6KPXvq9d3qZ/k1iVAzoor/7Mv+Agbmd9PE=; b=SxbULueLnWZMgt+28pUFkIcY9zJ2CDMPBfAAhJSUlx13tW1gYw1O1EKbIqqzO4Vgmd8h5tSN3OXnHVSQ9eeDF+aXLK/+6+k9fH9D69uiSlbmQMAwMLkZ8xk1M9WyjKR0taN3c4BUxsquXJXnjjNmDtBjYdCRlRrGjR1E8kkFXpo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 157891455532469.66895414197052; Mon, 13 Jan 2020 03:22:35 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-402-SoARPFssM_eja5jkNAgNCg-1; Mon, 13 Jan 2020 06:22:32 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 314D3DB21; Mon, 13 Jan 2020 11:22:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0709D19C6A; Mon, 13 Jan 2020 11:22:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 200D918089CD; Mon, 13 Jan 2020 11:22:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 00DBLulY006380 for ; Mon, 13 Jan 2020 06:21:56 -0500 Received: by smtp.corp.redhat.com (Postfix) id 3444760BF4; Mon, 13 Jan 2020 11:21:56 +0000 (UTC) Received: from virval.usersys.redhat.com (unknown [10.43.2.188]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 06ADF60BE2 for ; Mon, 13 Jan 2020 11:21:53 +0000 (UTC) Received: by virval.usersys.redhat.com (Postfix, from userid 500) id 73843103F6B; Mon, 13 Jan 2020 12:21:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578914554; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=C69Gflxnc6KPXvq9d3qZ/k1iVAzoor/7Mv+Agbmd9PE=; b=GmEg8+jk2Is/EwF+bh+19pi5wzQD97CsSQHkgfIKJ0f87eLEKBQf4ftV32i4K5xWCDIO81 FKD9TMa4ozH+9bu8hOUp1wkznOqm3hCVZimrZLYP8WTY4PsI/C3VArxVADtVTYcTTaWbLh 83yA9Le9VFcpIfdN/xJW+zhfg9fri+M= From: Jiri Denemark To: libvir-list@redhat.com Date: Mon, 13 Jan 2020 12:21:50 +0100 Message-Id: <37e1d9495ec9469fa5d99cfcb7cdbcfe2fd72670.1578914482.git.jdenemar@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH for 6.0.0] qemuxml2*test: Fix hugepages-default-system-size tests X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: SoARPFssM_eja5jkNAgNCg-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Commit v5.10.0-269-g62065a6cb5 moved NUMA validation code to domain definition time and appropriately adjusted affected test cases except for hugepages-default-system-size. And since we don't mock virGetSystemPageSizeKB in our tests, hugepages-default-system-size test would fail on architectures (ppc64le) with default page size other than 4KiB. Signed-off-by: Jiri Denemark Reviewed-by: Pavel Hrdina --- tests/qemuxml2argvtest.c | 2 +- tests/qemuxml2xmltest.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 8af2ba38d3..560a012149 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -946,7 +946,7 @@ mymain(void) QEMU_CAPS_OBJECT_MEMORY_FILE_DISCARD); DO_TEST("hugepages-default", QEMU_CAPS_OBJECT_MEMORY_FILE); DO_TEST("hugepages-default-2M", QEMU_CAPS_OBJECT_MEMORY_FILE); - DO_TEST("hugepages-default-system-size", NONE); + DO_TEST("hugepages-default-system-size", QEMU_CAPS_OBJECT_MEMORY_FILE); DO_TEST_PARSE_ERROR("hugepages-default-1G-nodeset-2M", NONE); DO_TEST("hugepages-nodeset", QEMU_CAPS_OBJECT_MEMORY_FILE); DO_TEST_PARSE_ERROR("hugepages-nodeset-nonexist", diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index 262fc835f5..f7b6022819 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -293,7 +293,7 @@ mymain(void) DO_TEST("pages-dimm-discard", NONE); DO_TEST("hugepages-default", QEMU_CAPS_OBJECT_MEMORY_FILE); DO_TEST("hugepages-default-2M", QEMU_CAPS_OBJECT_MEMORY_FILE); - DO_TEST("hugepages-default-system-size", NONE); + DO_TEST("hugepages-default-system-size", QEMU_CAPS_OBJECT_MEMORY_FILE); DO_TEST("hugepages-nodeset", QEMU_CAPS_OBJECT_MEMORY_FILE); DO_TEST("hugepages-numa-default-2M", QEMU_CAPS_OBJECT_MEMORY_FILE); DO_TEST("hugepages-numa-default-dimm", QEMU_CAPS_OBJECT_MEMORY_FILE); --=20 2.24.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list