From nobody Sun Feb 8 19:24:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571059021; cv=none; d=zoho.com; s=zohoarc; b=Cynncgupp5VGqTv/fad8w3LyGZGIdwttcqovUj/MEib5xjFbDcEmF+c1A9QSUKpDSBGlWuv1Fb6oWfNNsl5apcsRQ6NnTuiMwLnnWld48dBOsDwyfRxDrnZ+WpXLVb+gIP9RUrhaa5kuNizDDnGkyvSUD/FXCgqi5ng7LQl221Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571059021; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=El+S2mMpFMaNW9B4CrhAQ4ijElX0y3rusiKqJYedd3s=; b=mqtmTyaXBxTAazYbfHHaKYlHOeWcnuPV6l+4ZnAor+p0mK90ofQZ4MrltqNg0afasKtFfAp3Do6nU7f926hcwxbj9xIvnCh+TdV08BgTzOby+l51RtsGYMkDETyHlq5tOJf1XPnOegFiF451pGInmXyfYB12xGo+lwUMiC62DYU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1571059021019496.2395939104017; Mon, 14 Oct 2019 06:17:01 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1D2503086228; Mon, 14 Oct 2019 13:16:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DE7ED60C4B; Mon, 14 Oct 2019 13:16:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9B979180B780; Mon, 14 Oct 2019 13:16:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x9EDGN5C017408 for ; Mon, 14 Oct 2019 09:16:23 -0400 Received: by smtp.corp.redhat.com (Postfix) id C8B7E6012C; Mon, 14 Oct 2019 13:16:23 +0000 (UTC) Received: from icr.brq.redhat.com (unknown [10.43.2.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5149D60126 for ; Mon, 14 Oct 2019 13:16:23 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Mon, 14 Oct 2019 15:15:30 +0200 Message-Id: <3661934c6f02847c841c9258230ae67703bd4080.1571058852.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 12/35] esx: use G_GNUC_UNUSED X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Mon, 14 Oct 2019 13:16:59 +0000 (UTC) Use G_GNUC_UNUSED from GLib instead of ATTRIBUTE_UNUSED. Signed-off-by: J=C3=A1n Tomko --- src/esx/esx_driver.c | 32 ++++++++++++++--------------- src/esx/esx_interface_driver.c | 10 ++++----- src/esx/esx_network_driver.c | 16 +++++++-------- src/esx/esx_storage_backend_iscsi.c | 16 +++++++-------- src/esx/esx_storage_driver.c | 16 +++++++-------- src/esx/esx_vi.c | 20 +++++++++--------- src/esx/esx_vi_types.c | 4 ++-- 7 files changed, 57 insertions(+), 57 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index d6d219c101..b7c80d5c43 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -825,7 +825,7 @@ esxConnectToVCenter(esxPrivate *priv, */ static virDrvOpenStatus esxConnectOpen(virConnectPtr conn, virConnectAuthPtr auth, - virConfPtr conf ATTRIBUTE_UNUSED, + virConfPtr conf G_GNUC_UNUSED, unsigned int flags) { virDrvOpenStatus result =3D VIR_DRV_OPEN_ERROR; @@ -1097,7 +1097,7 @@ esxConnectSupportsFeature(virConnectPtr conn, int fea= ture) =20 =20 static const char * -esxConnectGetType(virConnectPtr conn ATTRIBUTE_UNUSED) +esxConnectGetType(virConnectPtr conn G_GNUC_UNUSED) { return "ESX"; } @@ -1852,7 +1852,7 @@ esxDomainDestroy(virDomainPtr dom) =20 =20 static char * -esxDomainGetOSType(virDomainPtr domain ATTRIBUTE_UNUSED) +esxDomainGetOSType(virDomainPtr domain G_GNUC_UNUSED) { char *osType; =20 @@ -3450,7 +3450,7 @@ esxDomainSetAutostart(virDomainPtr domain, int autost= art) * SharesLevel 'low', 'normal' and 'high'. */ static char * -esxDomainGetSchedulerType(virDomainPtr domain ATTRIBUTE_UNUSED, int *npara= ms) +esxDomainGetSchedulerType(virDomainPtr domain G_GNUC_UNUSED, int *nparams) { char *type; =20 @@ -3736,13 +3736,13 @@ esxDomainSetSchedulerParameters(virDomainPtr domain, =20 static int esxDomainMigratePrepare(virConnectPtr dconn, - char **cookie ATTRIBUTE_UNUSED, - int *cookielen ATTRIBUTE_UNUSED, - const char *uri_in ATTRIBUTE_UNUSED, + char **cookie G_GNUC_UNUSED, + int *cookielen G_GNUC_UNUSED, + const char *uri_in G_GNUC_UNUSED, char **uri_out, unsigned long flags, - const char *dname ATTRIBUTE_UNUSED, - unsigned long resource ATTRIBUTE_UNUSED) + const char *dname G_GNUC_UNUSED, + unsigned long resource G_GNUC_UNUSED) { esxPrivate *priv =3D dconn->privateData; =20 @@ -3763,12 +3763,12 @@ esxDomainMigratePrepare(virConnectPtr dconn, =20 static int esxDomainMigratePerform(virDomainPtr domain, - const char *cookie ATTRIBUTE_UNUSED, - int cookielen ATTRIBUTE_UNUSED, + const char *cookie G_GNUC_UNUSED, + int cookielen G_GNUC_UNUSED, const char *uri, unsigned long flags, const char *dname, - unsigned long bandwidth ATTRIBUTE_UNUSED) + unsigned long bandwidth G_GNUC_UNUSED) { int result =3D -1; esxPrivate *priv =3D domain->conn->privateData; @@ -3906,9 +3906,9 @@ esxDomainMigratePerform(virDomainPtr domain, =20 static virDomainPtr esxDomainMigrateFinish(virConnectPtr dconn, const char *dname, - const char *cookie ATTRIBUTE_UNUSED, - int cookielen ATTRIBUTE_UNUSED, - const char *uri ATTRIBUTE_UNUSED, + const char *cookie G_GNUC_UNUSED, + int cookielen G_GNUC_UNUSED, + const char *uri G_GNUC_UNUSED, unsigned long flags) { virCheckFlags(ESX_MIGRATION_FLAGS, NULL); @@ -4060,7 +4060,7 @@ esxDomainIsPersistent(virDomainPtr domain) =20 =20 static int -esxDomainIsUpdated(virDomainPtr domain ATTRIBUTE_UNUSED) +esxDomainIsUpdated(virDomainPtr domain G_GNUC_UNUSED) { /* ESX domains never have a persistent state that differs from * current state. However, we do want to check for existence. */ diff --git a/src/esx/esx_interface_driver.c b/src/esx/esx_interface_driver.c index e3b41164e7..76dcb3d53c 100644 --- a/src/esx/esx_interface_driver.c +++ b/src/esx/esx_interface_driver.c @@ -107,7 +107,7 @@ esxConnectListInterfaces(virConnectPtr conn, char **con= st names, int maxnames) =20 =20 static int -esxConnectNumOfDefinedInterfaces(virConnectPtr conn ATTRIBUTE_UNUSED) +esxConnectNumOfDefinedInterfaces(virConnectPtr conn G_GNUC_UNUSED) { /* ESX interfaces are always active */ return 0; @@ -116,9 +116,9 @@ esxConnectNumOfDefinedInterfaces(virConnectPtr conn ATT= RIBUTE_UNUSED) =20 =20 static int -esxConnectListDefinedInterfaces(virConnectPtr conn ATTRIBUTE_UNUSED, - char **const names ATTRIBUTE_UNUSED, - int maxnames ATTRIBUTE_UNUSED) +esxConnectListDefinedInterfaces(virConnectPtr conn G_GNUC_UNUSED, + char **const names G_GNUC_UNUSED, + int maxnames G_GNUC_UNUSED) { /* ESX interfaces are always active */ return 0; @@ -250,7 +250,7 @@ esxInterfaceGetXMLDesc(virInterfacePtr iface, unsigned = int flags) =20 =20 static int -esxInterfaceIsActive(virInterfacePtr iface ATTRIBUTE_UNUSED) +esxInterfaceIsActive(virInterfacePtr iface G_GNUC_UNUSED) { /* ESX interfaces are always active */ return 1; diff --git a/src/esx/esx_network_driver.c b/src/esx/esx_network_driver.c index 40bd5c2168..aaf6c77635 100644 --- a/src/esx/esx_network_driver.c +++ b/src/esx/esx_network_driver.c @@ -115,7 +115,7 @@ esxConnectListNetworks(virConnectPtr conn, char **const= names, int maxnames) =20 =20 static int -esxConnectNumOfDefinedNetworks(virConnectPtr conn ATTRIBUTE_UNUSED) +esxConnectNumOfDefinedNetworks(virConnectPtr conn G_GNUC_UNUSED) { /* ESX networks are always active */ return 0; @@ -124,9 +124,9 @@ esxConnectNumOfDefinedNetworks(virConnectPtr conn ATTRI= BUTE_UNUSED) =20 =20 static int -esxConnectListDefinedNetworks(virConnectPtr conn ATTRIBUTE_UNUSED, - char **const names ATTRIBUTE_UNUSED, - int maxnames ATTRIBUTE_UNUSED) +esxConnectListDefinedNetworks(virConnectPtr conn G_GNUC_UNUSED, + char **const names G_GNUC_UNUSED, + int maxnames G_GNUC_UNUSED) { /* ESX networks are always active */ return 0; @@ -823,7 +823,7 @@ esxNetworkGetXMLDesc(virNetworkPtr network_, unsigned i= nt flags) =20 =20 static int -esxNetworkGetAutostart(virNetworkPtr network ATTRIBUTE_UNUSED, +esxNetworkGetAutostart(virNetworkPtr network G_GNUC_UNUSED, int *autostart) { /* ESX networks are always active */ @@ -835,7 +835,7 @@ esxNetworkGetAutostart(virNetworkPtr network ATTRIBUTE_= UNUSED, =20 =20 static int -esxNetworkSetAutostart(virNetworkPtr network ATTRIBUTE_UNUSED, +esxNetworkSetAutostart(virNetworkPtr network G_GNUC_UNUSED, int autostart) { /* Just accept autostart activation, but fail on autostart deactivatio= n */ @@ -853,7 +853,7 @@ esxNetworkSetAutostart(virNetworkPtr network ATTRIBUTE_= UNUSED, =20 =20 static int -esxNetworkIsActive(virNetworkPtr network ATTRIBUTE_UNUSED) +esxNetworkIsActive(virNetworkPtr network G_GNUC_UNUSED) { /* ESX networks are always active */ return 1; @@ -862,7 +862,7 @@ esxNetworkIsActive(virNetworkPtr network ATTRIBUTE_UNUS= ED) =20 =20 static int -esxNetworkIsPersistent(virNetworkPtr network ATTRIBUTE_UNUSED) +esxNetworkIsPersistent(virNetworkPtr network G_GNUC_UNUSED) { /* ESX has no concept of transient networks, so all of them are persis= tent */ return 1; diff --git a/src/esx/esx_storage_backend_iscsi.c b/src/esx/esx_storage_back= end_iscsi.c index 49edf70284..e9a30876bf 100644 --- a/src/esx/esx_storage_backend_iscsi.c +++ b/src/esx/esx_storage_backend_iscsi.c @@ -276,7 +276,7 @@ esxStoragePoolRefresh(virStoragePoolPtr pool, =20 =20 static int -esxStoragePoolGetInfo(virStoragePoolPtr pool ATTRIBUTE_UNUSED, +esxStoragePoolGetInfo(virStoragePoolPtr pool G_GNUC_UNUSED, virStoragePoolInfoPtr info) { /* These fields are not valid for iSCSI pool */ @@ -582,8 +582,8 @@ esxStorageVolLookupByKey(virConnectPtr conn, const char= *key) =20 =20 static virStorageVolPtr -esxStorageVolCreateXML(virStoragePoolPtr pool ATTRIBUTE_UNUSED, - const char *xmldesc ATTRIBUTE_UNUSED, +esxStorageVolCreateXML(virStoragePoolPtr pool G_GNUC_UNUSED, + const char *xmldesc G_GNUC_UNUSED, unsigned int flags) { virCheckFlags(0, NULL); @@ -597,9 +597,9 @@ esxStorageVolCreateXML(virStoragePoolPtr pool ATTRIBUTE= _UNUSED, =20 =20 static virStorageVolPtr -esxStorageVolCreateXMLFrom(virStoragePoolPtr pool ATTRIBUTE_UNUSED, - const char *xmldesc ATTRIBUTE_UNUSED, - virStorageVolPtr sourceVolume ATTRIBUTE_UNUSED, +esxStorageVolCreateXMLFrom(virStoragePoolPtr pool G_GNUC_UNUSED, + const char *xmldesc G_GNUC_UNUSED, + virStorageVolPtr sourceVolume G_GNUC_UNUSED, unsigned int flags) { virCheckFlags(0, NULL); @@ -733,7 +733,7 @@ esxStorageVolGetXMLDesc(virStorageVolPtr volume, =20 =20 static int -esxStorageVolDelete(virStorageVolPtr volume ATTRIBUTE_UNUSED, +esxStorageVolDelete(virStorageVolPtr volume G_GNUC_UNUSED, unsigned int flags) { virCheckFlags(0, -1); @@ -747,7 +747,7 @@ esxStorageVolDelete(virStorageVolPtr volume ATTRIBUTE_U= NUSED, =20 =20 static int -esxStorageVolWipe(virStorageVolPtr volume ATTRIBUTE_UNUSED, +esxStorageVolWipe(virStorageVolPtr volume G_GNUC_UNUSED, unsigned int flags) { virCheckFlags(0, -1); diff --git a/src/esx/esx_storage_driver.c b/src/esx/esx_storage_driver.c index e692e8644d..8a34732b45 100644 --- a/src/esx/esx_storage_driver.c +++ b/src/esx/esx_storage_driver.c @@ -117,7 +117,7 @@ esxConnectListStoragePools(virConnectPtr conn, char **c= onst names, int maxnames) =20 =20 static int -esxConnectNumOfDefinedStoragePools(virConnectPtr conn ATTRIBUTE_UNUSED) +esxConnectNumOfDefinedStoragePools(virConnectPtr conn G_GNUC_UNUSED) { /* ESX storage pools are always active */ return 0; @@ -126,9 +126,9 @@ esxConnectNumOfDefinedStoragePools(virConnectPtr conn A= TTRIBUTE_UNUSED) =20 =20 static int -esxConnectListDefinedStoragePools(virConnectPtr conn ATTRIBUTE_UNUSED, - char **const names ATTRIBUTE_UNUSED, - int maxnames ATTRIBUTE_UNUSED) +esxConnectListDefinedStoragePools(virConnectPtr conn G_GNUC_UNUSED, + char **const names G_GNUC_UNUSED, + int maxnames G_GNUC_UNUSED) { /* ESX storage pools are always active */ return 0; @@ -251,7 +251,7 @@ esxStoragePoolGetXMLDesc(virStoragePoolPtr pool, unsign= ed int flags) =20 =20 static int -esxStoragePoolGetAutostart(virStoragePoolPtr pool ATTRIBUTE_UNUSED, +esxStoragePoolGetAutostart(virStoragePoolPtr pool G_GNUC_UNUSED, int *autostart) { /* ESX storage pools are always active */ @@ -263,7 +263,7 @@ esxStoragePoolGetAutostart(virStoragePoolPtr pool ATTRI= BUTE_UNUSED, =20 =20 static int -esxStoragePoolSetAutostart(virStoragePoolPtr pool ATTRIBUTE_UNUSED, +esxStoragePoolSetAutostart(virStoragePoolPtr pool G_GNUC_UNUSED, int autostart) { /* Just accept autostart activation, but fail on autostart deactivatio= n */ @@ -500,7 +500,7 @@ esxStorageVolGetPath(virStorageVolPtr volume) =20 =20 static int -esxStoragePoolIsActive(virStoragePoolPtr pool ATTRIBUTE_UNUSED) +esxStoragePoolIsActive(virStoragePoolPtr pool G_GNUC_UNUSED) { /* ESX storage pools are always active */ return 1; @@ -509,7 +509,7 @@ esxStoragePoolIsActive(virStoragePoolPtr pool ATTRIBUTE= _UNUSED) =20 =20 static int -esxStoragePoolIsPersistent(virStoragePoolPtr pool ATTRIBUTE_UNUSED) +esxStoragePoolIsPersistent(virStoragePoolPtr pool G_GNUC_UNUSED) { /* ESX has no concept of transient pools, so all of them are persisten= t */ return 1; diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c index 7e8a174313..fc21a7b6eb 100644 --- a/src/esx/esx_vi.c +++ b/src/esx/esx_vi.c @@ -64,7 +64,7 @@ VIR_LOG_INIT("esx.esx_vi"); void \ esxVI_##_type##_Free(esxVI_##_type **ptrptr) \ { \ - esxVI_##_type *item ATTRIBUTE_UNUSED; \ + esxVI_##_type *item G_GNUC_UNUSED; \ \ if (!ptrptr || !(*ptrptr)) { \ return; \ @@ -167,8 +167,8 @@ esxVI_CURL_WriteBuffer(char *data, size_t size, size_t = nmemb, void *userdata) =20 #if ESX_VI__CURL__ENABLE_DEBUG_OUTPUT static int -esxVI_CURL_Debug(CURL *curl ATTRIBUTE_UNUSED, curl_infotype type, - char *info, size_t size, void *userdata ATTRIBUTE_UNUSED) +esxVI_CURL_Debug(CURL *curl G_GNUC_UNUSED, curl_infotype type, + char *info, size_t size, void *userdata G_GNUC_UNUSED) { char *buffer =3D NULL; =20 @@ -475,8 +475,8 @@ esxVI_CURL_Upload(esxVI_CURL *curl, const char *url, co= nst char *content) */ =20 static void -esxVI_SharedCURL_Lock(CURL *handle ATTRIBUTE_UNUSED, curl_lock_data data, - curl_lock_access access_ ATTRIBUTE_UNUSED, void *use= rptr) +esxVI_SharedCURL_Lock(CURL *handle G_GNUC_UNUSED, curl_lock_data data, + curl_lock_access access_ G_GNUC_UNUSED, void *userpt= r) { size_t i; esxVI_SharedCURL *shared =3D userptr; @@ -503,7 +503,7 @@ esxVI_SharedCURL_Lock(CURL *handle ATTRIBUTE_UNUSED, cu= rl_lock_data data, } =20 static void -esxVI_SharedCURL_Unlock(CURL *handle ATTRIBUTE_UNUSED, curl_lock_data data, +esxVI_SharedCURL_Unlock(CURL *handle G_GNUC_UNUSED, curl_lock_data data, void *userptr) { size_t i; @@ -649,10 +649,10 @@ esxVI_SharedCURL_Remove(esxVI_SharedCURL *shared, esx= VI_CURL *curl) #if ESX_EMULATE_CURL_MULTI_WAIT =20 static int -esxVI_MultiCURL_SocketCallback(CURL *handle ATTRIBUTE_UNUSED, +esxVI_MultiCURL_SocketCallback(CURL *handle G_GNUC_UNUSED, curl_socket_t fd, int action, void *callback_opaque, - void *socket_opaque ATTRIBUTE_UNUSED) + void *socket_opaque G_GNUC_UNUSED) { esxVI_MultiCURL *multi =3D callback_opaque; size_t i; @@ -695,8 +695,8 @@ esxVI_MultiCURL_SocketCallback(CURL *handle ATTRIBUTE_U= NUSED, } =20 static int -esxVI_MultiCURL_TimerCallback(CURLM *handle ATTRIBUTE_UNUSED, - long timeout_ms ATTRIBUTE_UNUSED, +esxVI_MultiCURL_TimerCallback(CURLM *handle G_GNUC_UNUSED, + long timeout_ms G_GNUC_UNUSED, void *callback_opaque) { esxVI_MultiCURL *multi =3D callback_opaque; diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c index c77e759de2..deb6ebd09f 100644 --- a/src/esx/esx_vi_types.c +++ b/src/esx/esx_vi_types.c @@ -58,7 +58,7 @@ VIR_LOG_INIT("esx.esx_vi_types"); void \ esxVI_##_type##_Free(esxVI_##_type **ptrptr) \ { \ - esxVI_##_type *item ATTRIBUTE_UNUSED; \ + esxVI_##_type *item G_GNUC_UNUSED; \ \ if (!ptrptr || !(*ptrptr)) { \ return; \ @@ -185,7 +185,7 @@ VIR_LOG_INIT("esx.esx_vi_types"); esxVI_##_type##_Cast##_dest_extra##FromAnyType(esxVI_AnyType *anyType,= \ _dest_type **ptrptr) \ { \ - _dest_type *item ATTRIBUTE_UNUSED; \ + _dest_type *item G_GNUC_UNUSED; \ \ if (!anyType || !ptrptr || *ptrptr) { \ virReportError(VIR_ERR_INTERNAL_ERROR, "%s", \ --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list