From nobody Sun Feb 8 17:41:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652196074; cv=none; d=zohomail.com; s=zohoarc; b=QR6RhpQqtn3AWeX3bn7xuqZ1BFSLC3O9lsZ1535QvuhjA+g01GgIizmWTPA/TXKLH5vhUqTDg6z3uchdphlV5j87aT75+pJVcZRIgCnb9K1y8JM8LdY7Il1c0H5IMFii+2VpIXvXrJRY2eMdrPUHnOnfOa5WyFv2Cg7ZFAVIL28= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652196074; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2QVRcNtHp8OB6zOXWv8zP4NlXkSVOXTb8V6hKCTgpV8=; b=BEAtggOwBTOjwyHzKBD1UMiaSauiH/AhU0ltMf6Vf0dcZoGzVISgaKTbp8b5xKd0O/h9/qLkRf+TRVv+TtfZDn/89UaK/0y9/td9f00i8tPXKlfZxKTUDCWR9jTO5ofLcPvXwy0mweh3tDwRTyHpDgrX8PyNOKG3W1+ZL9PqRic= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1652196074379524.0125729089552; Tue, 10 May 2022 08:21:14 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-271-57yeRkA-OIWXbq9fXmVGkg-1; Tue, 10 May 2022 11:20:36 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D9E3218F0279; Tue, 10 May 2022 15:20:28 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C635B403171; Tue, 10 May 2022 15:20:28 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B93041947055; Tue, 10 May 2022 15:20:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 56051194704D for ; Tue, 10 May 2022 15:20:27 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 436D320296AC; Tue, 10 May 2022 15:20:27 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id BE25B20296A7 for ; Tue, 10 May 2022 15:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652196073; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=2QVRcNtHp8OB6zOXWv8zP4NlXkSVOXTb8V6hKCTgpV8=; b=I+Z1joCBPX0Vc5P1PlMTHNRJIT3cSW6PRTWMeYNcAz2i0Je8awyKGM9NONRgn9jP4gorWv WGYbTH0mQMWyaOkNXGwTn4M2JURz+XoJd2UgkgT0IkIZnf2pRIsxEMjrg3SjySU882ADkF yQEf2yk/S8UnLjUjufgNWouAIi0d7g0= X-MC-Unique: 57yeRkA-OIWXbq9fXmVGkg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 10/37] qemuFDPassTransferMonitor: Close local copy of the FD as soon as it's passed to qemu Date: Tue, 10 May 2022 17:19:46 +0200 Message-Id: <35cf2480bd9fd7fdd5e2f71dbbfa8332955d175b.1652195735.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652196076229100001 Content-Type: text/plain; charset="utf-8" We don't want to keep the FDs open more than we need to. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_fd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_fd.c b/src/qemu/qemu_fd.c index cbdf1c938f..6e3a7ca491 100644 --- a/src/qemu/qemu_fd.c +++ b/src/qemu/qemu_fd.c @@ -276,6 +276,7 @@ qemuFDPassTransferMonitor(qemuFDPass *fdpass, return -1; } + VIR_FORCE_CLOSE(fdpass->fds[i].fd); fdpass->passed =3D true; } --=20 2.35.1