From nobody Mon Feb 9 09:34:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621519571; cv=none; d=zohomail.com; s=zohoarc; b=K5nHnPY9jYMDhpHfUxosJ0ZIJfxaZV2G43zACTem/TIhPf0ykRrVqtmGdzJXRSiMOM7hodWXE/rHQRDLmR1x+rTk1HfPATwfHkkW9kC7k3F0RvOSVVHHXUgyvxXpUMHWMXozkjPsSFJnVp3RoF0VYM6QJSLAdVRy31W8vQoNIFg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621519571; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VPzJDZNuTlkIYBkhskXAM+tSQah/yCArjunRakv8big=; b=Nvq5bEpIzlm7mdUAI4Z1PgangfP5xV8h9Sh+1ebnSDAGZ7SknmHHkQ4KKr6ENo9oZ93vmH2j4UFuH9A3uJAN1327VlaJ+Mjx5l5hY8LLWTCKFwMp9jjzqOCXatKnrhyDcTWOR1K7JplVIUTstXdn/xl+MMPNU1iP1Doy1ajeEdc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1621519571836784.7378142338664; Thu, 20 May 2021 07:06:11 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-206-HSCHR7wtMP-jy8XUvoCa1g-1; Thu, 20 May 2021 10:06:07 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4FE968042B4; Thu, 20 May 2021 14:06:01 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 31BB96091B; Thu, 20 May 2021 14:06:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F17BD180B464; Thu, 20 May 2021 14:06:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 14KDnxtu009099 for ; Thu, 20 May 2021 09:49:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id 342A61009962; Thu, 20 May 2021 13:49:59 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.244]) by smtp.corp.redhat.com (Postfix) with ESMTP id AB83E10027A5 for ; Thu, 20 May 2021 13:49:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621519570; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=VPzJDZNuTlkIYBkhskXAM+tSQah/yCArjunRakv8big=; b=LWblF88NSxPMa3UqmhWDyEF3aOIf9X+0J3tdwZ6uJ1GM52k9jnkCElA8T4U4s393FWj3Su ZzA5EGvUFmpL9lCxphUabe+JN20r09cTmIy29XGoVihmymWatZo7h6OAqz6tghJKHXWZEi HCZzV6LFfziRjm5iyfuvvCXgMDqKi/s= X-MC-Unique: HSCHR7wtMP-jy8XUvoCa1g-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 2/4] lib: Add win-dmp crashdump format Date: Thu, 20 May 2021 15:49:53 +0200 Message-Id: <33eaf98fc697a81853f653cb9a6e536ad03c6da5.1621518573.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" QEMU gained support for 'win-dmp' format in it's release of 2.13, but Libvirt doesn't implement it yet. Fortunately, there not much needed: new value to virDomainCoreDumpFormat public enum, which unfortunately means that QEMU driver has to be updated in the same commit, because of VIR_ENUM_IMPL(). Luckily, we don't need any extra QEMU capability - the code already checks supported formats via 'query-dump-guest-memory-capability' just before issuing 'dump-guest-memory'. Signed-off-by: Michal Privoznik --- include/libvirt/libvirt-domain.h | 1 + src/qemu/qemu_driver.c | 1 + 2 files changed, 2 insertions(+) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-dom= ain.h index b33eede68b..7ef8ac51e5 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -691,6 +691,7 @@ typedef enum { * lzo compression */ VIR_DOMAIN_CORE_DUMP_FORMAT_KDUMP_SNAPPY, /* kdump-compressed format, = with * snappy compression */ + VIR_DOMAIN_CORE_DUMP_FORMAT_WIN_DMP, /* Windows full crashdump fo= rmat */ # ifdef VIR_ENUM_SENTINELS VIR_DOMAIN_CORE_DUMP_FORMAT_LAST /* diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index c90d52edc0..e10e699a1a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -143,6 +143,7 @@ VIR_ENUM_IMPL(qemuDumpFormat, "kdump-zlib", "kdump-lzo", "kdump-snappy", + "win-dmp", ); =20 =20 --=20 2.26.3