From nobody Mon Dec 15 23:09:28 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1658846337; cv=none; d=zohomail.com; s=zohoarc; b=aXIqvI2aj1xx2oegD5I6O05H6+k+HVPmFMaSIVAB9M+Pjijf5YVUQZ7ZyrB/geg6FKZ3SAoO1HDtR1pVP47qKxLmNcDK98/PX5Hl1h9rk7GkOtXSul/K2+xym3L8yR4b6zovPc4z7E7Gaa8CByDr89oBfxAIrrwgLZOpBymeYN4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658846337; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7WBDvBeZCGLb1wdpiGSuwg5NQga54utKn2B0937RXkg=; b=e5nSkIP2L/ASIgPPlxBdkUA2wOF2Id50hwIFTN0ZR2M9LwUoVb5GQW+0tkrYat3HQDbjJsqUwkwp/aOsFBaQ4ay1CTzoQuakocMjppENYcxT1DuXPZ2mSCZ68bPUQ9L1XvN2FyDwyM3q4YUOeym8bumGKvN2T4gRtQ/mpt6KuDg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1658846337418329.30082731674236; Tue, 26 Jul 2022 07:38:57 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-453-hQHCDEgbPWu2PzV6B_uj0Q-1; Tue, 26 Jul 2022 10:38:48 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DEC5638005F5; Tue, 26 Jul 2022 14:38:32 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id AECEE14152FB; Tue, 26 Jul 2022 14:38:32 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3CEAF194704C; Tue, 26 Jul 2022 14:38:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D3C45194705A for ; Tue, 26 Jul 2022 14:38:25 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 9C709404C324; Tue, 26 Jul 2022 14:38:25 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 23A6440CFD0D for ; Tue, 26 Jul 2022 14:38:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658846336; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=7WBDvBeZCGLb1wdpiGSuwg5NQga54utKn2B0937RXkg=; b=Zhq0Sfa7CaNW8lENwffE5X8ai/qxcZ5yWvS9ZExeQMIF9ZGYEZITAXlW5g7Q91SXMx0Cfj kLNMT9g6gggCNIuJVZM7vUhaVKyvxF910+s89w6w3ZnqGlHi5KsmP/tr0AqzzuaJEvzi1j EGwZnPNeOQ1MEs7TTiBWtJcc8wo7oyM= X-MC-Unique: hQHCDEgbPWu2PzV6B_uj0Q-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 23/80] qemu: migration: Assume support for QEMU_CAPS_BLOCKDEV_DEL Date: Tue, 26 Jul 2022 16:37:01 +0200 Message-Id: <33d0ae820c82d4f6d0eeec1fdcc18b542979925d.1658843187.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1658846338231100001 Content-Type: text/plain; charset="utf-8" The migration code was using few blockdev bits before blockdev was fully integrated to allow TLS with NBD. Since we now always use blockdev we can remove the check. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina --- src/qemu/qemu_migration.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 042e8bb10a..16d65ff22e 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -4803,14 +4803,6 @@ qemuMigrationSrcRun(virQEMUDriver *driver, host =3D spec->dest.host.name; } - /* Allow migration with TLS only when we also support TLS for = the NBD connection */ - if (flags & VIR_MIGRATE_TLS && - !virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV_DEL)) { - virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", - _("NBD migration with TLS is not supported"= )); - goto error; - } - if (qemuMigrationSrcNBDStorageCopy(driver, vm, mig, host, priv->migMaxBandwidth, --=20 2.36.1