From nobody Tue Sep 9 03:16:13 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747750419; cv=none; d=zohomail.com; s=zohoarc; b=JUw36TzUl7mcihizRs9TGyY86jZoArTsKoq7DMQ/GIA83D0Sq2XIdlt+iPfqfNbzZMH6ij0IjU1FoDuzVm/8z6wFnCZTHf4GUsmnQQUoopBRiMC7RU15RV3g8YbZ4Pf4jTkWtuV55eTQ/B0DCbSLB5DsXlHsqQec3bqb/2Z4o4I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747750419; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=qvfT+VGIyGcgqNvZxrZXBl6afW59q0r3+5mrgaGzG6k=; b=BKPB1TVe6JmV3GqvOdAg4isvNSXulEBVJExDXV2XWpdTfJWOfs7Ke6SZ5oOoc1m8X1KzmPBnvZBbkadiMieJxYPA1gVTUX5SGSePIdc1UTjzq8FlqHu8IZOpVsy/gIcv3Rl9Py44/MMTkR1jFB8g/5aYkFjjx6HC6kgZmkxpSsM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747750419361305.1260475449916; Tue, 20 May 2025 07:13:39 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 6555214D2; Tue, 20 May 2025 10:13:38 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 014C314D9; Tue, 20 May 2025 10:10:32 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id B3D381885; Tue, 20 May 2025 10:10:24 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id CF3CB188A for ; Tue, 20 May 2025 10:10:14 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-533-1SoQT5fkO6qMZJoqYmBEgw-1; Tue, 20 May 2025 10:10:12 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7917C183092E for ; Tue, 20 May 2025 14:09:01 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.37]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A60DB1956095 for ; Tue, 20 May 2025 14:09:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747750214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0+F1c+M2SSF5NsIt5DsP3Th+LKGrUbLNaHR1ho8Ui7I=; b=ZP0ul/7BFit7407CPB4QScMJtn5XtlRamlpjfA659W6ziOmCgdEJWGEMOY6jr8mH777eZV bpShOqlZzzFY1ZmGPDS+1T3gYvKSQi7xO0S2uOnrg62f2hrTErkK3ZQiOle2fIdmDZSadX QiFl8DjbsA7D7kWxqq6GxGHmKzXOLHQ= X-MC-Unique: 1SoQT5fkO6qMZJoqYmBEgw-1 X-Mimecast-MFC-AGG-ID: 1SoQT5fkO6qMZJoqYmBEgw_1747750212 To: devel@lists.libvirt.org Subject: [PATCH 4/4] virsh: domain: Annotate rest of arguments taking local existing file Date: Tue, 20 May 2025 16:08:53 +0200 Message-ID: <33bd7f1d8c6f98803732e26f552a604b01b5c948.1747750075.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ozuxzhp1NvPMioDt77_6R1ggE86TK64EWW3-VRCMk18_1747750212 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: LFJZBHWXRSTGQCZLX5KMYGCOGC34W4I4 X-Message-ID-Hash: LFJZBHWXRSTGQCZLX5KMYGCOGC34W4I4 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747750419883116600 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Few arguments were missing the 'vshCompletePathLocalExisting' completer. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index f9acedf3db..8d615b6e7a 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -423,6 +423,7 @@ static const vshCmdOptDef opts_attach_disk[] =3D { .positional =3D true, .required =3D true, .allowEmpty =3D true, + .completer =3D vshCompletePathLocalExisting, .help =3D N_("source of disk device or name of network disk") }, {.name =3D "target", @@ -4931,6 +4932,7 @@ static const vshCmdOptDef opts_save_image_dumpxml[] = =3D { .type =3D VSH_OT_STRING, .positional =3D true, .required =3D true, + .completer =3D vshCompletePathLocalExisting, .help =3D N_("saved state file to read") }, {.name =3D "security-info", @@ -4988,6 +4990,7 @@ static const vshCmdOptDef opts_save_image_define[] = =3D { .type =3D VSH_OT_STRING, .positional =3D true, .required =3D true, + .completer =3D vshCompletePathLocalExisting, .help =3D N_("saved state file to modify") }, {.name =3D "xml", @@ -5053,6 +5056,7 @@ static const vshCmdOptDef opts_save_image_edit[] =3D { .type =3D VSH_OT_STRING, .positional =3D true, .required =3D true, + .completer =3D vshCompletePathLocalExisting, .help =3D N_("saved state file to edit") }, {.name =3D "running", @@ -5667,6 +5671,7 @@ static const vshCmdOptDef opts_restore[] =3D { .type =3D VSH_OT_STRING, .positional =3D true, .required =3D true, + .completer =3D vshCompletePathLocalExisting, .help =3D N_("the state to restore") }, {.name =3D "bypass-cache", @@ -13153,6 +13158,7 @@ static const vshCmdOptDef opts_change_media[] =3D { {.name =3D "source", .type =3D VSH_OT_STRING, .positional =3D true, + .completer =3D vshCompletePathLocalExisting, .help =3D N_("source of the media") }, {.name =3D "eject", --=20 2.49.0