From nobody Tue Sep 9 03:20:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1748332372; cv=none; d=zohomail.com; s=zohoarc; b=TxqaWd++ley8aBOYczEAWnyMHvppd/K+uNZgGCbFxKG7N2p7f79eNLbTOZdv6kJ/8/bEW1zhR4XsXwoAgjCLLOkkKRb2+nlRxAvF+E4ao5oiPooxvxCob2QgXrT9X46bb70i2OEemtNOHv78kC6fmq8JufFrWYv/0HLITj0Mk6A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748332372; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=eI8fRaWW5V5fIoN3EDEE0mIfuhL4W/3MszenHTZJHMw=; b=d7471FR/GD6tDyuRRqz7DgSvVFOEQd7nUhgG2gVSuvxsgjTUVlKYTCtLvDOYz7V3WY0nweXrTp8clInLs/hh90V/Oe0tVJtlC+VCi+AiY44B1L6nAbfpDdnI1DUaPuD+dLdAzvX3yADpI3ZXra4u4HHUVhtLKFOZTupixFdOvAI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1748332372130505.0463530425204; Tue, 27 May 2025 00:52:52 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 2CB0A14D3; Tue, 27 May 2025 03:52:51 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 8EE5814C7; Tue, 27 May 2025 03:49:45 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id E49E5143B; Tue, 27 May 2025 03:49:40 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 158B8165D for ; Tue, 27 May 2025 03:49:22 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-32-IHzDR9jQOv-Cvvywv8TmgA-1; Tue, 27 May 2025 03:49:18 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 16DAF1800772 for ; Tue, 27 May 2025 07:49:18 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.3]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4A3CB18003FD for ; Tue, 27 May 2025 07:49:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748332161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TeLS6U3vsTKAFETVg4eKuKzf91BF3kaPkUetls1Vyko=; b=HeX2llSBVqtgk2vEasrw8RD5tG2qEYObu/h3PXNtG5xb8w5CXiqtLsDyJ4btX4J1NmNANQ 0C2yqdXN8IFmH7gnyLyxgEbekDXVp7GH/ObA/OC5bpW8ZvTaEfk+UC5yyFgcKgj33RcgTv rSdT9kH+kGpS1s3LKprNWf06smkfFpI= X-MC-Unique: IHzDR9jQOv-Cvvywv8TmgA-1 X-Mimecast-MFC-AGG-ID: IHzDR9jQOv-Cvvywv8TmgA_1748332158 To: devel@lists.libvirt.org Subject: [PATCH 8/9] qemuProcessStartValidateGraphics: Remove redundant checks for RDP protocol features Date: Tue, 27 May 2025 09:49:04 +0200 Message-ID: <30debee0650c7535fca31e0046e3d2d470a71d17.1748332058.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 06P--GLsHxKErXRXg7DrnCe-OujqERneoblYQqpy3IU_1748332158 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 4FTI4GTTRV2AMD3ES5EKG546CRMIFIJU X-Message-ID-Hash: 4FTI4GTTRV2AMD3ES5EKG546CRMIFIJU X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1748332372597116600 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Both the 'replaceUser' and 'multiUser' field are already validated in qemuValidateDomainDeviceDefRDPGraphics. Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index b99602c5ed..920adef7df 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -5540,16 +5540,6 @@ qemuProcessStartValidateGraphics(virDomainObj *vm) break; case VIR_DOMAIN_GRAPHICS_TYPE_RDP: - if (graphics->data.rdp.multiUser) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("qemu-rdp doesn't support the 'multiUser'= attribute.")); - return -1; - } - if (graphics->data.rdp.replaceUser) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("qemu-rdp doesn't support the 'replaceUse= r' attribute.")); - return -1; - } if (!virDomainDefHasDBus(vm->def, false)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("qemu-rdp support requires a D-Bus bus gr= aphics device.")); --=20 2.49.0