From nobody Sun Apr 5 13:06:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774363396; cv=none; d=zohomail.com; s=zohoarc; b=Dv2YPsiZJuXkNU5bUpRLLQxe406ozkJyMnLDhihqqBhyi9/sZV2UQGgdanL1TeP9OEDMFqMkiulChGHvaDjTpF/DvvhWL3L/NCkoZStLVrR8Dk60qkiqItFwx6IFCiQ9VIrYsvBnwj9+/wfnbxzm8C5U5Idy6hZAxVuh2CPsTQ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774363396; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=eJpznMUoc0miPIXmErUDT+Yk7iJDVYLZF1q8Dv0ByaU=; b=AnfA9a75HPy7upfi2szDY6KILJ7ZESGtdq+EpSVHtFi4j9QFOXq1F0oqUssXW/9kOkrSSahvV01YIllW0wPY0uHai4IbBxMt97Ag4gqVTBiKsj0/5zSoIaWDWRxIaEFIky04+HDFSgvxJj8Uk7PyDlhfkFbGw5GK1If3Vn945Bw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774363396334782.1481990125027; Tue, 24 Mar 2026 07:43:16 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id C05323F890; Tue, 24 Mar 2026 10:43:15 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id AFB563F8A5; Tue, 24 Mar 2026 10:42:36 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 765613F28F; Tue, 24 Mar 2026 10:42:32 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 475B13F252 for ; Tue, 24 Mar 2026 10:42:31 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-302-sX-6LDCVMyOHVLP01VYDqA-1; Tue, 24 Mar 2026 10:42:29 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6C94B195609F for ; Tue, 24 Mar 2026 14:42:28 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B081E1955D71 for ; Tue, 24 Mar 2026 14:42:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774363350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eJpznMUoc0miPIXmErUDT+Yk7iJDVYLZF1q8Dv0ByaU=; b=RJfcesdaFCDYdDsWV9xv5012XFNyKuVeyP9ZT7OHjOI8Q3YnsdlVRipww4smrpR1Ta/y2D f7DFkxbcOYuA9a9IcIqkqfgHBRk4fWEytNRldSYFutx4Dr9Q2a+q8CkITSyZrX2McH7rlV O1niiJROoCaYpa5gYFWI5pKQQnW/sH8= X-MC-Unique: sX-6LDCVMyOHVLP01VYDqA-1 X-Mimecast-MFC-AGG-ID: sX-6LDCVMyOHVLP01VYDqA_1774363348 To: devel@lists.libvirt.org Subject: [PATCH 1/4] virDomainGetBlockInfo: Log 'disk' argument Date: Tue, 24 Mar 2026 15:42:21 +0100 Message-ID: <30d37f9f8060caf944d730ee053615b4b8eb6fbd.1774363234.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XmzhYaAfVY3-5EwPNBw163INCzGcP6E6Lt5nIabJBoI_1774363348 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CS3LUZLB3SUBMTOW3WMI7MDYBLSPR7EY X-Message-ID-Hash: CS3LUZLB3SUBMTOW3WMI7MDYBLSPR7EY X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774363399470154100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The 'disk' argument was forgotten in the VIR_DOMAIN_DEBUG statement so the logs don't contain which disk the caller wanted the stats for. Signed-off-by: Peter Krempa --- src/libvirt-domain.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 6b8783d57f..cc19a214ce 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -6681,12 +6681,15 @@ virDomainMemoryPeek(virDomainPtr dom, * Since: 0.8.1 */ int -virDomainGetBlockInfo(virDomainPtr domain, const char *disk, - virDomainBlockInfoPtr info, unsigned int flags) +virDomainGetBlockInfo(virDomainPtr domain, + const char *disk, + virDomainBlockInfoPtr info, + unsigned int flags) { virConnectPtr conn; - VIR_DOMAIN_DEBUG(domain, "info=3D%p, flags=3D0x%x", info, flags); + VIR_DOMAIN_DEBUG(domain, "disk=3D'%s', info=3D%p, flags=3D0x%x", + disk, info, flags); virResetLastError(); --=20 2.53.0