From nobody Mon Feb 9 01:21:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1631177583; cv=none; d=zohomail.com; s=zohoarc; b=azc6z29tEiDX/U36G2//A9ky2R+Px4BsUBK4WL3jGCsJRY5RoO6kF6w5pieWoiBhyB0pZ8t+AzmLCzyFIEQDADbDSVOIV1WyZC5qkTVRRmHCCHRL0SP1ix8F8qCPc3R6JgGr/wiOELari74Zk4tMi6hCYkiWBC8Lq2YUL9bGrnI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631177583; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qSwXewGxS7dU5KacoZhY9ESzMbNT4Iz6VibcdqI9LKo=; b=h5lljQfTp+ms27b3Vab2TIgS87ERdnNxqg4pszaCd2+d2b++T1vbAy1cDm5IyYRCdrbTDj+Y2U4fSMe2fH3gUl5DrpNGKCv2qbTaaeV2yWtAKuGunESuFXb5R0XnPhLxHNn0WhYwKSgLjWOyR9r6erWhsFCDzzj1Ch+Ql4pxgAw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1631177583518134.44047921108643; Thu, 9 Sep 2021 01:53:03 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-235-_ptiHTErO_y6bYljf4pZUQ-1; Thu, 09 Sep 2021 04:50:56 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5C9D81895817; Thu, 9 Sep 2021 08:50:47 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2C34819C79; Thu, 9 Sep 2021 08:50:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E48184EA47; Thu, 9 Sep 2021 08:50:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1898ogp6030812 for ; Thu, 9 Sep 2021 04:50:42 -0400 Received: by smtp.corp.redhat.com (Postfix) id BF5C726E41; Thu, 9 Sep 2021 08:50:42 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2348519D9B for ; Thu, 9 Sep 2021 08:50:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631177582; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qSwXewGxS7dU5KacoZhY9ESzMbNT4Iz6VibcdqI9LKo=; b=deslyRDNV3e98FNMPJxBqytmzdBFyg2yDwjJ314UtZAzIQ22yXuzZsYj40+dBuPtiOneiP ILVUmRh4ZlqSx7uKzuonU0xDNAKb8R2ryZiXyX+Vb9g1MMFpFbeyJ2QHi49EwfyWVwqojO P9ljStM2aYKAAoK1s1NdX2+ePJl0gtA= X-MC-Unique: _ptiHTErO_y6bYljf4pZUQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 20/24] virstoragetest: testPrepImages: Use 'qemu-img' to format 'raw' image Date: Thu, 9 Sep 2021 10:49:20 +0200 Message-Id: <3075b29675c981fbced384eafa0d8b2d3c9a6b9c.1631177237.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1631177585681100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Krempa --- tests/virstoragetest.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c index 90dde512cf..c258bc1709 100644 --- a/tests/virstoragetest.c +++ b/tests/virstoragetest.c @@ -86,9 +86,9 @@ static int testPrepImages(void) { int ret =3D EXIT_FAILURE; + g_autoptr(virCommand) cmdraw =3D NULL; g_autoptr(virCommand) cmdqcow2 =3D NULL; g_autoptr(virCommand) cmdwrap =3D NULL; - g_autofree char *buf =3D NULL; g_autofree char *absraw =3D g_strdup_printf("%s/raw", datadir); g_autofree char *absqcow2 =3D g_strdup_printf("%s/qcow2", datadir); g_autofree char *qemuimg =3D virFindFileInPath("qemu-img"); @@ -111,11 +111,11 @@ testPrepImages(void) goto cleanup; } - buf =3D g_strdup_printf("%1024d", 0); - if (virFileWriteStr("raw", buf, 0600) < 0) { - fprintf(stderr, "unable to create raw file\n"); - goto cleanup; - } + cmdraw =3D virCommandNewArgList(qemuimg, "create", + "-f", "raw", + absraw, "1k", NULL); + if (virCommandRun(cmdraw, NULL) < 0) + goto skip; /* Create a qcow2 wrapping relative raw; later on, we modify its * metadata to test other configurations */ --=20 2.31.1