From nobody Sun Feb 8 10:43:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1661272453; cv=none; d=zohomail.com; s=zohoarc; b=L6FU1rgUTU0R4rC4RQz3+4pBCK0BAdiTwPo4L0jXeOQfl1Z9xU84Farr+ijC0EZdH4Cu/Z+SlBbOq3uq/xE9ACVcP4cHmZavEGk7TM7KZcRhDq6QBQQx9ISnxWTB++FvXBx3DgeDnplZORsbO5ZQE6PoMjutHfD/YXi402K6rpM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661272453; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TqCCNFElR+A5RvneiNDDftkBj8Wj8OKixZKDegEDMWI=; b=B+GUrT0kc0DCvHIWhZXvPmvfc0gBKtF60OTK8sVPLFLRbxDmjJXVgWlVmf2h7mfC8vRLRhE7m2M32/Ih36nMfUA1JthyRbfs07caUy9wgSmf3eIRPQ2ARuFBIGGitKnRuD/b8uNbHBVkL1pIIg5M3KYA8CNl7QZjHvBcoX2bVAo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1661272453517238.4520338752926; Tue, 23 Aug 2022 09:34:13 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-196-2V6IQuq0Piacb-VmmBNASg-1; Tue, 23 Aug 2022 12:33:07 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0ADDE83DE45; Tue, 23 Aug 2022 16:32:47 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id EA8E3C15BB3; Tue, 23 Aug 2022 16:32:46 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CB3A11946A5A; Tue, 23 Aug 2022 16:32:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 195311946A67 for ; Tue, 23 Aug 2022 16:32:44 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id EFAFE492C3B; Tue, 23 Aug 2022 16:32:43 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.192.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9134340315A for ; Tue, 23 Aug 2022 16:32:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661272451; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TqCCNFElR+A5RvneiNDDftkBj8Wj8OKixZKDegEDMWI=; b=cFjw3/ii39BVVpMSdDQzoWFJGUmKzrbSv7oC+grjf5ZlxZ2kSujUoJtL/wpZyf4cBuQBBR Nlg4FOEjGPVUhLUWdH57md5isTk4ME0PV9yZOrs2OHp8Iw8KnmLFui3bZXQW3rLRoC2xu6 BGLOjTuuA5DwIKKoYm5sNTn1+fK0bJ0= X-MC-Unique: 2V6IQuq0Piacb-VmmBNASg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt RFC 16/24] qemu_snapshot: pass update_parent into qemuSnapshotDiscardMetadata Date: Tue, 23 Aug 2022 18:32:19 +0200 Message-Id: <2fe2d702ad4ec7731cdc276f872d6f571bd272bc.1661271812.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1661272453805100007 Content-Type: text/plain; charset="utf-8"; x-default="true" Signed-off-by: Pavel Hrdina --- src/qemu/qemu_snapshot.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index cbacb05c16..787186605f 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -2284,11 +2284,12 @@ qemuSnapshotChildrenReparent(void *payload, static int qemuSnapshotDiscardMetadata(virDomainObj *vm, virDomainMomentObj *snap, - virQEMUDriver *driver) + virQEMUDriver *driver, + bool update_parent) { g_autoptr(virQEMUDriverConfig) cfg =3D virQEMUDriverGetConfig(driver); =20 - if (snap->nchildren) { + if (update_parent && snap->nchildren) { virQEMUMomentReparent rep; =20 rep.dir =3D cfg->snapshotDir; @@ -2351,10 +2352,8 @@ qemuSnapshotDiscard(virQEMUDriver *driver, } } =20 - if (update_parent && - qemuSnapshotDiscardMetadata(vm, snap, driver) < 0) { + if (qemuSnapshotDiscardMetadata(vm, snap, driver, update_parent) < 0) return -1; - } =20 snapFile =3D g_strdup_printf("%s/%s/%s.xml", cfg->snapshotDir, vm->def= ->name, snap->def->name); --=20 2.37.2