From nobody Mon Feb 9 01:21:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1677853879; cv=none; d=zohomail.com; s=zohoarc; b=j7kUL4dL2mQ8fz+Toarucc6bOkWHqeccMcL3zvyHrYMxL3y5y9QBNNG+PHKJyvju861SlvAM7PzOWKBPp1NmK7wQ3SJ37Ex7wmSBuZpuGu4idFkS4odDF+UAoj/AVNvSIx4GrDaFYhgl/UmWE+aeTHQUiFlWX/Ziw7+9PcZvo8E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677853879; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Z4iQOhBMkM2Q5v1qi+I03T1F8EhWIR2BcL34yLYd1s4=; b=Z8t7W3wKzwZvq3K2gxk45DWhFZnEcBc0di/6KdjDzdo9rdt6zBRiGdYh2euRZRRlMluK1JrH5ecvZFpw7uP9Xn0YSTRqnQ+8TdXgdoFT34x/1XTXfYziAZIKZFX2fh+rjNglj71S+/ffDI5KvoH64HUsOjtPR1q4J920y3usZTE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1677853879572905.7446644450483; Fri, 3 Mar 2023 06:31:19 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-295-YYarw20xO4eiXBVstwR8Ww-1; Fri, 03 Mar 2023 09:29:40 -0500 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C05AA823D66; Fri, 3 Mar 2023 14:29:35 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id AD8D5492C14; Fri, 3 Mar 2023 14:29:35 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BE281194B0E2; Fri, 3 Mar 2023 14:28:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9F03E194B0C0 for ; Fri, 3 Mar 2023 14:28:37 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 758494051E4A; Fri, 3 Mar 2023 14:28:37 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id E200D4011AC8 for ; Fri, 3 Mar 2023 14:28:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677853878; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Z4iQOhBMkM2Q5v1qi+I03T1F8EhWIR2BcL34yLYd1s4=; b=USPbZptQ3/2a2WnEwSBCIrvC3pMLkb2Syqjw//I3oPvdPtg/mjzR7bG4utxXQarxAjwSuZ mHMBuStanwVVXAQpNKZ8d/5Ps7HXbYvpnBVQmK/cFs30vSiPloo9BvNWV53o9JlM2hsczH gjcvDAHcrA6UxJCVb9hK6bNuXacLzTg= X-MC-Unique: YYarw20xO4eiXBVstwR8Ww-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 28/31] qemu: Always assume QEMU_CAPS_CPU_AARCH64_OFF Date: Fri, 3 Mar 2023 15:28:02 +0100 Message-Id: <2fa95a08ac6bf5faa39e54300c75b1a33cf4434b.1677853487.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1677853881596100001 Content-Type: text/plain; charset="utf-8" We always assert the flag for aarch64 qemus and in qemu the 'aarch64' cpu property doesn't seem to be optional. Remove checks and remove impossible test case. Signed-off-by: Peter Krempa --- src/qemu/qemu_validate.c | 9 --------- tests/qemuxml2argvdata/aarch64-kvm-32-on-64.err | 1 - tests/qemuxml2argvtest.c | 5 +---- 3 files changed, 1 insertion(+), 14 deletions(-) delete mode 100644 tests/qemuxml2argvdata/aarch64-kvm-32-on-64.err diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index c877aa73d4..4746c14441 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -430,15 +430,6 @@ qemuValidateDomainDefCpu(virQEMUDriver *driver, if (cpu->model || cpu->mode !=3D VIR_CPU_MODE_CUSTOM) { switch ((virCPUMode) cpu->mode) { case VIR_CPU_MODE_HOST_PASSTHROUGH: - if (def->os.arch =3D=3D VIR_ARCH_ARMV7L && - driver->hostarch =3D=3D VIR_ARCH_AARCH64) { - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_CPU_AARCH64_OFF)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("QEMU binary does not support CPU hos= t-passthrough for armv7l on aarch64 host")); - return -1; - } - } - if (cpu->migratable && cpu->migratable !=3D VIR_TRISTATE_SWITCH_OFF && !virQEMUCapsGet(qemuCaps, QEMU_CAPS_CPU_MIGRATABLE)) { diff --git a/tests/qemuxml2argvdata/aarch64-kvm-32-on-64.err b/tests/qemuxm= l2argvdata/aarch64-kvm-32-on-64.err deleted file mode 100644 index 3858f112b4..0000000000 --- a/tests/qemuxml2argvdata/aarch64-kvm-32-on-64.err +++ /dev/null @@ -1 +0,0 @@ -unsupported configuration: QEMU binary does not support CPU host-passthrou= gh for armv7l on aarch64 host diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index e515c2c0df..33dcb247de 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -2579,10 +2579,7 @@ mymain(void) DO_TEST("aarch64-kvm-32-on-64", QEMU_CAPS_DEVICE_VIRTIO_MMIO, QEMU_CAPS_DEVICE_PL011, - QEMU_CAPS_KVM, QEMU_CAPS_CPU_AARCH64_OFF); - DO_TEST_PARSE_ERROR("aarch64-kvm-32-on-64", - QEMU_CAPS_DEVICE_VIRTIO_MMIO, - QEMU_CAPS_KVM); + QEMU_CAPS_KVM); DO_TEST("aarch64-pci-serial", QEMU_CAPS_DEVICE_PCI_SERIAL, QEMU_CAPS_OBJECT_GPEX, --=20 2.39.2