From nobody Sun Feb 8 12:43:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1770045041; cv=none; d=zohomail.com; s=zohoarc; b=ajmxWsKF+5c7wLQV4GQ4XTknDBXglb8tMhXjGh8WroXbt7NH5fJIofwQ5KjT8V0FUSGJbaCNPZdHL4aHsEUr3RNJM20GmbCx5H/3FLPib+ZSHKeobRhmSQyVahaQd4HMm/NKr5KGSrJIPcEFDrhKjARxLBlyHXL+B1xOg6gixY4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770045041; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=Up6d8wExd8zp1D6uKeT/8XM0/potH4aqMgu48rXKv20=; b=Im3uEepNrL9UDA7biBaIhRKuSHrMO2Zd+8ejz7n3GpiA3oIC+hh54NhR/9lOGn4oWtHFLuASVw22iz8dQ4xlOM+qsXWEn/GzPEasMndnRkGrOLcWaQ2r6B1t8taH6Ic0FbSs1NVraGJ2ne7E15anxYd7S2bPO0k4TMcxMgNOa2w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1770045041283561.0242414135419; Mon, 2 Feb 2026 07:10:41 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 52B1F43EA0; Mon, 2 Feb 2026 10:10:40 -0500 (EST) Received: from [172.19.199.6] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id D2F2F43FC0; Mon, 2 Feb 2026 10:07:04 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 7EDD241B72; Mon, 2 Feb 2026 10:06:55 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D770041B43 for ; Mon, 2 Feb 2026 10:06:54 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-KlcK9mepO4CjpP1FzLJ1vQ-1; Mon, 02 Feb 2026 10:06:53 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5557C1954B0B for ; Mon, 2 Feb 2026 15:06:52 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.3]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9EA3F18002A6 for ; Mon, 2 Feb 2026 15:06:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770044814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Up6d8wExd8zp1D6uKeT/8XM0/potH4aqMgu48rXKv20=; b=jJaXi/3GGOIHU5nyWqAffbSbhNv6+3Ww4Lbh0mH5yVQg2CsCwpshUk3sLvX7OMHrPyG3pt /oKoSoTV8gPkUdxeUuaSUO2eza5NhdAiMHosvUcoUpbGVkp1imlXLPDcbiqsLhuGD2y20b KSWUk41IoMXnxOcAH4+Yld+/yjHdV5A= X-MC-Unique: KlcK9mepO4CjpP1FzLJ1vQ-1 X-Mimecast-MFC-AGG-ID: KlcK9mepO4CjpP1FzLJ1vQ_1770044812 To: devel@lists.libvirt.org Subject: [PATCH 3/9] qemu: monitor: Extract block latency histogram stats into 'qemuBlockStats' Date: Mon, 2 Feb 2026 16:06:40 +0100 Message-ID: <2ea1490f0dee6a305df6decafcb48e847513b49e.1770044532.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _KbIAn5Q5UpRDQL-mMCS9zwNLU1bSC-iaXXuQF9Vdgs_1770044812 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 7H5VTJGMFEUM2JHZEKXDEAWEB2JY2FLW X-Message-ID-Hash: 7H5VTJGMFEUM2JHZEKXDEAWEB2JY2FLW X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1770045045143154100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Extract the 'rd_latency_histogram', 'wr_latency_histogram', 'zone_append_latency_histogram', and 'flush_latency_histogram' stats objects into our internal data. Rather than storing 'boundaries' between bins we store them as start points. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.c | 20 +++++++++++++ src/qemu/qemu_monitor.h | 18 ++++++++++++ src/qemu/qemu_monitor_json.c | 55 ++++++++++++++++++++++++++++++++++++ 3 files changed, 93 insertions(+) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 504500c864..cdd08004fb 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -1986,6 +1986,26 @@ qemuBlockStatsFinalize(GObject *object) g_free(stats->limits); g_free(stats->timed_stats); + if (stats->histogram_read) { + g_free(stats->histogram_read->bins); + g_free(stats->histogram_read); + } + + if (stats->histogram_write) { + g_free(stats->histogram_write->bins); + g_free(stats->histogram_write); + } + + if (stats->histogram_zone) { + g_free(stats->histogram_zone->bins); + g_free(stats->histogram_zone); + } + + if (stats->histogram_flush) { + g_free(stats->histogram_flush->bins); + g_free(stats->histogram_flush); + } + G_OBJECT_CLASS(qemu_block_stats_parent_class)->finalize(object); } diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index d096f474c1..fb4fe2bc76 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -806,6 +806,18 @@ struct qemuBlockStatsLimits { }; +struct qemuBlockStatsLatencyHistogramBin { + unsigned long long start; + unsigned long long value; +}; + + +struct qemuBlockStatsLatencyHistogram { + struct qemuBlockStatsLatencyHistogramBin *bins; + size_t nbins; +}; + + struct qemuBlockStatsTimed { unsigned long long interval_length; @@ -858,6 +870,12 @@ struct _qemuBlockStats { /* block accounting/timed stats from qemu - one entry per interval con= figured */ size_t n_timed_stats; struct qemuBlockStatsTimed *timed_stats; + + /* latency histograms */ + struct qemuBlockStatsLatencyHistogram *histogram_read; + struct qemuBlockStatsLatencyHistogram *histogram_write; + struct qemuBlockStatsLatencyHistogram *histogram_zone; + struct qemuBlockStatsLatencyHistogram *histogram_flush; }; G_DECLARE_FINAL_TYPE(qemuBlockStats, qemu_block_stats, QEMU, BLOCK_STATS, = GObject); diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index a602b1e65b..5736546ec2 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -2425,6 +2425,52 @@ qemuMonitorJSONBlockStatsCollectDataTimed(virJSONVal= ue *timed_stats, } +static void +qemuMonitorJSONBlockStatsCollectDataLatencyHistogram(virJSONValue *stats, + const char *histogram= _field, + struct qemuBlockStats= LatencyHistogram **histogram_data) +{ + virJSONValue *hist; + virJSONValue *hist_bins; + virJSONValue *hist_bounds; + g_autofree struct qemuBlockStatsLatencyHistogramBin *bins =3D NULL; + size_t nbins =3D 0; + size_t i; + + if (!(hist =3D virJSONValueObjectGetObject(stats, histogram_field))) + return; + + if (!(hist_bins =3D virJSONValueObjectGetArray(hist, "bins")) || + !(hist_bounds =3D virJSONValueObjectGetArray(hist, "boundaries")) = || + virJSONValueArraySize(hist_bins) !=3D (virJSONValueArraySize(hist_= bounds) + 1)) { + VIR_DEBUG("malformed latency histogram container"); + return; + } + + nbins =3D virJSONValueArraySize(hist_bins); + bins =3D g_new0(struct qemuBlockStatsLatencyHistogramBin, nbins); + + for (i =3D 0; i < nbins; i++) { + virJSONValue *bin =3D virJSONValueArrayGet(hist_bins, i); + virJSONValue *bound =3D NULL; + + if (i > 0) + bound =3D virJSONValueArrayGet(hist_bounds, i - 1); + + if (!bin || + virJSONValueGetNumberUlong(bin, &(bins[i].value)) < 0 || + (bound && virJSONValueGetNumberUlong(bound, &(bins[i].start)) = < 0)) { + VIR_DEBUG("malformed latency histogram container"); + return; + } + } + + *histogram_data =3D g_new0(struct qemuBlockStatsLatencyHistogram, 1); + (*histogram_data)->bins =3D g_steal_pointer(&bins); + (*histogram_data)->nbins =3D nbins; +} + + static qemuBlockStats * qemuMonitorJSONBlockStatsCollectData(virJSONValue *dev, int *nstats) @@ -2469,6 +2515,15 @@ qemuMonitorJSONBlockStatsCollectData(virJSONValue *d= ev, bstats->wr_highest_offset_valid =3D true; } + qemuMonitorJSONBlockStatsCollectDataLatencyHistogram(stats, "rd_latenc= y_histogram", + &bstats->histogra= m_read); + qemuMonitorJSONBlockStatsCollectDataLatencyHistogram(stats, "wr_latenc= y_histogram", + &bstats->histogra= m_write); + qemuMonitorJSONBlockStatsCollectDataLatencyHistogram(stats, "zone_appe= nd_latency_histogram", + &bstats->histogra= m_zone); + qemuMonitorJSONBlockStatsCollectDataLatencyHistogram(stats, "flush_lat= ency_histogram", + &bstats->histogra= m_flush); + if ((timed_stats =3D virJSONValueObjectGetArray(stats, "timed_stats"))= && virJSONValueArraySize(timed_stats) > 0) qemuMonitorJSONBlockStatsCollectDataTimed(timed_stats, bstats); --=20 2.52.0