From nobody Sun Feb 8 09:22:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600884954; cv=none; d=zohomail.com; s=zohoarc; b=LtjhVb0E+UIgwKWyNr2jTwYwKSWGgC46ZluvUDWngOrgXA2aFo9NGoofrdkHIcmL4o0vhkv6mhW51I0zD4WqNMmjAI8tar80HX9/b4UF2BJ6dr7A5P2KtfF1nQVLK5i6Vrg00gY1cDD35gJtxZEVJhqwEHrljLsg/XZ1b/WsuwA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600884954; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=IeDTIRU9NrOvuBSH1cOnk6RDmJ+4D8rwW97Q3K9BV6w=; b=ezgFKggr7mQ5rUuo7TziIOIUbDnfd7w6+CUwr3LTk876kxplrIriCviMTx6GAniNBqJxP3QDBn7ekARBvFLRpQyUP/kNjiIuyDeRMHyYLGQNgZmE6fjQxJhm3c0Y+inJHkbuU6bTAegOf5QHVbNEdCFkOaZVYofxaB7BIQxh/O8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1600884954640255.78453368339865; Wed, 23 Sep 2020 11:15:54 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-334-4hnm_xGZMOqBPUZxhcFXTQ-1; Wed, 23 Sep 2020 14:15:49 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D48E8801FD8; Wed, 23 Sep 2020 18:15:42 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B476073668; Wed, 23 Sep 2020 18:15:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 80FB1183D043; Wed, 23 Sep 2020 18:15:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08NIFAHv017960 for ; Wed, 23 Sep 2020 14:15:10 -0400 Received: by smtp.corp.redhat.com (Postfix) id 3833E7882B; Wed, 23 Sep 2020 18:15:10 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id B322C78827 for ; Wed, 23 Sep 2020 18:15:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600884953; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=IeDTIRU9NrOvuBSH1cOnk6RDmJ+4D8rwW97Q3K9BV6w=; b=TZnfcIlby9awvwCBXpflP2YsQ2vykzqNraxuixo2JlOQ4Hk/jN6xAEQkqTIrg4kY510i79 jXn07ucLBNp1oPMmiPyywXjlFFOsphNbDUT0lbFqYiH83F1f+nBwAJZ6eD5jEGaqafwbk4 /kgY2wLmLM/VHs4G5AgI1x4lh8mP2Xc= X-MC-Unique: 4hnm_xGZMOqBPUZxhcFXTQ-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 02/14] vbox: remove VBoxCGlueTerm Date: Wed, 23 Sep 2020 20:14:51 +0200 Message-Id: <2e67576c26aef5107e488aaafee2dad3a0a35ac6.1600884543.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) cppcheck reports: src/vbox/vbox_XPCOMCGlue.c:226:21: style: The statement 'if (hVBoxXPCOMC!=3DNULL) hVBoxXPCOMC=3DNULL' is logically equivalent to 'hVBoxXPCOMC=3DNULL'. [duplicateConditionalAssign] It does not matter anyway because this function is never called. Fixes: e1506cb4eb7eab96e7ded27a23f0d8ac9697ac2a Signed-off-by: J=C3=A1n Tomko Reviewed-by: Martin Kletzander --- src/vbox/vbox_XPCOMCGlue.c | 19 ------------------- src/vbox/vbox_XPCOMCGlue.h | 1 - 2 files changed, 20 deletions(-) diff --git a/src/vbox/vbox_XPCOMCGlue.c b/src/vbox/vbox_XPCOMCGlue.c index 3cbb679110..2936ff0edb 100644 --- a/src/vbox/vbox_XPCOMCGlue.c +++ b/src/vbox/vbox_XPCOMCGlue.c @@ -217,25 +217,6 @@ VBoxCGlueInit(unsigned int *version) } =20 =20 -/** - * Terminate the C glue library. - */ -void -VBoxCGlueTerm(void) -{ - if (hVBoxXPCOMC !=3D NULL) { -#if 0 /* VBoxRT.so doesn't like being reloaded. See @bugref{3725}. */ - dlclose(g_hVBoxXPCOMC); -#endif - hVBoxXPCOMC =3D NULL; - } - - pVBoxFuncs_v2_2 =3D NULL; - g_pfnGetFunctions =3D NULL; -} - - - /* * In XPCOM an array is represented by 1) a pointer to an array of pointers * that point to the items and 2) an unsigned int representing the number = of diff --git a/src/vbox/vbox_XPCOMCGlue.h b/src/vbox/vbox_XPCOMCGlue.h index 517b02393f..d0e579482e 100644 --- a/src/vbox/vbox_XPCOMCGlue.h +++ b/src/vbox/vbox_XPCOMCGlue.h @@ -36,7 +36,6 @@ extern PFNVBOXGETXPCOMCFUNCTIONS g_pfnGetFunctions; =20 int VBoxCGlueInit(unsigned int *version); -void VBoxCGlueTerm(void); =20 typedef struct _vboxArray vboxArray; =20 --=20 2.26.2