From nobody Mon Sep 16 18:52:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1674811633; cv=none; d=zohomail.com; s=zohoarc; b=iArNUcpG8EtgGaNvtzA+OY4/C+yY2vCjaBtMfFtlfUb+bvtwu19n9gnHKClh9wSGvZIXk+kOk0UH/cppSxf5Pthf5m62g9TsM1jerNG2obtgTKJjGDtQy/GBM+f3fw7ma7w+nnlO4NV0OFhWIRf1FeWxZ/Ojkch3U9uF+igMvt8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674811633; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=P4xtQRvsKZ5hPho6n5mYC8P6CpWCapVmE/Rml1VOAbA=; b=jA+I7h9j/b+0j2qF37lwoBKl4MDf/w2413oUf/P++IwaK3H4yhWOM4D63ZSn1Gxf8x4kZwJns0FKBY7ue6uk/j7BL2oFZ1ZjRFepWMyRXDB5eThbzEBx4FRZrjJyzmIH6JOIk6wmcS0XYNycmX0sxmSVT72t8cwU0j9+mx9hRJs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1674811633973378.70406674870367; Fri, 27 Jan 2023 01:27:13 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-120-wrewwKtyN4OvhOxWld_g3A-1; Fri, 27 Jan 2023 04:27:09 -0500 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 526D2800B30; Fri, 27 Jan 2023 09:27:07 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4B9F9492B02; Fri, 27 Jan 2023 09:27:05 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BFECF194658D; Fri, 27 Jan 2023 09:26:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 0F763194658C for ; Fri, 27 Jan 2023 09:26:59 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id E6BD614171C0; Fri, 27 Jan 2023 09:26:58 +0000 (UTC) Received: from ridgehead.home.lan (ovpn-193-168.brq.redhat.com [10.40.193.168]) by smtp.corp.redhat.com (Postfix) with ESMTP id 64F3014171BE; Fri, 27 Jan 2023 09:26:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674811632; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=P4xtQRvsKZ5hPho6n5mYC8P6CpWCapVmE/Rml1VOAbA=; b=d9spb2P9IFXHVxnG0KtwctJ2L3Aw64Fb36tdDCbm5LypoaAKuEBugIwoyIjvRUDd5PGPFS 9VxNNzNeR53H9wg2YZIdQHgnF423hi8C9d7UKRz5j++/eOaaV9hwQ1aKY65WEL2x03liEu 4Qgpx9Vt9v5kvhoBr1BrVd+qbbM+OFA= X-MC-Unique: wrewwKtyN4OvhOxWld_g3A-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH v2 1/8] syntax-check: Drop the shell's 'check for minus' rule Date: Fri, 27 Jan 2023 10:26:49 +0100 Message-Id: <2e1314f64dd3b5b8217fe64edcbda36b671a3a1d.1674811615.git.eskultet@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1674811635759100005 Content-Type: text/plain; charset="utf-8"; x-default="true" Apparently we've only had it because the -[ao] options weren't portable at the time, but according to https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html both are defined in POSIX.1-2017 revision which is old enough for all our supported platforms to have adopted it already. Therefore, drop the rule. Signed-off-by: Erik Skultety --- build-aux/syntax-check.mk | 9 --------- 1 file changed, 9 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 96d322ee04..7b07fd4712 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -1183,15 +1183,6 @@ sc_prohibit_double_semicolon: halt=3D"Double semicolon detected" \ $(_sc_search_regexp) =20 -_ptm1 =3D use "test C1 && test C2", not "test C1 -''a C2" -_ptm2 =3D use "test C1 || test C2", not "test C1 -''o C2" -# Using test's -a and -o operators is not portable. -# We prefer test over [, since the latter is spelled [[ in configure.ac. -sc_prohibit_test_minus_ao: - @prohibit=3D'(\