From nobody Fri May 17 03:00:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1660217629; cv=none; d=zohomail.com; s=zohoarc; b=JS5FN2e2Ub3lrr4MZ6sY3pWV5ghBTtbF6+pGsQ1nzzpgrDzZPNfj9va57tA96y55NpqgMqc6XGfH+L6zZIP/LrZTZ67jCNJDWrjGZlDXYexcVQ6V26bHtzKaKXYQDVByRHmA9NmGKFDjwBM3rGyTfWtAZrtl03NfyLypBSD/eWQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660217629; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=nxQ+kqcwO09n3bWB1lIdmFJowP4u2g5ylf6H0LgzCNc=; b=OtSxi1mx4y8A7mf1wCYhl0C0bPvL95082OTuLRFWi4u3rEm5vZnqV0+kY5EiVXZz+5rrAXuK02jZIhBeP8dNo/6BCPKyw7Ny8D2for8M9iDA3HUzOY3ecn8lHEFnJUCQ9E+82FTjp8rr/zKXDzFAOa0XqebP2A9goLivq/vp3tQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1660217629613986.566632640752; Thu, 11 Aug 2022 04:33:49 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-34-nHT3Xy0WPQeZs2O9oUd-HQ-1; Thu, 11 Aug 2022 07:33:46 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 67EAF802E5C; Thu, 11 Aug 2022 11:33:44 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 561232166B26; Thu, 11 Aug 2022 11:33:44 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 05B681946A53; Thu, 11 Aug 2022 11:33:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C51D41946A41 for ; Thu, 11 Aug 2022 11:33:42 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 9152740315E; Thu, 11 Aug 2022 11:33:42 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0925C492C3B for ; Thu, 11 Aug 2022 11:33:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660217628; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=nxQ+kqcwO09n3bWB1lIdmFJowP4u2g5ylf6H0LgzCNc=; b=KI7XFOOn24u/GopAGPxPbVnBJzSJB4lPhjsYezDvEVNYi8uG6CuxsR1kRSvr6eGu9saWmI nS2graerF2AzyP24WfyXMGZdcgJBDbXwca0EhZvnJYrpSVrYjK46e0lSUq6WHoIZv82Dc6 LY7cb7R4FE6A6xgB0RJIzlxRuOvGTEE= X-MC-Unique: nHT3Xy0WPQeZs2O9oUd-HQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH] qemuMigrationSrcWaitForSpice: Remove return value Date: Thu, 11 Aug 2022 13:33:41 +0200 Message-Id: <2df9fe92b5f009c8593e358df98c241eb017792a.1660217611.git.pkrempa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1660217631521100001 Content-Type: text/plain; charset="utf-8" The only caller doesn't check the return value and actually doesn't have one either. Remove the return value and adjust return statements. Signed-off-by: Peter Krempa Reviewed-by: Erik Skultety Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_migration.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 0b48852b9d..e28f738ebf 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1773,21 +1773,20 @@ qemuMigrationDstPostcopyFailed(virDomainObj *vm) } -static int +static void qemuMigrationSrcWaitForSpice(virDomainObj *vm) { qemuDomainObjPrivate *priv =3D vm->privateData; qemuDomainJobPrivate *jobPriv =3D priv->job.privateData; if (!jobPriv->spiceMigration) - return 0; + return; VIR_DEBUG("Waiting for SPICE to finish migration"); while (!jobPriv->spiceMigrated && !priv->job.abortJob) { if (qemuDomainObjWait(vm) < 0) - return -1; + return; } - return 0; } --=20 2.37.1