From nobody Sat Feb 7 09:20:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1732634276889261.1520101401584; Tue, 26 Nov 2024 07:17:56 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 425C91BF0; Tue, 26 Nov 2024 10:17:56 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id AAAC11BF6; Tue, 26 Nov 2024 10:16:56 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id A1B9618C6; Tue, 26 Nov 2024 10:16:50 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 221FF1397 for ; Tue, 26 Nov 2024 10:16:50 -0500 (EST) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-3Pn9NakhP6ybe5c0lDNNyg-1; Tue, 26 Nov 2024 10:16:48 -0500 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 33D871901FBB for ; Tue, 26 Nov 2024 15:16:25 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.6]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7272D19776DE for ; Tue, 26 Nov 2024 15:16:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732634209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GmzXwtxbHUpDIOSMASiSgoxjPZd96AoRcPVuT5hp7VA=; b=BpzxoHF7QB4hwxkaYtTgzEMf43hLzhD/J/Oxqevcl4aXuP/doe/pKhEWqW11KeDJRa+IWy ondys0xzdstL9p409kIPgaZC+JstC3RBpZRKyhEjZ++n1aqyu+DNq48/8nlMN1pE77gZHe 3tUdQL54NbTDSPYPfZspP2VJfxD2g4g= X-MC-Unique: 3Pn9NakhP6ybe5c0lDNNyg-1 X-Mimecast-MFC-AGG-ID: 3Pn9NakhP6ybe5c0lDNNyg From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 1/8] qemuBlockReopenAccess: Add debug log entry about state of the image Date: Tue, 26 Nov 2024 16:16:12 +0100 Message-ID: <2d0f2ec06b0d989e718e4119861d6bc061751168.1732633990.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7RpGrYV6i9_p9OnCaXB1e9DKsBYCnVzoE67Hb0jKmgo_1732634207 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 6CYOF5FOD5B4IHB6JAYBUZ2RQ7W24X36 X-Message-ID-Hash: 6CYOF5FOD5B4IHB6JAYBUZ2RQ7W24X36 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1732634278953019100 Content-Type: text/plain; charset="utf-8" Log the node name and current and expected state to simplify debugging. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index dab9ce4dc2..088c128424 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -3174,6 +3174,10 @@ qemuBlockReopenAccess(virDomainObj *vm, int rc; int ret =3D -1; + VIR_DEBUG("nodename:'%s' current-ro:'%d requested-ro=3D'%d'", + qemuBlockStorageSourceGetEffectiveNodename(src), + src->readonly, readonly); + if (src->readonly =3D=3D readonly) return 0; --=20 2.47.0