From nobody Mon Feb 2 07:25:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1769443885; cv=none; d=zohomail.com; s=zohoarc; b=h+7KRx9O4Vvi6GT22wYMUzO3hGhpHN03eINQ6L12x6DF1nYpYA2nuKCK25zbo8f9WhSEc5C+f+yONlO1N9QTes3F9by743F2Waxj09RlrjHede8mgj+wU1X9A8EDoXPmbqR8q06SNsHBb4yGpWJnrbS6mYxDjS+AKmFHgnvzJGU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769443885; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=AC7HZbVtcEiVwB0pCqrt4qkvn0/1Z1C5DhC/pwcrxy0=; b=G5hHJPSIidkizT+0+d52bRrCcG/qOjYg1ht/GpiX/wywVoIigWM/LVbR2dbo5DKmAv3HKrtKvX9T5PBDVdLRYsMxifQFxMHIpIM4UKEf4GLyzbv70no0TWZuVVDqYRGSYAlJ9qsJe9JVriHDgArWFL7i0Sgtjl2O+I5d6jFKLeY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1769443885882736.3720356840353; Mon, 26 Jan 2026 08:11:25 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 34E11419AD; Mon, 26 Jan 2026 11:11:25 -0500 (EST) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id A06BA41B1A; Mon, 26 Jan 2026 11:08:15 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id D905E4199F; Mon, 26 Jan 2026 11:08:10 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id DF8E641C8E for ; Mon, 26 Jan 2026 11:07:06 -0500 (EST) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-299-RmhT_r-lNP6qrAReAyUyqA-1; Mon, 26 Jan 2026 11:06:59 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 745F21955D84 for ; Mon, 26 Jan 2026 16:06:58 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.3]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B3748180049F for ; Mon, 26 Jan 2026 16:06:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769443626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AC7HZbVtcEiVwB0pCqrt4qkvn0/1Z1C5DhC/pwcrxy0=; b=b0uoEEizAJkem4CjfbFiIb/i1gYayWV9NgcQW69zpWKSHw5eC4JU8HQ94vI+oWcs4NyPY0 TxS1hhfdSBjNPbFsZTJx8157953DE2dQiT9UHcJde+BZNPZhvqqdh/jX/B82qPto3PQ1nu GLtUzQNDo9SoSQECxdeoYngkWN+ouOs= X-MC-Unique: RmhT_r-lNP6qrAReAyUyqA-1 X-Mimecast-MFC-AGG-ID: RmhT_r-lNP6qrAReAyUyqA_1769443618 To: devel@lists.libvirt.org Subject: [PATCH v2 2/5] qemuSnapshotUpdateBackingStore: Remove stale comment Date: Mon, 26 Jan 2026 17:06:50 +0100 Message-ID: <2cb32f35c2191ec80687f25a74b2ecb2139c84e5.1769443445.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TWcNuTVs4TsXckw3aw6_F1-gLS54ShPSwWSDOLRJZTs_1769443618 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: MTO7DLLWNFWB7PN3BV5DHKSKWZHPVEIK X-Message-ID-Hash: MTO7DLLWNFWB7PN3BV5DHKSKWZHPVEIK X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1769443888703154100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The code does a 'qemu-img rebase' rather than a 'qemu-img create' what the commit suggests. Since we enumerate all arguments right below, there's no need for a comment. Signed-off-by: Peter Krempa --- src/qemu/qemu_snapshot.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index 8f58df3b45..19bb6f8b37 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -3710,7 +3710,6 @@ qemuSnapshotUpdateBackingStore(qemuSnapshotDeleteExte= rnalData *data) struct _qemuSnapshotDisksWithBackingStoreData *backingData =3D cur= ->data; g_autoptr(virCommand) cmd =3D NULL; - /* creates cmd line args: qemu-img create -f qcow2 -o */ if (!(cmd =3D virCommandNewArgList("qemu-img", "rebase", "-u", --=20 2.52.0