From nobody Sun Feb 8 19:43:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1693322011; cv=none; d=zohomail.com; s=zohoarc; b=Mi2GzsYoyPxlVVXmRCjuu1etm54vfcc6zlXMF0z3byRcpos+8gUIjc2ozEikquuKlzI+X/neqvfI8N/BOlR/ILIGhl5D0NUnBy1GzN9woexJYWNtJZ/22HkpGN9y2Zq59Qh60xSzWZvQJFsfzwkmhlFUhn3YBINZkJd3CmBJzmU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693322011; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=H3tCeW1vLR2mmjY6ccE6CbQRsvBvY43E8QPsTrd5xrk=; b=lLwLlQ6xisz4MAUwdFX3EcyigC3pwRtCJtoGAcDcG4dCqU0pEltnQWq0TMocRTXze04GTDYDssDhNMlVu8wce9mEtbsMYiX7J4YDSWDsI8U3xHJwiJ38Q19mLDtS1YHTBvMx7ibosqy0jyqeF1j5AVTvsUwawqoM9ucj8bgblQs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1693322011406202.7552897603756; Tue, 29 Aug 2023 08:13:31 -0700 (PDT) Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-60-UppzSeOEPTqelcdYVjDrBw-1; Tue, 29 Aug 2023 11:13:23 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B2EA11C068ED; Tue, 29 Aug 2023 15:13:20 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9CABD40C2063; Tue, 29 Aug 2023 15:13:20 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BAB6319451D0; Tue, 29 Aug 2023 15:13:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 4015F19465B6 for ; Tue, 29 Aug 2023 15:13:12 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 2181240C2070; Tue, 29 Aug 2023 15:13:12 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id BD44640C2063 for ; Tue, 29 Aug 2023 15:13:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693322010; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=H3tCeW1vLR2mmjY6ccE6CbQRsvBvY43E8QPsTrd5xrk=; b=cCvpnhCV3WfyRb0U0jxjhxG6a8fhPqOSxsNQGoKzUGs8Y9gStHQS3mUqRj3p7vzQ09TlvH 2WowfXH7SAlGJX2sQefDHz5FRoeOtrzZITVrjy6otNBt4yJcPhzRDiIz/95xRpIMtDwcD9 VWa9l6LZc9PomlrtgBIt/lEErtBAeBs= X-MC-Unique: UppzSeOEPTqelcdYVjDrBw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 1/4] vircommand: Drop unused arguments from virCommandMassCloseGetFDs*() Date: Tue, 29 Aug 2023 17:13:06 +0200 Message-ID: <2cb0a9c461309bda546ad18bcafb888fc46c87fe.1693321948.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1693322013132100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Both virCommandMassCloseGetFDsLinux() and virCommandMassCloseGetFDsGeneric() take @cmd argument only to mark it as unused. Drop it from both. Signed-off-by: Michal Privoznik --- src/util/vircommand.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/util/vircommand.c b/src/util/vircommand.c index 5f094c625a..60d419a695 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -485,8 +485,7 @@ virExecCommon(virCommand *cmd, gid_t *groups, int ngrou= ps) * onto child process (well, the one we will exec soon since this * is called from the child). */ static int -virCommandMassCloseGetFDsLinux(virCommand *cmd G_GNUC_UNUSED, - virBitmap *fds) +virCommandMassCloseGetFDsLinux(virBitmap *fds) { g_autoptr(DIR) dp =3D NULL; struct dirent *entry; @@ -518,8 +517,7 @@ virCommandMassCloseGetFDsLinux(virCommand *cmd G_GNUC_U= NUSED, # else /* !__linux__ */ =20 static int -virCommandMassCloseGetFDsGeneric(virCommand *cmd G_GNUC_UNUSED, - virBitmap *fds) +virCommandMassCloseGetFDsGeneric(virBitmap *fds) { virBitmapSetAll(fds); return 0; @@ -554,10 +552,10 @@ virCommandMassCloseFrom(virCommand *cmd, fds =3D virBitmapNew(openmax); =20 # ifdef __linux__ - if (virCommandMassCloseGetFDsLinux(cmd, fds) < 0) + if (virCommandMassCloseGetFDsLinux(fds) < 0) return -1; # else - if (virCommandMassCloseGetFDsGeneric(cmd, fds) < 0) + if (virCommandMassCloseGetFDsGeneric(fds) < 0) return -1; # endif =20 --=20 2.41.0