From nobody Tue Mar 24 00:58:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774252915; cv=none; d=zohomail.com; s=zohoarc; b=HHwzTl9/9/puFS+lMhBXbD5LSh8whGYdtRhxNNkPVgGoPCzD2FPm9698Fy3xY8O6nHHGtmmkhWywcS9VFI4eUjqjpS92zR55ybET8oYJ+VoSkND5CKBKyxXgeS6R2yG+jbwnFuPchigVPA+pDa70+7Bs1Nq6YkO1cNb/6mzuTJA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774252915; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=mYWmwBm4V/5V5Oq35+xnwR/TSrQ0niYWHMmhVWmByyo=; b=iNs4speu6nhkbGi7SXzg3A349NzyuH5r3CfEE28WguxyQpHhTWatLi5Lh6dtOIwQto3aWS3x2C7dVi5eE+7zFVRM1AysurnB0lof3YmtZnq3gDjHsjbnhd2G2JlpDSbtrabYYD0NdI8F6K49XPFvH3s3Z+J4TDATtmW56iwsJkk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774252915050591.0083961033167; Mon, 23 Mar 2026 01:01:55 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 44BB241886; Mon, 23 Mar 2026 04:01:53 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 40C193F837; Mon, 23 Mar 2026 04:00:58 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 974E63F276; Mon, 23 Mar 2026 04:00:54 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8379A3F275 for ; Mon, 23 Mar 2026 04:00:53 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-130-ebisT_H1MwirEpXj0nnCtQ-1; Mon, 23 Mar 2026 04:00:51 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 95C7518002E7 for ; Mon, 23 Mar 2026 08:00:50 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 96C2B1955D71 for ; Mon, 23 Mar 2026 08:00:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774252852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mYWmwBm4V/5V5Oq35+xnwR/TSrQ0niYWHMmhVWmByyo=; b=KRR6Ua9kVLKsNRgpkUcMVjOhqxniIUnFQkkXKUet4FrXmArhIjE0b1+T8leIY06++T8ux1 Z6mc5T71TNHOm+akPs2e8TmvVMw1NYkIvnc+AL13vsmRPn/svxB/FO3x79lIZh5WVMg5as dLTcSNnYCtuCkLck+KP1ZwlBiwk8OSo= X-MC-Unique: ebisT_H1MwirEpXj0nnCtQ-1 X-Mimecast-MFC-AGG-ID: ebisT_H1MwirEpXj0nnCtQ_1774252850 To: devel@lists.libvirt.org Subject: [PATCH 1/5] qemu: validate: Reject configs with VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE Date: Mon, 23 Mar 2026 09:00:38 +0100 Message-ID: <2bf1899ce05d6f2c65d63eb836f13c0fd6403922.1774252743.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: nmCBPwkZCzf20oNfK1h5ncR7BqAcrqjK-6APROrIS2g_1774252850 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CCTBFPTCMZGNX44ZRELHSKJJLZO6ZCUS X-Message-ID-Hash: CCTBFPTCMZGNX44ZRELHSKJJLZO6ZCUS X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774252917040158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The support was dropped since v3.1.0-29-g93aee84f5. Refuse the config at validation step. Signed-off-by: Peter Krempa --- src/qemu/qemu_validate.c | 8 +------- tests/qemuxmlconfdata/fs9p-ccw.s390x-latest.args | 4 +--- tests/qemuxmlconfdata/fs9p-ccw.s390x-latest.xml | 8 +------- tests/qemuxmlconfdata/fs9p-ccw.xml | 5 ----- tests/qemuxmlconfdata/fs9p.x86_64-latest.args | 2 -- tests/qemuxmlconfdata/fs9p.x86_64-latest.xml | 6 ------ tests/qemuxmlconfdata/fs9p.xml | 5 ----- 7 files changed, 3 insertions(+), 35 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index b3db2c71d8..642244b62e 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -5136,13 +5136,7 @@ qemuValidateDomainDeviceDefFS(virDomainFSDef *fs, break; case VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE: - if (fs->accessmode !=3D VIR_DOMAIN_FS_ACCESSMODE_PASSTHROUGH) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("only supports passthrough accessmode")); - return -1; - } - break; - + /* removed since qemu 4.0.0 see v3.1.0-29-g93aee84f57 */ case VIR_DOMAIN_FS_DRIVER_TYPE_LOOP: case VIR_DOMAIN_FS_DRIVER_TYPE_NBD: case VIR_DOMAIN_FS_DRIVER_TYPE_PLOOP: diff --git a/tests/qemuxmlconfdata/fs9p-ccw.s390x-latest.args b/tests/qemux= mlconfdata/fs9p-ccw.s390x-latest.args index c7353dd8e4..6771547e80 100644 --- a/tests/qemuxmlconfdata/fs9p-ccw.s390x-latest.args +++ b/tests/qemuxmlconfdata/fs9p-ccw.s390x-latest.args @@ -32,9 +32,7 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGue= st1/.config \ -device '{"driver":"virtio-9p-ccw","id":"fs0","fsdev":"fsdev-fs0","mount_t= ag":"/import/from/host","devno":"fe.0.0001"}' \ -fsdev local,security_model=3Dmapped,writeout=3Dimmediate,id=3Dfsdev-fs1,p= ath=3D/export/to/guest2 \ -device '{"driver":"virtio-9p-ccw","id":"fs1","fsdev":"fsdev-fs1","mount_t= ag":"/import/from/host2","devno":"fe.0.0002"}' \ --fsdev handle,writeout=3Dimmediate,id=3Dfsdev-fs2,path=3D/export/to/guest3= \ --device '{"driver":"virtio-9p-ccw","id":"fs2","fsdev":"fsdev-fs2","mount_t= ag":"/import/from/host3","devno":"fe.0.0003"}' \ -audiodev '{"id":"audio1","driver":"none"}' \ --device '{"driver":"virtio-balloon-ccw","id":"balloon0","devno":"fe.0.0004= "}' \ +-device '{"driver":"virtio-balloon-ccw","id":"balloon0","devno":"fe.0.0003= "}' \ -sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ -msg timestamp=3Don diff --git a/tests/qemuxmlconfdata/fs9p-ccw.s390x-latest.xml b/tests/qemuxm= lconfdata/fs9p-ccw.s390x-latest.xml index eb85ac4824..debf50c99b 100644 --- a/tests/qemuxmlconfdata/fs9p-ccw.s390x-latest.xml +++ b/tests/qemuxmlconfdata/fs9p-ccw.s390x-latest.xml @@ -35,15 +35,9 @@
- - - - -
-