From nobody Mon Feb 9 03:14:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614183544; cv=none; d=zohomail.com; s=zohoarc; b=HOcrlOE8VwHgy9xv8DD+WGz46ZH5gbO15jC2zAah4xN0ERfuGIOuGpf23To3j9ZC1DFNIVRmAMt0AjVfbwT3qQC0pjMDXpM1Z6WPWrcGl5A5EY2wClLZtgHASUSgSY06+TZVpEOh3frgbX6ydsRuNnw05oMTySqRUaclEVD+k9Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614183544; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0jkHwOpE0PXKaM8TkzRmrj/qhKZ3fESEzXu9Es+YUgs=; b=kAQuhGF62S1PQHKH8nhQgQfTGaJ7PUAwc9ZIJHsBodQaHPjHDDrNDGSrdWUizPFp6C8asbXOii62x2J3PVO3GMURi+f0CmO2Emgaf7GJ/ZCA07dVsYgWdh9j22WAqhpxnj9AuhxhAxiCEhu1Drrg1YczP97zkQnyh+wGcd2PsR8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1614183544919285.616941497865; Wed, 24 Feb 2021 08:19:04 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-378-js15b8l1M0mLFGNwcvZIzw-1; Wed, 24 Feb 2021 11:18:41 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BF3875074B; Wed, 24 Feb 2021 16:18:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9CB0C5D9E2; Wed, 24 Feb 2021 16:18:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5C6E618077DE; Wed, 24 Feb 2021 16:18:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 11OGIC3r016194 for ; Wed, 24 Feb 2021 11:18:12 -0500 Received: by smtp.corp.redhat.com (Postfix) id 42CD8646DC; Wed, 24 Feb 2021 16:18:12 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91BC16EF46 for ; Wed, 24 Feb 2021 16:18:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614183543; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=0jkHwOpE0PXKaM8TkzRmrj/qhKZ3fESEzXu9Es+YUgs=; b=JtMDPY4+C/6dp4XZXt++56oA3aiI8AyJQ1PUp7zeOerp/sqVnh0QvF3FgBdRu3xVLk4Gjv fXHDMz1Oo2jP/CKRqx/CA9oUGHoG/GGiGWcwwlojgrkRhim95NwW+17ifxVHoqb6JpWTZ1 rRGC3Juhjlav1z+0WYyzY11hOL4zFsQ= X-MC-Unique: js15b8l1M0mLFGNwcvZIzw-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 31/33] storage: Don't report OOM error on failure of glfs_new Date: Wed, 24 Feb 2021 17:17:06 +0100 Message-Id: <2bbe86cb59cc5e053b96f3077e90aa9e63b5602c.1614182583.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" OOM isn't the only failure glfs_new can encounter. Report an error which might give more insight. libgfapi seems to be setting errno but reporting a system error migt be misleading. Signed-off-by: Peter Krempa --- src/storage/storage_backend_gluster.c | 3 ++- src/storage_file/storage_file_backend_gluster.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_backend_gluster.c b/src/storage/storage_ba= ckend_gluster.c index 8de0cb8a6b..e673922df6 100644 --- a/src/storage/storage_backend_gluster.c +++ b/src/storage/storage_backend_gluster.c @@ -114,7 +114,8 @@ virStorageBackendGlusterOpen(virStoragePoolObjPtr pool) /* Actually connect to glfs */ if (!(ret->vol =3D glfs_new(ret->volname))) { - virReportOOMError(); + virReportError(VIR_ERR_OPERATION_FAILED, + _("failed to create glfs object for '%s'"), ret->vo= lname); goto error; } diff --git a/src/storage_file/storage_file_backend_gluster.c b/src/storage_= file/storage_file_backend_gluster.c index 9b3b783274..8c7a583886 100644 --- a/src/storage_file/storage_file_backend_gluster.c +++ b/src/storage_file/storage_file_backend_gluster.c @@ -120,7 +120,8 @@ virStorageFileBackendGlusterInit(virStorageSourcePtr sr= c) (unsigned int)drv->uid, (unsigned int)drv->gid); if (!(priv->vol =3D glfs_new(src->volume))) { - virReportOOMError(); + virReportError(VIR_ERR_OPERATION_FAILED, + _("failed to create glfs object for '%s'"), src->vo= lume); goto error; } --=20 2.29.2