From nobody Sat May 4 17:45:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1575987139; cv=none; d=zohomail.com; s=zohoarc; b=W622+rZjezArtkhAjLgEwztuRU/PfuvDWkoMsVQcD/8LfJu0xm+EYY9dOVEUsWUAZWQ5JsnBZv8mG7NksNvvUorYgbvMAutPRLZ7AIP76+GjsMZZgXeqwWTVBtUhDBQ+IkQpuBWnnv2kHw/QUVHXLrCcicAGaNON6c9C9HMjc/Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1575987139; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=TxAluoWQVzOoA+Flomi1rVzZzw4hUftNu5/rEdrpz5A=; b=dj8Mhfyz28Jd7oZL4mZpfnQR/U43XIkMz9yFevEhCObAHFBDOBDM482DDa390XTWW5o5cb1e1jVAH7fUBtW/Q+s9SKJ4yyRaVUIObazTlEgOq+XmMLOHfRxbvGW1+BiyUjO6Kh/ib1vAB2wLX1YyWt4pmBLhfakgUl8MzLmhYgM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1575987139463628.720902089587; Tue, 10 Dec 2019 06:12:19 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-308-F7I3CMigO02S6LJXcZQAKw-1; Tue, 10 Dec 2019 09:12:16 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9B5DE107ACC9; Tue, 10 Dec 2019 14:12:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 691E71001901; Tue, 10 Dec 2019 14:12:09 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BBE181832DE7; Tue, 10 Dec 2019 14:12:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xBAEC4M1026301 for ; Tue, 10 Dec 2019 09:12:04 -0500 Received: by smtp.corp.redhat.com (Postfix) id 452235DA75; Tue, 10 Dec 2019 14:12:04 +0000 (UTC) Received: from antique-laptop.redhat.com (ovpn-200-38.brq.redhat.com [10.40.200.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id A10FE5DA2C for ; Tue, 10 Dec 2019 14:12:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575987138; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TxAluoWQVzOoA+Flomi1rVzZzw4hUftNu5/rEdrpz5A=; b=cKUTgNeD8Bh///4BahdE3UBNtdBMIoS8kyCcEIGxj/iy9gzkVBHLwYZPbBFzhne01s4eMq bZoHhpKagh87AKfxpgwAJEzVqRkp7TVu3C3ub8mAU2+zYX8oQM3vqPDSboMnh7Jx7/B8Pg VchjTBhRYs1FDyFtf0k1YbE9exUskBE= From: Pavel Hrdina To: libvir-list@redhat.com Date: Tue, 10 Dec 2019 15:11:59 +0100 Message-Id: <2b82d2dbaf2e6259807cb541b15c346bc544edec.1575987088.git.phrdina@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] virkeyfile: fix compilation error with clang X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: F7I3CMigO02S6LJXcZQAKw-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Clang complains about condition being always true: src/util/virkeyfile.c:113:23: error: result of comparison of constant 128 w= ith expression of type 'const char' is always true [-Werror,-Wtautological-= constant-out-of-range-compare] while (!IS_EOF && IS_ASCII(CUR) && CUR !=3D ']') ^~~~~~~~~~~~~ src/util/virkeyfile.c:80:26: note: expanded from macro 'IS_ASCII' ~~~ ^ ~~~ Signed-off-by: Pavel Hrdina Reviewed-by: J=C3=A1n Tomko --- src/util/virkeyfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virkeyfile.c b/src/util/virkeyfile.c index 816bfae96d..ee29bd7aa6 100644 --- a/src/util/virkeyfile.c +++ b/src/util/virkeyfile.c @@ -77,7 +77,7 @@ struct _virKeyFileParserCtxt { #define IS_EOF (ctxt->cur >=3D ctxt->end) #define IS_EOL(c) (((c) =3D=3D '\n') || ((c) =3D=3D '\r')) #define IS_BLANK(c) (((c) =3D=3D ' ') || ((c) =3D=3D '\t')) -#define IS_ASCII(c) ((c) < 128) +#define IS_ASCII(c) (((unsigned char) c) < 128) #define CUR (*ctxt->cur) #define NEXT if (!IS_EOF) ctxt->cur++; =20 --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list