From nobody Mon Feb 9 08:31:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1623141935; cv=none; d=zohomail.com; s=zohoarc; b=VzYAeSCG1Lx/lxNDMwXo7a4k7kA8UCzS1EO0MOEYQxfrgoNJ45kjJBDzi95dTMMKaNQc6mSKH+eUDBhjflgjJXk/42DK99CXc1gWzTg6b0wOKirCwuHaoP2roX2ILg6HAjtfy7AuS4gaXI8fNjpxZ22hhBDt03UU9OiTY6bnsoQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623141935; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=03x20sJ7o33jRz0M+FPVquWHf0yeqE6iiz69E4f+icI=; b=P1eHX//A3kxZCdpx1LzxeX9TRnF4bTWfoEQjvbvZWvACyetF7HpHcGeLU82GobYFlxYouGFbQPdtAOtQF63YD1lU+hy/8R5PY3h+E68VtVQDIX/r3WRf4Kfh/bmuuopjK6jMBAyJ/nYMDnIoLPmd8dySDdfq+5fTggYZQliVkUQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1623141935128520.1635218542527; Tue, 8 Jun 2021 01:45:35 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-164-Imi1RkOzPH6-Ty7ptVzMDw-1; Tue, 08 Jun 2021 04:45:32 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A711C106BB24; Tue, 8 Jun 2021 08:45:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 864AF60C04; Tue, 8 Jun 2021 08:45:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4DC3944A5F; Tue, 8 Jun 2021 08:45:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1588jIj7007053 for ; Tue, 8 Jun 2021 04:45:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id AF1005D736; Tue, 8 Jun 2021 08:45:18 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.193.90]) by smtp.corp.redhat.com (Postfix) with ESMTP id 31FF35D75A for ; Tue, 8 Jun 2021 08:45:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623141934; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=03x20sJ7o33jRz0M+FPVquWHf0yeqE6iiz69E4f+icI=; b=hrVnyM9buuYvkGsrX1OB9dSJ/yArhsilYPOUxUOa5DA92FiLldJ0LN+GHU81BIc88LCjUZ ha+Zm5b72BC94JHsYYj2yZp61/Z5hKV3PkrrB9UmlBbrqZAZlXT1Fh1XgbBaszygMe3WgL wbtTezhVYtg6/bGPNzb3LjXLxSgzuz4= X-MC-Unique: Imi1RkOzPH6-Ty7ptVzMDw-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 3/5] virt-host-validate: Turn failure to read /proc/cmdline into an error Date: Tue, 8 Jun 2021 10:45:08 +0200 Message-Id: <2b1b8d32de547d1591c769215c02ca531a080eb8.1623141866.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" When validating secure guests support on s390(x) we may read /proc/cmdline and look for "prot_virt" argument. Reading the kernel command line is done via virFileReadValueString() which may fail. In such case caller won't see any error message. But we can produce the same warning/error as if "prot_virt" argument wasn't found. Not only this lets users know about the problem, it also terminates the "Checking for ...." line correctly. Signed-off-by: Michal Privoznik --- tools/virt-host-validate-common.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tools/virt-host-validate-common.c b/tools/virt-host-validate-c= ommon.c index c0cee43409..4482690b4b 100644 --- a/tools/virt-host-validate-common.c +++ b/tools/virt-host-validate-common.c @@ -470,14 +470,12 @@ int virHostValidateSecureGuests(const char *hvname, return 0; } =20 - if (virFileReadValueString(&cmdline, "/proc/cmdline") < 0) - return VIR_HOST_VALIDATE_FAILURE(level); - /* we're prefix matching rather than equality matching here, b= ecause * kernel would treat even something like prot_virt=3D'yFOO' as * enabled */ - if (virKernelCmdlineMatchParam(cmdline, "prot_virt", kIBMValue= s, + if (virFileReadValueString(&cmdline, "/proc/cmdline") >=3D 0 && + virKernelCmdlineMatchParam(cmdline, "prot_virt", kIBMValue= s, G_N_ELEMENTS(kIBMValues), VIR_KERNEL_CMDLINE_FLAGS_SEARCH= _FIRST | VIR_KERNEL_CMDLINE_FLAGS_CMP_PR= EFIX)) { --=20 2.31.1