From nobody Mon Feb 9 01:22:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697468585; cv=none; d=zohomail.com; s=zohoarc; b=Y+wrlD0VUyo/IAxDj1GzmuPPGV/ARObdUG4hIwWw2Nf3eqpdBz64lvcL/xZzf6swFoei0G6aQpTfNagnfcn60Vg6GhaO9d8wMcQLVbMNPY1K8iLtrxri7E1HOwgaWB62cxGarBLVnHd9T3JuOOzPBZ6zmY+X0ktNNVV+IQObPpw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697468585; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=4sdRo1f50A0+BXiME0qny0M0pwtsQ+xks7Wt2GkIV/4=; b=LocklXV3g77nFdWUiVcps+OVALnBcW5OPVRXqh/yksQy3SqSE/Fss0PoW476pJnzYk8x/YjnmhivGgRxRO6iksMebxPeSnR4r8SZUCCyrafCNACYZDMEPvHb+ZZwmxYD7X2sEjDNkHJWQc+nk/FqR1804jX5v88Hkd1F/vYJ9/g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1697468585565707.2382504872525; Mon, 16 Oct 2023 08:03:05 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-90uCFmtUNoasraNnpwF8_w-1; Mon, 16 Oct 2023 11:02:53 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 59CCE3C2865E; Mon, 16 Oct 2023 15:02:13 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4487225C9; Mon, 16 Oct 2023 15:02:13 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2637A1946588; Mon, 16 Oct 2023 15:02:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7FDFE1946587 for ; Mon, 16 Oct 2023 15:02:11 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 721D140C6CA0; Mon, 16 Oct 2023 15:02:11 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id EA41B40C6CA3 for ; Mon, 16 Oct 2023 15:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697468584; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=4sdRo1f50A0+BXiME0qny0M0pwtsQ+xks7Wt2GkIV/4=; b=iyUiLrANZD+w1p2G9RrmGxx2mI24tGf25hfG2mr2QvO+6DMqeTgm2o5DydhGU7JPUoySob vfb+WRkxzOqWutZJIyk0EUUhJQEqwy4KVahNPHJ/Z4rLAPteDtMzWsEAe/aThrnigH6ej8 9zuhgM/PqAt7iR/X0G1m9Xoh93dco+k= X-MC-Unique: 90uCFmtUNoasraNnpwF8_w-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 12/31] qemu: Refactor storage backend 'storage' layer helepr object setup Date: Mon, 16 Oct 2023 17:01:39 +0200 Message-ID: <2a93273d84b4ea25d31ae33e6b62033cdf82d265.1697468414.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1697468586355100001 Content-Type: text/plain; charset="utf-8" Use the new nodename accessors for any storage layer helper object. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_nbdkit.c | 4 ++-- src/qemu/qemu_process.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 885c5ee96b..1b2f09a316 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -11106,7 +11106,7 @@ qemuDomainPrepareStorageSourceFDs(virStorageSource = *src, srcpriv =3D qemuDomainStorageSourcePrivateFetch(src); - srcpriv->fdpass =3D qemuFDPassNew(src->nodestorage, priv); + srcpriv->fdpass =3D qemuFDPassNew(qemuBlockStorageSourceGetStorageNode= name(src), priv); for (i =3D 0; i < fdt->nfds; i++) { g_autofree char *idx =3D g_strdup_printf("%zu", i); diff --git a/src/qemu/qemu_nbdkit.c b/src/qemu/qemu_nbdkit.c index 3ad63cfaa0..85e61be44c 100644 --- a/src/qemu/qemu_nbdkit.c +++ b/src/qemu/qemu_nbdkit.c @@ -923,7 +923,7 @@ qemuNbdkitStopStorageSource(virStorageSource *src, if (priv && priv->nbdkitProcess && qemuNbdkitProcessStop(priv->nbdkitProcess, vm) < 0) - VIR_WARN("Unable to stop nbdkit for storage source '%s'", src-= >nodestorage); + VIR_WARN("Unable to stop nbdkit for storage source '%s'", qemu= BlockStorageSourceGetStorageNodename(src)); } } @@ -1173,7 +1173,7 @@ qemuNbdkitProcessStart(qemuNbdkitProcess *proc, logfd =3D qemuLogContextGetWriteFD(logContext); - VIR_DEBUG("starting nbdkit process for %s", proc->source->nodestorage); + VIR_DEBUG("starting nbdkit process for %s", qemuBlockStorageSourceGetS= torageNodename(proc->source)); virCommandSetErrorFD(cmd, &logfd); virCommandSetOutputFD(cmd, &logfd); virCommandSetPidFile(cmd, proc->pidfile); diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index ae0bb7bf80..63c0c62a46 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -6771,7 +6771,7 @@ qemuProcessPrepareHostStorageSourceVDPA(virStorageSou= rce *src, srcpriv =3D qemuDomainStorageSourcePrivateFetch(src); - srcpriv->fdpass =3D qemuFDPassNew(src->nodestorage, priv); + srcpriv->fdpass =3D qemuFDPassNew(qemuBlockStorageSourceGetStorageNode= name(src), priv); qemuFDPassAddFD(srcpriv->fdpass, &vdpafd, "-vdpa"); return 0; } --=20 2.41.0