From nobody Mon Apr 29 08:56:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1641399702; cv=none; d=zohomail.com; s=zohoarc; b=GTpiUJVmxEe6VzMuYoIvd2w7AjqLm2ckM8+kz8cd4lZE5q6Lnk/PoFkt3mFIgEmdY/T65C53ru61g7tH12bosS0rVDMEtCTlikrYWVksQMGNSXFjl3gIPrhDbGz4CHbN73ybHSSjHdcyZO3k8JWTwFjmHLm1XWa2aoMOgQ9y4Ms= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1641399702; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Y9yYlEz6nEZWzmILDvYEhSSY14AUyNr6RPsc5uGnh14=; b=Lbf+ZNU6IyStAdCiwnUs6lJEyyqC3mGzB5DBZJwBrfUkh/rk/3WnP3tcERBG2Aeu4AmHKhQnBaMxExl/5FSxAdVKniO6AK3tQPpAD3goH7++cN2Y8IUvRORPbsnUmfFEoRV98jTguYRy1KhvnbZrWwlLOE/pGJNqN11Cs/4bZbg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1641399702482244.73334149184802; Wed, 5 Jan 2022 08:21:42 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-327-FdyeCaCxMx6LFD0ziSLarw-1; Wed, 05 Jan 2022 11:21:37 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D985B3E744; Wed, 5 Jan 2022 16:21:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 566962C2C8; Wed, 5 Jan 2022 16:21:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 01B134BB7C; Wed, 5 Jan 2022 16:21:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 205GLNQk001170 for ; Wed, 5 Jan 2022 11:21:23 -0500 Received: by smtp.corp.redhat.com (Postfix) id 40CB57DE2F; Wed, 5 Jan 2022 16:21:23 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.40.193.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id 93DE07DE3B for ; Wed, 5 Jan 2022 16:21:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641399701; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Y9yYlEz6nEZWzmILDvYEhSSY14AUyNr6RPsc5uGnh14=; b=ToYr0K9jo65lMxPxFzSIZ8dFzvIpKN6uz9Q8CRg3/vSYihXnGfkMmo26aHLsdJEWn/KmR8 Ok163B6msczmTewjNNJOmHfvPrM/ZP7ddz5cj2qiNFkoEOPeVmXE7Qh90GTmpq77K7PXHX OmICX3JdZ0vQdtQp7LtwyrNGvm5yoCo= X-MC-Unique: FdyeCaCxMx6LFD0ziSLarw-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH] util: fix prototype of virDaemonSetupLogging Date: Wed, 5 Jan 2022 17:21:11 +0100 Message-Id: <2a9264b8b25e5cd9e54196ebf06a11f6d8846823.1641399651.git.jtomko@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1641399704686100001 The commit that added error checking to this function forgot to adjust the WIN32 stub. Fixes: a873924e36b28c5b125621e35b32beb6b077bcc8 Signed-off-by: J=C3=A1n Tomko --- Pushed as a build fix. src/util/virdaemon.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/util/virdaemon.c b/src/util/virdaemon.c index 5c0ca534cf..00bd7095f6 100644 --- a/src/util/virdaemon.c +++ b/src/util/virdaemon.c @@ -275,17 +275,17 @@ int virDaemonForkIntoBackground(const char *argv0 G_G= NUC_UNUSED) return -1; } =20 -void virDaemonSetupLogging(const char *daemon_name G_GNUC_UNUSED, - unsigned int log_level G_GNUC_UNUSED, - char *log_filters G_GNUC_UNUSED, - char *log_outputs G_GNUC_UNUSED, - bool privileged G_GNUC_UNUSED, - bool verbose G_GNUC_UNUSED, - bool godaemon G_GNUC_UNUSED) +int virDaemonSetupLogging(const char *daemon_name G_GNUC_UNUSED, + unsigned int log_level G_GNUC_UNUSED, + char *log_filters G_GNUC_UNUSED, + char *log_outputs G_GNUC_UNUSED, + bool privileged G_GNUC_UNUSED, + bool verbose G_GNUC_UNUSED, + bool godaemon G_GNUC_UNUSED) { /* NOOP */ errno =3D ENOTSUP; - return; + return -1; } =20 int virDaemonUnixSocketPaths(const char *sock_prefix G_GNUC_UNUSED, --=20 2.31.1