From nobody Mon Feb 9 07:56:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1770303813; cv=none; d=zohomail.com; s=zohoarc; b=OgG3bcvpT1bp0tM13DiLj7+snQVcO4oPOkY1Uybf2n8h9XYwayZQWLe6FXBTxrVjZPz8agpSqcx+hqB8qRpa30aquZlGNZPeVJIeZCL3urAuHp9OLFHJApZil6WbCXKZ68e1x3lfjPaajP2++XJko3LNbzINmjElrGslza620ko= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770303813; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=riF0Gd/9K3jBuYSnAYbgjWkk7npwL+0LvHbqj8p9toQ=; b=V1sECRUV7RDejvxNNN6SqWoLBuLgxEnpCVuzBIU2iGbUJEHYBBZqxW1NPV2dYw3LZE7Aj8xgMF3XJG61+uOAubWSb+9BzNhp57XQ7LLFGhZjPQ8Xy8Z9qXXLMaydg41vfGfqPi0quLiK1GV8ukWw7AKwPU2hoFbZARpgjm6fI5c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 177030381377932.96107785368679; Thu, 5 Feb 2026 07:03:33 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id EADDC41DE1; Thu, 5 Feb 2026 10:03:32 -0500 (EST) Received: from [172.19.199.6] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 53F3D43F0D; Thu, 5 Feb 2026 09:57:36 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id A1FF7418DF; Thu, 5 Feb 2026 09:57:30 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 19649418DF for ; Thu, 5 Feb 2026 09:55:42 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-NgoP0ZCDPqy-BaOTaa-Jyw-1; Thu, 05 Feb 2026 09:55:37 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6205918004BB for ; Thu, 5 Feb 2026 14:55:36 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.3]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A94CC1800464 for ; Thu, 5 Feb 2026 14:55:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770303341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=riF0Gd/9K3jBuYSnAYbgjWkk7npwL+0LvHbqj8p9toQ=; b=gdWjjdkC9zkQqbSZsmIrEHT2F8areiTlj+U+pQkIXsqmvUCHo9u1NCs+NjBPBlh6Fccg5F ZyJa81erAsGcZKcvnG6JxiyExeAWTXUlERAOFnfbuKDcTEji0Q7NsL8ZJUpUSpDRlFrfB4 5Ubgjt8n+eEPep9GbZtwGcGAcax4HnU= X-MC-Unique: NgoP0ZCDPqy-BaOTaa-Jyw-1 X-Mimecast-MFC-AGG-ID: NgoP0ZCDPqy-BaOTaa-Jyw_1770303336 To: devel@lists.libvirt.org Subject: [PATCH 05/20] qemuMigrationSrcBegin: Drop disk refresh step Date: Thu, 5 Feb 2026 15:55:13 +0100 Message-ID: <298ef706f53538bf83386f71cd4e6b676639e57b.1770303113.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ycrbhFdwVYAfrv752_A4c0XsMUT102iqC4TEOgMrL-I_1770303336 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BKRLWIK6OOKD5MRUJVJZ4TF4PMWI4VGK X-Message-ID-Hash: BKRLWIK6OOKD5MRUJVJZ4TF4PMWI4VGK X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1770303816285154100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Since 'qemuProcessRefreshDiskProps' doesn't remove the source since we switched to blockdev mode, we don't need to update disk state at the beginning of migration. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index b4d2e27370..88db5e93fa 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -3016,7 +3016,6 @@ qemuMigrationSrcBegin(virConnectPtr conn, g_autoptr(virQEMUDriverConfig) cfg =3D virQEMUDriverGetConfig(driver); g_autofree char *xml =3D NULL; char *ret =3D NULL; - virDomainAsyncJob asyncJob; if (cfg->migrateTLSForce && !(flags & VIR_MIGRATE_TUNNELLED) && @@ -3035,14 +3034,12 @@ qemuMigrationSrcBegin(virConnectPtr conn, if ((flags & VIR_MIGRATE_CHANGE_PROTECTION)) { if (qemuMigrationJobStart(vm, VIR_ASYNC_JOB_MIGRATION_OUT, flags) = < 0) goto cleanup; - asyncJob =3D VIR_ASYNC_JOB_MIGRATION_OUT; } else { if (!qemuMigrationJobIsAllowed(vm)) goto cleanup; if (virDomainObjBeginJob(vm, VIR_JOB_MODIFY) < 0) goto cleanup; - asyncJob =3D VIR_ASYNC_JOB_NONE; } qemuMigrationSrcStoreDomainState(vm); @@ -3050,13 +3047,6 @@ qemuMigrationSrcBegin(virConnectPtr conn, if (!(flags & VIR_MIGRATE_OFFLINE) && virDomainObjCheckActive(vm) < 0) goto endjob; - /* Check if there is any ejected media. - * We don't want to require them on the destination. - */ - if (!(flags & VIR_MIGRATE_OFFLINE) && - qemuProcessRefreshDisks(vm, asyncJob) < 0) - goto endjob; - if (!(xml =3D qemuMigrationSrcBeginPhase(driver, vm, xmlin, dname, cookieout, cookieoutlen, migrate_disks, --=20 2.53.0