From nobody Sun Feb 8 14:56:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1652196208; cv=none; d=zohomail.com; s=zohoarc; b=oDJJGcmogBTvcvQPzB/3vzpBt2PE2Ne2h3RWMDS79vVRuEWZFXvq6WG0x40IeO9S+jXjkVpEoOLKmRosit2+UzMidVRvHTIZaalZIhIxcmJOUjygg1+ZdypvldeBuvCpuTfo+vJb2tZI4xMW9hn7LQMqr8q34hvs4W7vtq36a8Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1652196208; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OGZGPE0GKTj2JJLL9qpbFQhy5TZ40/4D2PQo9drJuXo=; b=QJaANd79cHuoU2LaQzdgWwdYUm9MxoGIhDKeWgXLJQsFR2gS4Hb4bP6J9qmlPaDb8XoF8wbqMUSRE6FIBuiogV/qHXq83zgmGNRcOdU82nbFa1yVmU5AdWAiEWovFF5noaRnejGOelNfk8PWAb9AdidyaxI8hL3Kx43o0wVcZ70= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1652196208882676.4759404618047; Tue, 10 May 2022 08:23:28 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-663-Y4eT9aIMPYGvP3bIo15RHg-1; Tue, 10 May 2022 11:23:14 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 502F184B100; Tue, 10 May 2022 15:22:16 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3C9CF40D1B9A; Tue, 10 May 2022 15:22:16 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E9DDE1940358; Tue, 10 May 2022 15:22:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9C48A1947070 for ; Tue, 10 May 2022 15:21:49 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 6923A40D282D; Tue, 10 May 2022 15:21:49 +0000 (UTC) Received: from virval.usersys.redhat.com (unknown [10.43.2.187]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4873F40C1421 for ; Tue, 10 May 2022 15:21:49 +0000 (UTC) Received: by virval.usersys.redhat.com (Postfix, from userid 500) id B67D2244621; Tue, 10 May 2022 17:21:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652196206; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=OGZGPE0GKTj2JJLL9qpbFQhy5TZ40/4D2PQo9drJuXo=; b=eWyEPc2/0mC+p1aO9iAH03KTcieHTxCmzjA7Yq5Ex93PgOeaR2NRQOgS34oQnXs6NbQh8q ppxpSzqwldBCvlYQI0vhUNPhbPa9mDsO4MLL/xgvG54KMoH1WWLZn3wqT4FJt2HOtsIes1 brTRGAcsrSJptZLFDumI7iXzWQSj/2w= X-MC-Unique: Y4eT9aIMPYGvP3bIo15RHg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Jiri Denemark To: libvir-list@redhat.com Subject: [libvirt PATCH 53/80] qemu: Don't set VIR_MIGRATE_PAUSED for post-copy resume Date: Tue, 10 May 2022 17:21:14 +0200 Message-Id: <2989f203a801c6eca0a02c4fc0a796b8ef6d7dc9.1652196064.git.jdenemar@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1652196210854100007 Content-Type: text/plain; charset="utf-8" For historical reasons we automatically enabled VIR_MIGRATE_PAUSED flag when a migration was started for a paused domain. However, when resuming failed post-copy migration the domain on the source host will always be paused (as it is already running on the destination host). We must avoid enabling VIR_MIGRATE_PAUSED in this case. Signed-off-by: Jiri Denemark Reviewed-by: Peter Krempa --- src/libvirt-domain.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 41ba4aa39c..07fb8119d9 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -3279,7 +3279,9 @@ virDomainMigrateVersion3Full(virDomainPtr domain, ret =3D virDomainGetInfo(domain, &info); state =3D info.state; } - if (ret =3D=3D 0 && state =3D=3D VIR_DOMAIN_PAUSED) + if (ret =3D=3D 0 && + state =3D=3D VIR_DOMAIN_PAUSED && + !(flags & VIR_MIGRATE_POSTCOPY_RESUME)) flags |=3D VIR_MIGRATE_PAUSED; =20 destflags =3D flags & ~(VIR_MIGRATE_ABORT_ON_ERROR | --=20 2.35.1