From nobody Sun Feb 8 14:41:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1661443200; cv=none; d=zohomail.com; s=zohoarc; b=cnL+gfj8axy0HaQ3NLWen+JeLYOe64CVd4/C64/bR2TGtHR4GYi33zfjRWG3wx+9bdqFr1VVEjqo8FuA2wt/1cenhHdaZUErOkWSTOnxlexN5996+5wZRg7zOWqxbGqqRvoSc8W93cYz6ZmaMhcRwETadAGHsWdJ0C2wRUISPR0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661443200; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Im97R5XUpslCfCRyFxif88kn+oul/5W5ubrC657bSbo=; b=Qreu9NKxDxv1zRTvqs8EutAgi7PV3Lej/CcIwiuM7W/osilEla/A9DFXSIrsThIBCphk+0uQ7tV3QNlhRoGGupn8nTkO8FEwisjLFqbT+amDieACOrZFR8PhPQe3RO+vb7vn65k1lEhgT3+GhZF+/g8RzaZcqXOhi03yZbWYwIY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1661443200802448.216706672903; Thu, 25 Aug 2022 09:00:00 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-605-f4pHdnevMaGtjAII5t_PMg-1; Thu, 25 Aug 2022 11:59:48 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A0D5081F46A; Thu, 25 Aug 2022 15:59:40 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 88046403348; Thu, 25 Aug 2022 15:59:40 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B3A5B1947049; Thu, 25 Aug 2022 15:59:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 395861946A43 for ; Thu, 25 Aug 2022 15:59:38 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 2D2F340D2830; Thu, 25 Aug 2022 15:59:38 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB33840D282E for ; Thu, 25 Aug 2022 15:59:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661443199; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Im97R5XUpslCfCRyFxif88kn+oul/5W5ubrC657bSbo=; b=FEbf2x+PaJzQt6G2F7RpzUGGIffbuRW2MBGdGeJmK5o2AlsZQyNkVcRPMUExCdnEepT/ue ADuembiubUNp/ivgdK9PTV3uRBDoGrHg6LKC6VI7x2uGmy5JedHz3BHudDImbtorzPPMsj CGKz8Z5AOFeO0FpmUHt6+H5PfalmGiM= X-MC-Unique: f4pHdnevMaGtjAII5t_PMg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 01/12] qemu: assume QEMU_CAPS_CHARDEV_FILE_APPEND Date: Thu, 25 Aug 2022 17:59:24 +0200 Message-Id: <28ff4130a651a76b8666494091dd78dffc6b6717.1661443135.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1661443201593100010 Introduced in QEMU 2.6 Signed-off-by: J=C3=A1n Tomko Reviewed-by: Peter Krempa --- src/qemu/qemu_process.c | 5 +---- src/qemu/qemu_validate.c | 10 +--------- tests/qemuxml2argvtest.c | 4 +--- 3 files changed, 3 insertions(+), 16 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 32f03ff79a..aaf51e019a 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -6571,10 +6571,7 @@ qemuProcessPrepareDomain(virQEMUDriver *driver, =20 /* Whether we should use virtlogd as stdio handler for character * devices source backend. */ - if (cfg->stdioLogD && - virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_CHARDEV_FILE_APPEND)) { - priv->chardevStdioLogd =3D true; - } + priv->chardevStdioLogd =3D cfg->stdioLogD; =20 /* Track if this domain remembers original owner */ priv->rememberOwner =3D cfg->rememberOwner; diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 6403266559..245b953c86 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -2194,15 +2194,6 @@ qemuValidateDomainChrSourceDef(const virDomainChrSou= rceDef *def, return -1; break; =20 - case VIR_DOMAIN_CHR_TYPE_FILE: - if (def->data.file.append !=3D VIR_TRISTATE_SWITCH_ABSENT && - !virQEMUCapsGet(qemuCaps, QEMU_CAPS_CHARDEV_FILE_APPEND)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("append not supported in this QEMU binary")); - return -1; - } - break; - case VIR_DOMAIN_CHR_TYPE_QEMU_VDAGENT: if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_CHARDEV_QEMU_VDAGENT)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, @@ -2226,6 +2217,7 @@ qemuValidateDomainChrSourceDef(const virDomainChrSour= ceDef *def, case VIR_DOMAIN_CHR_TYPE_VC: case VIR_DOMAIN_CHR_TYPE_PTY: case VIR_DOMAIN_CHR_TYPE_DEV: + case VIR_DOMAIN_CHR_TYPE_FILE: case VIR_DOMAIN_CHR_TYPE_PIPE: case VIR_DOMAIN_CHR_TYPE_STDIO: case VIR_DOMAIN_CHR_TYPE_UDP: diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 303292c788..bedd190cb1 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1579,7 +1579,6 @@ mymain(void) QEMU_CAPS_DEVICE_VFIO_PCI); =20 DO_TEST("serial-file-log", - QEMU_CAPS_CHARDEV_FILE_APPEND, QEMU_CAPS_DEVICE_ISA_SERIAL, QEMU_CAPS_CHARDEV_LOGFILE); DO_TEST("serial-spiceport", @@ -1601,8 +1600,7 @@ mymain(void) DO_TEST("serial-dev-chardev-iobase", QEMU_CAPS_DEVICE_ISA_SERIAL); DO_TEST("serial-file-chardev", - QEMU_CAPS_DEVICE_ISA_SERIAL, - QEMU_CAPS_CHARDEV_FILE_APPEND); + QEMU_CAPS_DEVICE_ISA_SERIAL); DO_TEST("serial-unix-chardev", QEMU_CAPS_DEVICE_ISA_SERIAL); DO_TEST_CAPS_LATEST("serial-file-log"); --=20 2.37.1