From nobody Thu Sep 19 01:19:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1716801688782817.2023420243526; Mon, 27 May 2024 02:21:28 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id D419B1A3A; Mon, 27 May 2024 05:21:24 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id AD9801A40; Mon, 27 May 2024 05:19:19 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A7E571918; Mon, 27 May 2024 05:19:07 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 49964191E for ; Mon, 27 May 2024 05:19:07 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-qwVyyF3MOf2MhHjc1di3QQ-1; Mon, 27 May 2024 05:19:04 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B27CD185A78E for ; Mon, 27 May 2024 09:19:04 +0000 (UTC) Received: from maggie.brq.redhat.com (unknown [10.43.3.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5E50A40005C for ; Mon, 27 May 2024 09:19:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716801547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lOVl+RqC5menpPAyGavcOFuedssFLUgRVNb5pS3XP5U=; b=b1z2D/UzzA0V42KUCb1W9TOgEOXQRwPjIcjeihhEWvhVFNCQ6LEp4xj3kpG62aBwrYpXC4 ZsAsTQzeXctpDm996Rn4Z+wEKQPhjTFjZEXElWhv20q2age0uuEqJiW66DsbEAfuYiVV6h xbGOmVyNgZY4jIW7d94iNqDTA+BGog8= X-MC-Unique: qwVyyF3MOf2MhHjc1di3QQ-1 From: Michal Privoznik To: devel@lists.libvirt.org Subject: [PATCH 2/6] virt-admin: Make --timeout of daemon-timeout positional argument Date: Mon, 27 May 2024 11:18:50 +0200 Message-ID: <286620b4cba8cdfb36299824d86f40ee10e689ec.1716801414.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 4HT36TXH2K7TGVFLMC7DKDM3GY6DUMJP X-Message-ID-Hash: 4HT36TXH2K7TGVFLMC7DKDM3GY6DUMJP X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1716801689312100001 Content-Type: text/plain; charset="utf-8"; x-default="true" We currently require full argument specification: virt-admin daemon-timeout --timeout X Well, the '--timeout' feels a bit redundant. Turn the argument into a positional so that the following works too: virt-admin daemon-timeout X Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- docs/manpages/virt-admin.rst | 2 +- tools/virt-admin.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/manpages/virt-admin.rst b/docs/manpages/virt-admin.rst index 5108781636..54a6512ef7 100644 --- a/docs/manpages/virt-admin.rst +++ b/docs/manpages/virt-admin.rst @@ -320,7 +320,7 @@ daemon-timeout =20 :: =20 - daemon-timeout --timeout NUM + daemon-timeout [--timeout] NUM =20 Sets the daemon timeout to the value of '--timeout' argument. Use ``--time= out 0`` to disable auto-shutdown of the daemon. diff --git a/tools/virt-admin.c b/tools/virt-admin.c index 1805618035..3eb4f0f3fd 100644 --- a/tools/virt-admin.c +++ b/tools/virt-admin.c @@ -1009,6 +1009,7 @@ static const vshCmdOptDef opts_daemon_timeout[] =3D { {.name =3D "timeout", .type =3D VSH_OT_INT, .required =3D true, + .positional =3D true, .help =3D N_("number of seconds the daemon will run without any activ= e connection"), }, {.name =3D NULL} --=20 2.44.1