From nobody Sun Feb 8 11:21:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571438273; cv=none; d=zoho.com; s=zohoarc; b=fafY5qAZWFd5IbVcE7wx213Upf0PMHgNbRCRxyioLh5GCQo+hFOzHmiCmRktl92vEHKqwkoQccvUPOe6A1KfHIpbRffCgDibS3F/tCIXyEaz5kOVLsDXpufgSbRSyVdzWt8VWCE6Rnu5Gb7KxJDSxasCI8/1Cw/21l3ZjHa9eBA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571438273; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+sWxrrCxba3qlNGl9M/horhbPJcKB/+4UVVd0PKJqMg=; b=W0Ckas6+88+Vb/CpvBQJzRYlnOVzfk8SzQhrn5qyPr1sUTD870cLEzU3vtW6teRYZMl4jTnC45b7DVMgwe7DbvUpR5nSFG/zxFu5k3hJFoj3KONClYOv1wupZkiYczKvKZpVB6VY4rhCs0azRIIIWxv9ywr/halj/je+46f1n14= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 157143827367020.01818491023664; Fri, 18 Oct 2019 15:37:53 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1A19B81F1B1; Fri, 18 Oct 2019 22:37:52 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E61A719C7F; Fri, 18 Oct 2019 22:37:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A90A6180B536; Fri, 18 Oct 2019 22:37:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x9IMbEtM025294 for ; Fri, 18 Oct 2019 18:37:15 -0400 Received: by smtp.corp.redhat.com (Postfix) id EEF165D71C; Fri, 18 Oct 2019 22:37:14 +0000 (UTC) Received: from lpt.redhat.com (ovpn-200-21.brq.redhat.com [10.40.200.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1CED35D70E for ; Fri, 18 Oct 2019 22:37:13 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Sat, 19 Oct 2019 00:37:49 +0200 Message-Id: <28334f05518c6ea7c1263d365ef3b35f4e1d27bd.1571438247.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 05/10] virsh: getSignalNumber: use g_autofree X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.69]); Fri, 18 Oct 2019 22:37:52 +0000 (UTC) Mark the 'str' variable as g_autofree and avoid the need for a separate cleanup label. Signed-off-by: J=C3=A1n Tomko --- tools/virsh-domain.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index d74a671167..44eb8a5d32 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -8806,27 +8806,21 @@ static int getSignalNumber(vshControl *ctl, const c= har *signame) { size_t i; int signum; - char *str =3D vshStrdup(ctl, signame); + g_autofree char *str =3D vshStrdup(ctl, signame); char *p =3D str; =20 for (i =3D 0; signame[i]; i++) p[i] =3D c_tolower(signame[i]); =20 if (virStrToLong_i(p, NULL, 10, &signum) >=3D 0) - goto cleanup; + return signum; =20 if (STRPREFIX(p, "sig_")) p +=3D 4; else if (STRPREFIX(p, "sig")) p +=3D 3; =20 - if ((signum =3D virDomainProcessSignalTypeFromString(p)) >=3D 0) - goto cleanup; - - signum =3D -1; - cleanup: - VIR_FREE(str); - return signum; + return virDomainProcessSignalTypeFromString(p); } =20 static bool --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list