From nobody Mon Feb 9 12:14:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1560519143; cv=none; d=zoho.com; s=zohoarc; b=RU2H6NwTSHQCT8CBCBh9FIQDwcoTNSOAqVf7bM86y4cS+dY10yvAK1pKv/ht1t6FMcI2Hy0HnruIOuAgxgA10GFGtJ6yjgndvvBBtf8HZ6zzksr/063U/ven7eJt9hT+qc6MNxJwrXUa/yTbNfu/sPEEhE0mia1DM+xdZFPNPyQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560519143; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Ty9spcOuUkbKBzkUHSKFl+ERfVkEHnWvK9WIjrWGE+E=; b=FsNPjZpUoGQugiRcRVPDoCoFqVDjfbvslbUwLy6DJGSZZpNUc9veHl8Zd6rTOFkPtvzycdYH+03T9jmAeiO5Lwnrp1ysObQXHuEmVYmZgCkLlwBdTRuDpMgsZfUOOwexsRKZn1OpBpDmAxOmhjcCJgKfHl/G0LywS8G7bgq/H9w= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1560519143913734.4281478838103; Fri, 14 Jun 2019 06:32:23 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BEC1D2F8BF4; Fri, 14 Jun 2019 13:32:13 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B99B19700; Fri, 14 Jun 2019 13:32:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1CAEC1806B12; Fri, 14 Jun 2019 13:32:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5EDUXfY019762 for ; Fri, 14 Jun 2019 09:30:33 -0400 Received: by smtp.corp.redhat.com (Postfix) id 816962CE56; Fri, 14 Jun 2019 13:30:33 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C1CA1753B for ; Fri, 14 Jun 2019 13:30:32 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Fri, 14 Jun 2019 15:30:25 +0200 Message-Id: <27f45340fc315f8f1a9ee42b9ad584578b1493bd.1560518789.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [RFC PATCH 3/5] qemu: driver: Remove support for native->XML conversion X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 14 Jun 2019 13:32:22 +0000 (UTC) Content-Type: text/plain; charset="utf-8" This code is really neglected and does not at all work reliably. It can't even be used for converting our own commandline back. Since this was mostly useful for aiding migration from manually run qemu to libvirt and will not work for this puspose in many cases it's not worth having in my opinion. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 38 ++++++-------------------------------- 1 file changed, 6 insertions(+), 32 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index bb6ba97c7a..7279b20d2e 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7319,44 +7319,18 @@ static char static char *qemuConnectDomainXMLFromNative(virConnectPtr conn, - const char *format, - const char *config, + const char *format ATTRIBUTE_U= NUSED, + const char *config ATTRIBUTE_U= NUSED, unsigned int flags) { - virQEMUDriverPtr driver =3D conn->privateData; - virDomainDefPtr def =3D NULL; - char *xml =3D NULL; - virCapsPtr caps =3D NULL; - virCheckFlags(0, NULL); if (virConnectDomainXMLFromNativeEnsureACL(conn) < 0) - goto cleanup; - - if (STRNEQ(format, QEMU_CONFIG_FORMAT_ARGV)) { - virReportError(VIR_ERR_INVALID_ARG, - _("unsupported config type %s"), format); - goto cleanup; - } - - if (!(caps =3D virQEMUDriverGetCapabilities(driver, false))) - goto cleanup; - - def =3D qemuParseCommandLineString(driver->qemuCapsCache, - caps, driver->xmlopt, config, - NULL, NULL, NULL); - if (!def) - goto cleanup; - - if (!def->name && VIR_STRDUP(def->name, "unnamed") < 0) - goto cleanup; - - xml =3D qemuDomainDefFormatXML(driver, def, VIR_DOMAIN_XML_INACTIVE); + return NULL; - cleanup: - virDomainDefFree(def); - virObjectUnref(caps); - return xml; + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", + _("qemu driver no longer supports native to XML convers= ion")); + return NULL; } static char *qemuConnectDomainXMLToNative(virConnectPtr conn, --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list