From nobody Sun Feb 8 19:59:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1589369002; cv=none; d=zohomail.com; s=zohoarc; b=nXPLFdUQnctnNuYGjULWmJQYfubRQOl23fRZ8ppPYE5GzbmThDCuadxav3OpaikKVlaCxldmJ9iJeEMfAq0fHZhVvmY69VIY9yW5p+ksMRex4dfI6J2xuo5ZyYQNrxElkOE/Jf5BsUOdBTAFeB4piocaWNdrbv/WmU+TyJo+/SQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589369002; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bELKxzqbbEtPPZgDv1kDpfadD1yNYEmUrs+0wHFJgJk=; b=I1E8RXxRI7etwDdH4lQu2vrMsw8SjUwkO68ls0bxLEESY3bPT3guXN/PeP2lX6ozMAna9wJg6fqKaQr+dlx6eNfDfZXINYz+L1Wy2jY/YR8bDvhRN2tSNpByBfa/TkjuxbOUfLp8oq05O59QMjSskLuCnzQPlP4q6j9GTNz3pcI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1589369002124734.0456133479281; Wed, 13 May 2020 04:23:22 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-478-OZ3FZ6yZNW--Bm2AvkubaQ-1; Wed, 13 May 2020 07:23:18 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E741D18FE879; Wed, 13 May 2020 11:23:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C9D4176E98; Wed, 13 May 2020 11:23:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 96FC71809554; Wed, 13 May 2020 11:23:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 04DBN9i9013178 for ; Wed, 13 May 2020 07:23:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0AB206A960; Wed, 13 May 2020 11:23:09 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.195.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7D1487D945 for ; Wed, 13 May 2020 11:23:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589369000; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=bELKxzqbbEtPPZgDv1kDpfadD1yNYEmUrs+0wHFJgJk=; b=R9Hieu8QRciu+BKVUtJt/ciOKSyHAEnMclPKcR6PA6OVQ607y53+dfP8ih67cSYHXHVkNj P2yVK4xMJ1L2SnDMdfV5/0z+cQRoRV5N52DhYunxb++SDbkiIhk9HRmgm+j+638FhCHL1E 2+tNUzAtk4Zhpp23p16GIEAZdVzac5M= X-MC-Unique: OZ3FZ6yZNW--Bm2AvkubaQ-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 2/5] virNetDevOpenvswitchConstructVlans: Bring @i into the block where it's used Date: Wed, 13 May 2020 13:22:59 +0200 Message-Id: <27761b17fc84ca490eb01903f910b9160b3fd0d1.1589368474.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Michal Privoznik --- src/util/virnetdevopenvswitch.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitc= h.c index 6c4e817941..c9e0c4e956 100644 --- a/src/util/virnetdevopenvswitch.c +++ b/src/util/virnetdevopenvswitch.c @@ -71,7 +71,6 @@ static int virNetDevOpenvswitchConstructVlans(virCommandPtr cmd, const virNetDevVlan = *virtVlan) { int ret =3D -1; - size_t i =3D 0; g_auto(virBuffer) buf =3D VIR_BUFFER_INITIALIZER; =20 if (!virtVlan || !virtVlan->nTags) @@ -92,6 +91,8 @@ virNetDevOpenvswitchConstructVlans(virCommandPtr cmd, con= st virNetDevVlan *virtV } =20 if (virtVlan->trunk) { + size_t i; + virBufferAddLit(&buf, "trunk=3D"); =20 /* @@ -100,7 +101,7 @@ virNetDevOpenvswitchConstructVlans(virCommandPtr cmd, c= onst virNetDevVlan *virtV * start of the for loop if there are more than one VLANs * on this trunk port. */ - virBufferAsprintf(&buf, "%d", virtVlan->tag[i]); + virBufferAsprintf(&buf, "%d", virtVlan->tag[0]); =20 for (i =3D 1; i < virtVlan->nTags; i++) { virBufferAddLit(&buf, ","); --=20 2.26.2