From nobody Mon Feb 9 14:02:46 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1710511050187152.33775362706228; Fri, 15 Mar 2024 06:57:30 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 0D5AD1E86; Fri, 15 Mar 2024 09:57:29 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 285471790; Fri, 15 Mar 2024 09:45:40 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3136917EF; Fri, 15 Mar 2024 09:45:12 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 74B381905 for ; Fri, 15 Mar 2024 09:44:42 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-c76TlS-rPt-GnoILHwsb3g-1; Fri, 15 Mar 2024 09:44:40 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AB29A800269 for ; Fri, 15 Mar 2024 13:44:40 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2587EC1576F for ; Fri, 15 Mar 2024 13:44:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: c76TlS-rPt-GnoILHwsb3g-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 17/28] vsh: Make the only argument of 'connect', 'cd', and 'help' commands positional Date: Fri, 15 Mar 2024 14:44:12 +0100 Message-ID: <2743d861ee18f628111e0431b70dd276490445a0.1710510136.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: WT22TQ66ZLOKK3OPA7VDLJDTKZ55C7X2 X-Message-ID-Hash: WT22TQ66ZLOKK3OPA7VDLJDTKZ55C7X2 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1710511073631100001 The intended use of those commands is to use the argument directly without the flag. Since the argument is optional in all cases we couldn't declare them as positional until now. Signed-off-by: Peter Krempa --- tools/virsh.c | 1 + tools/virt-admin.c | 1 + tools/vsh.c | 2 ++ 3 files changed, 4 insertions(+) diff --git a/tools/virsh.c b/tools/virsh.c index 5b38881066..890c96e552 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -245,6 +245,7 @@ virshReconnect(vshControl *ctl, const char *name, bool = readonly, bool force) static const vshCmdOptDef opts_connect[] =3D { {.name =3D "name", .type =3D VSH_OT_STRING, + .positional =3D true, .flags =3D VSH_OFLAG_EMPTY_OK, .completer =3D virshCompleteEmpty, .help =3D N_("hypervisor connection URI") diff --git a/tools/virt-admin.c b/tools/virt-admin.c index 37bc6fe4f0..3e3361fbf1 100644 --- a/tools/virt-admin.c +++ b/tools/virt-admin.c @@ -254,6 +254,7 @@ cmdVersion(vshControl *ctl, const vshCmd *cmd G_GNUC_UN= USED) static const vshCmdOptDef opts_connect[] =3D { {.name =3D "name", .type =3D VSH_OT_STRING, + .positional =3D true, .flags =3D VSH_OFLAG_EMPTY_OK, .help =3D N_("daemon's admin server connection URI") }, diff --git a/tools/vsh.c b/tools/vsh.c index 80057654c8..2c90ca44f7 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -3163,6 +3163,7 @@ vshCompleteHelpCommand(vshControl *ctl G_GNUC_UNUSED, const vshCmdOptDef opts_help[] =3D { {.name =3D "command", .type =3D VSH_OT_STRING, + .positional =3D true, .completer =3D vshCompleteHelpCommand, .help =3D N_("Prints global help, command specific help, or help for = a group of related commands") }, @@ -3220,6 +3221,7 @@ cmdHelp(vshControl *ctl, const vshCmd *cmd) const vshCmdOptDef opts_cd[] =3D { {.name =3D "dir", .type =3D VSH_OT_STRING, + .positional =3D true, .help =3D N_("directory to switch to (default: home or else root)") }, {.name =3D NULL} --=20 2.44.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org