From nobody Mon Feb 9 14:01:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568793542; cv=none; d=zoho.com; s=zohoarc; b=W4x0H4E6kejsceOj7Cu2zcCccw9HAAy2Szyzd/eaVit45OB85vwi2glSFZnUccRGPU0MUGr1SQ+5Sp+VbGO3gEuIJSsTc0IJkCfbzjnUlWADmlVbMk3+GuB3aU4Gh068Gg8Gx4MmpWNY7rC6SUb3F/ZaPvDYAfCCj34knoxtYWc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568793542; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=fbMdM5/62kKPPTLk/YC3p2Xd73xrmX6lQZHIoio5zNE=; b=Vs+wKjbR/1N7a7tvLqWGhigRco01ybXEJkmDT5dLE/lBLQMqzZ9FAw5mZuDpcAsT1Bo0/xMzcQC7OFhJ/Mp5GOwR/Q+zpL2AMs0iUn8hoXAgZ0Y6Y8XCgdeBL5QjrFdCTr9YUPrJDZ54GplAZOUXTNJCFj/OHqKY+hoi34qfqwI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1568793542060304.2499653890228; Wed, 18 Sep 2019 00:59:02 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ADA964E832; Wed, 18 Sep 2019 07:58:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4C751600C8; Wed, 18 Sep 2019 07:58:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 077CB4E58A; Wed, 18 Sep 2019 07:58:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x8I7wuKU007119 for ; Wed, 18 Sep 2019 03:58:56 -0400 Received: by smtp.corp.redhat.com (Postfix) id 3191B5D6B2; Wed, 18 Sep 2019 07:58:56 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id AE4D85D6A5 for ; Wed, 18 Sep 2019 07:58:55 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Wed, 18 Sep 2019 09:58:50 +0200 Message-Id: <25890d6b3433f21f232668c52824bbf11a94425d.1568793426.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/2] Revert "virt-result.m4: Colourize summary printings" X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 18 Sep 2019 07:59:00 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The colorization based on the string itself makes little to no sense as the semantic meaning of the color (red =3D bad, green =3D good) is not extracted from the semantics of the message: 1) If there is some additional string a 'yes' is marked yellow: configure: driver_modules: yes (CFLAGS=3D'' LIBS=3D'-ldl') 2) In some cases a 'no' is actually good: configure: hal: no 3) Few good/recommended configuration options are still yellow: configure: QEMU: qemu:qemu while using 'root:root' would still be yellow. 4) fields dumping config (e.g. the warning flags line) is a giant blob of colored text which makes little sense configure: Warning Flags: -fno-common -W -Wabsolute-value -Waddress -Waddress-of-packed-member -Waggressive-loop-optimizations -Wall -Wattribute-warning -Wattributes -Wbad-function-cast -Wbool-compare -Wbool-operation -Wbuiltin-declaration-mismatch -Wbuiltin-macro-redefined -Wcannot-profile -Wcast-align -Wcast-align=3Dstrict -Wcast-function-type -Wchar-subscripts -Wclobbered -Wcomment -Wcomments -Wcoverage-mismatch -Wcpp -Wdangling-else -Wdate-time -Wdeprecated-declarations -Wdesignated-init -Wdiscarded-array-qualifiers -Wdiscarded-qualifiers -Wdiv-by-zero -Wdouble-promotion -Wduplicated-cond -Wduplicate-decl-speci ... In addition if the idea is to switch to a more usable build system it does not make sense to clutter the current one with more code. This reverts commit 4b3ab5d2135a0dccd654491ef3a4f5b71575deae. --- m4/virt-result.m4 | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/m4/virt-result.m4 b/m4/virt-result.m4 index 9115be5774..36973ba0b5 100644 --- a/m4/virt-result.m4 +++ b/m4/virt-result.m4 @@ -31,27 +31,12 @@ dnl eg dnl dnl LIBVIRT_RESULT([yajl], [yes], [-I/opt/yajl/include -lyajl]) dnl - -m4_defun_init([_AS_ECHO_LOG_N], -[AS_REQUIRE([_AS_LINENO_PREPARE])], -[_AS_ECHO_N([$as_me:${as_lineno-$LINENO}: $1], AS_MESSAGE_LOG_FD)]) - -m4_defun_init([AS_MESSAGE_N], -[AS_REQUIRE([_AS_ME_PREPARE])], -[m4_ifval(AS_MESSAGE_LOG_FD, - [{ _AS_ECHO_LOG_N([$1]) -_AS_ECHO_N([$as_me: $1], [$2]);}], - [_AS_ECHO_N([$as_me: $1], [$2])])[]]) - AC_DEFUN([LIBVIRT_RESULT], [ - STR=3D`printf "%20s: " "$1"` if test "$2" =3D "no" || test -z "$3" ; then - VAL=3D`printf "%s" "$2"` + STR=3D`printf "%20s: %s" "$1" "$2"` else - VAL=3D`printf "%s (%s)" "$2" "$3"` + STR=3D`printf "%20s: %s (%s)" "$1" "$2" "$3"` fi - AS_MESSAGE_N([$STR]) - _AS_ECHO([$VAL], AS_MESSAGE_LOG_FD) - COLORIZE_RESULT([$VAL]) + AC_MSG_NOTICE([$STR]) ]) --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list