From nobody Mon Feb 9 01:49:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1570485234; cv=none; d=zoho.com; s=zohoarc; b=lWe4I4FWq04ItlWHoxw8fb+fPG79mIysB8hSarJ+b/3fibyYjuYeCcrIWa8/VYmvfAYsvuuETrfjOJqd+RTxc6+16zeTBW5PwqAmXaYH7JbpX554iOCiAsBT3+plvsqmkoNr1m3aR8ztWZJUv+C36wMHOb18fpf5qDXmiR4c7/8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570485234; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=AJD2k1C574v5oHdqviVGnvYiOetDZgIBOROcdC390Do=; b=C7OtOEDE+6okuMATVw+EAbYM2zAHwZT9FEPLhTYHS+G7ECQupwV0IvBVcO2vkdejo0ejOQWX48aKRd8273hxWYPHDXPgJ30Pf9eaR1QNDEhMeh7FZUuyyibdEagTUMVOZfvJ7N0EaJsoUuHcGVVf0PBUEl8EpuKccAqjJeLF5OY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1570485234492342.12371150388776; Mon, 7 Oct 2019 14:53:54 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 14739C054C52; Mon, 7 Oct 2019 21:53:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E3BD55C22F; Mon, 7 Oct 2019 21:53:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A8461180BA99; Mon, 7 Oct 2019 21:53:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x97Loi9R015106 for ; Mon, 7 Oct 2019 17:50:44 -0400 Received: by smtp.corp.redhat.com (Postfix) id 176075C231; Mon, 7 Oct 2019 21:50:44 +0000 (UTC) Received: from worklaptop.redhat.com (ovpn-123-156.rdu2.redhat.com [10.10.123.156]) by smtp.corp.redhat.com (Postfix) with ESMTP id D500F5C290; Mon, 7 Oct 2019 21:50:38 +0000 (UTC) From: Cole Robinson To: libvir-list@redhat.com Date: Mon, 7 Oct 2019 17:49:35 -0400 Message-Id: <253129220c00b19e0ae28d9d0e84aea7c7645834.1570482718.git.crobinso@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 21/30] security: dac: Add is_toplevel to SetImageLabelInternal X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 07 Oct 2019 21:53:53 +0000 (UTC) Content-Type: text/plain; charset="utf-8" This will simplify future patches and make the logic easier to follow Signed-off-by: Cole Robinson Reviewed-by: Daniel Henrique Barboza --- src/security/security_dac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index bcc781213e..6d0c8a9b1c 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -882,6 +882,7 @@ virSecurityDACSetImageLabelInternal(virSecurityManagerP= tr mgr, virSecurityDeviceLabelDefPtr parent_seclabel =3D NULL; virSecurityDACDataPtr priv =3D virSecurityManagerGetPrivateData(mgr); bool remember; + bool is_toplevel =3D parent =3D=3D src; uid_t user; gid_t group; =20 @@ -926,7 +927,7 @@ virSecurityDACSetImageLabelInternal(virSecurityManagerP= tr mgr, * but the top layer, or read only image, or disk explicitly * marked as shared. */ - remember =3D src =3D=3D parent && !src->readonly && !src->shared; + remember =3D is_toplevel && !src->readonly && !src->shared; =20 return virSecurityDACSetOwnership(mgr, src, NULL, user, group, remembe= r); } --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list