From nobody Fri Apr 26 07:59:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.39 as permitted sender) client-ip=209.132.183.39; envelope-from=libvir-list-bounces@redhat.com; helo=mx6-phx2.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.39 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx6-phx2.redhat.com (mx6-phx2.redhat.com [209.132.183.39]) by mx.zohomail.com with SMTPS id 1487256980712769.0379111540417; Thu, 16 Feb 2017 06:56:20 -0800 (PST) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx6-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1GEqjI6031845; Thu, 16 Feb 2017 09:52:46 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v1GEqiJf009776 for ; Thu, 16 Feb 2017 09:52:44 -0500 Received: from mx1.redhat.com (ext-mx07.extmail.prod.ext.phx2.redhat.com [10.5.110.31]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1GEqiuG024043 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 16 Feb 2017 09:52:44 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [119.145.14.65]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7A7BBC04B321; Thu, 16 Feb 2017 14:52:39 +0000 (UTC) Received: from 172.24.1.137 (EHLO szxeml425-hub.china.huawei.com) ([172.24.1.137]) by szxrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DUO27106; Thu, 16 Feb 2017 22:52:32 +0800 (CST) Received: from HGHY1w002515742.local (10.177.25.93) by szxeml425-hub.china.huawei.com (10.82.67.180) with Microsoft SMTP Server id 14.3.235.1; Thu, 16 Feb 2017 22:52:25 +0800 Date: Thu, 16 Feb 2017 22:50:42 +0800 From: Jie Wang To: Message-ID: <2444270f-86b8-4960-919d-ba99f9f0b89e@HGHY1w002515742.local> MIME-Version: 1.0 X-Originating-IP: [10.177.25.93] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090202.58A5BCB0.00CF, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: d98bcd6ba7d5883ef6b5407296353079 X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 200 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 16 Feb 2017 14:52:42 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 16 Feb 2017 14:52:42 +0000 (UTC) for IP:'119.145.14.65' DOMAIN:'szxga02-in.huawei.com' HELO:'szxga02-in.huawei.com' FROM:'wangjie88@huawei.com' RCPT:'' X-RedHat-Spam-Score: -1.902 (BAYES_50, DCC_REPUT_00_12, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, SPF_PASS) 119.145.14.65 szxga02-in.huawei.com 119.145.14.65 szxga02-in.huawei.com X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Scanned-By: MIMEDefang 2.78 on 10.5.110.31 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id v1GEqiJf009776 X-loop: libvir-list@redhat.com Cc: mkletzan@redhat.com, wu.wubin@huawei.com, eric.fangyi@huawei.com Subject: [libvirt] [PATCH] libvirt-override: fix flags mutually exclusize X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Because of virDomainGetBlkioParameters is called in libvirt_virDomainSetBlk= ioParameters, it will result in the two flags 'VIR_DOMAIN_AFFECT_LIVE' and 'VIR_DOMAIN_AF= FECT_CONFIG' are mutually exclusive in libvirt_virDomainSetBlkioParameters, it's unreaso= nable, So ues this patch to fix it. Signed-off-by: Jie Wang --- libvirt-override.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index 9e40f00..7bdc09c 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -727,7 +727,7 @@ libvirt_virDomainSetBlkioParameters(PyObject *self ATTR= IBUTE_UNUSED, } =20 LIBVIRT_BEGIN_ALLOW_THREADS; - i_retval =3D virDomainGetBlkioParameters(domain, NULL, &nparams, flags= ); + i_retval =3D virDomainGetBlkioParameters(domain, NULL, &nparams, 0); LIBVIRT_END_ALLOW_THREADS; =20 if (i_retval < 0) @@ -743,7 +743,7 @@ libvirt_virDomainSetBlkioParameters(PyObject *self ATTR= IBUTE_UNUSED, return PyErr_NoMemory(); =20 LIBVIRT_BEGIN_ALLOW_THREADS; - i_retval =3D virDomainGetBlkioParameters(domain, params, &nparams, fla= gs); + i_retval =3D virDomainGetBlkioParameters(domain, params, &nparams, 0); LIBVIRT_END_ALLOW_THREADS; =20 if (i_retval < 0) { --=20 1.9.5.msysgit.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list