From nobody Sun May 19 15:20:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1690963908; cv=none; d=zohomail.com; s=zohoarc; b=W8WCu34xdJLvClhyTwF+OGW3S+O2AZd4bgOfliUcLCQ7jXLcBBBJVshYqXukNkQAWUTyT6c84q5j0vVXHT111sLqFfEYZbqGYV0MfaBD4rkG6PWZASVt0IA9z5F5sYdGa6x3V+G8AHf4iqq+/qVy2M7pEwYKImvbnLEpMh8CM0M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690963908; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=RiUd7g9m4tb1iZTJzsVH5pEMpDv/5nLLPck1WecjL1E=; b=oKmKXDHXAFJxnkGIS7AsrNRBnzMcoPSd73IKq3PGvkiTT+RldUS5xwoJ8iNI9DnFylLPIiE2A0VXeiE2w+nbVQXFTfm/Sj4p5qwwjBAH6vLYFIJWP/U4pStuc6umoMvHAvL7NdYhPuvktZ/T5vrQf64jY+dhGcAXP1Z8T5zf2ME= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 169096390865493.61126054214185; Wed, 2 Aug 2023 01:11:48 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-62-Tz1G-qBXOS-JVilRVEf7yw-1; Wed, 02 Aug 2023 04:11:44 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5A63586802C; Wed, 2 Aug 2023 08:11:42 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6E269C57964; Wed, 2 Aug 2023 08:11:41 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 0A72C1946A45; Wed, 2 Aug 2023 08:11:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 58F8B1946A43 for ; Wed, 2 Aug 2023 08:11:26 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 3876C112132D; Wed, 2 Aug 2023 08:11:26 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E5A51121325 for ; Wed, 2 Aug 2023 08:11:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690963907; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=RiUd7g9m4tb1iZTJzsVH5pEMpDv/5nLLPck1WecjL1E=; b=bLgwLd6sNbBjzrKcXBK69XRc7idQVGX8KEUHhgcffiDuV9kiCkQ1BEghSF75VI0GxZcij+ 9G3cwZxmwYqJhR4mfK6u1C7A3Se8uAQeQ0HwIcyDjZrf3S8p/wM+RFs00p1T+hAaARLfjE PadB878R/PmaVif/jREWkhKMNTFGQ6M= X-MC-Unique: Tz1G-qBXOS-JVilRVEf7yw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH] daemon: Treat logging of VIR_ERR_MULTIPLE_INTERFACES same as VIR_ERR_NO_INTERFACE Date: Wed, 2 Aug 2023 10:11:24 +0200 Message-ID: <242c2ab077d5901ccad1e1cf540d64d20f2cdeaa.1690963884.git.pkrempa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1690963910686100001 Content-Type: text/plain; charset="utf-8" When a query for an interface via virInterfaceLookupByMACString finds multiple interfaces an error is returned. Treat such error with the same 'debug' priority as we treat when the interface was not found to avoid spamming logs with such configurations. Closes: https://gitlab.com/libvirt/libvirt/-/issues/514 Signed-off-by: Peter Krempa Reviewed-by: Martin Kletzander --- src/remote/remote_daemon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/remote/remote_daemon.c b/src/remote/remote_daemon.c index d880711c91..d4d999e53a 100644 --- a/src/remote/remote_daemon.c +++ b/src/remote/remote_daemon.c @@ -97,6 +97,7 @@ static int daemonErrorLogFilter(virErrorPtr err, int prio= rity) case VIR_ERR_NO_STORAGE_VOL: case VIR_ERR_NO_NODE_DEVICE: case VIR_ERR_NO_INTERFACE: + case VIR_ERR_MULTIPLE_INTERFACES: case VIR_ERR_NO_NWFILTER: case VIR_ERR_NO_NWFILTER_BINDING: case VIR_ERR_NO_SECRET: --=20 2.41.0