From nobody Mon Mar 23 23:29:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1773069115; cv=none; d=zohomail.com; s=zohoarc; b=nV7zTHPvRJFizuezoQNN31S5FEkaOgwB7AJvxONRf7NJsxFQ7HqQ2Gz+0QzesRhHQLk1p+UtfwGcLiJDdM2E0TAW8pPlyzSqb/MpbHZTZ4WXCpjBKAjT8mE34tF5tVyvIhmQWrVf5B4q3wZ7LOr6meOI9n0f+8JKYvmOyaagIFU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773069115; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=8kW7uGW/RphN/eSDXmc7LAgVNK/A7Nu5HjcTjh0r/RI=; b=h0PhP61RY4qQIWjtbQBfx1u8d24yvLn903q3Qav4Ydrh0cOc4OW0fjiDs6xdIIRQ1MT7NjJ/zkO4sjwbcf5+r6Qefs7ax1npu755h21YNsqWYKYFFDU4qJFcOEoTERk1T/T8cu6hzuuIx7VM5SEA+kP5KrjHjw+Tqqq9xzExH4E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1773069115729212.5029888344136; Mon, 9 Mar 2026 08:11:55 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id B75D7419ED; Mon, 9 Mar 2026 11:11:54 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id E481741974; Mon, 9 Mar 2026 11:11:21 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 7852141886; Mon, 9 Mar 2026 11:11:17 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 98C7D3F935 for ; Mon, 9 Mar 2026 11:11:16 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-637-ZvI67t68NkSto4r5cNf0pQ-1; Mon, 09 Mar 2026 11:11:14 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0FC48195608D for ; Mon, 9 Mar 2026 15:11:14 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5095C30001BB for ; Mon, 9 Mar 2026 15:11:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773069076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8kW7uGW/RphN/eSDXmc7LAgVNK/A7Nu5HjcTjh0r/RI=; b=RQkwr8MscNvDhYXo/6vyQahAfdK+NmR5gLasGlp9E2B0nK3OMilQ1r1UpwL/d3GuvXu1hD 2K/ATaLj2SPk6/MUO+2R6RqwXKLlWjSqVkQO0Ly2gS0pGMEio6m8GFz21O4utbtW+a2lTp dGYoE7tNfmYqNsuSN4jlg9HNDNrSBnU= X-MC-Unique: ZvI67t68NkSto4r5cNf0pQ-1 X-Mimecast-MFC-AGG-ID: ZvI67t68NkSto4r5cNf0pQ_1773069074 To: devel@lists.libvirt.org Subject: [PATCH] qemuhotplugtest: Run "interface-hostdev" test cases only on Linux Date: Mon, 9 Mar 2026 16:11:10 +0100 Message-ID: <23fbf1d358c6b2d421c1d13b783922af021d4855.1773069049.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hEI6ZX_085b-Ex0nVGPJGooPJf28oYLpzTse6B0p8HI_1773069074 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: K3QIBOIRB4RU2K4CSQXBJJNRVOV3IUV7 X-Message-ID-Hash: K3QIBOIRB4RU2K4CSQXBJJNRVOV3IUV7 X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1773069118768154100 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik In one of my previous commits, I've introduced "interface-hostdev" attach and detach test cases to qemuhotplugtest. And they work flawlessly, on Linux. But on anything else they fail because our virpci.c module is basically just a bunch of stub functions that do nothing but report an error, rendering my changes to virpcimock futile. BTW: this is similar to what I had done in v12.1.0-rc1~199. Fixes: f9bb819fc4841dbdff801629bf58f9fd6d7d93eb Signed-off-by: Michal Privoznik Reviewed-by: Pavel Hrdina --- Verified in my FreeBSD VM. tests/qemuhotplugtest.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index 6cb616c59b..146e9e33c1 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -697,10 +697,18 @@ mymain(void) DO_TEST_DETACH("ppc64", "pseries-base-live", "hostdev-pci", false, fal= se, "device_del", QMP_DEVICE_DELETED("hostdev0") QMP_OK); =20 +#ifdef __linux__ + /* While is nearly the same as , + * there are subtle differences, e.g. checking that PCI device specifi= ed in + * is a VF. Checks like these are done by walking sysfs w= hich + * is limited to Linux, obviously. And while our virpcimock creates + * necessary structure, on non-Linux the virpci.c is compiled with stu= bs + * that do nothing but report an error. */ DO_TEST_ATTACH("x86_64", "base-live", "interface-hostdev", false, true, "device_add", QMP_OK); DO_TEST_DETACH("x86_64", "base-live", "interface-hostdev", false, fals= e, "device_del", QMP_DEVICE_DELETED("hostdev0") QMP_OK); +#endif DO_TEST_ATTACH("x86_64", "base-live", "interface-vdpa", false, true, "query-fdsets", "{\"return\":[{\"fdset-id\":99999}]}", "add-fd", "{ \"return\": { \"fdset-id\": 1, \"fd\": 95 = }}", --=20 2.52.0