From nobody Mon Feb 9 07:51:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747750402; cv=none; d=zohomail.com; s=zohoarc; b=gNVAIQaxbfSks8QqeHxIOK3v11TkwBDJ3VflcFMpcZeF+kMVOXN30I2oAEI1grDyuozTG3CgKWab0bZJ9GqqMHWQZuqJWyY9M7GQkBi7kXO0IEcGbnGUSas9EtH8vC0aQ4PK/fnwUcS+2D9aTXNqZGTxn/OnI1rdGx54xpUj920= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747750402; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=Lqwv/KxVW9j2Zggx+GDSdo6B+Nd5jo+ONaxK+VYgvwY=; b=kcc7j0vt4Ufu/5M9/T+FojX53/SKKr3YfUG1jXag4tSsBmcLDO9QimNxrFVqR8I2PhTUDsvKOeohlKwTYd0ng8serqQUL9c5h5jGLnyGrzPnH9kipiuc0KDk0i2sLQHKvmNWTV7+CMrYqok147Q1vTvIjx4YudzhklCXReHb5Oo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 17477504024641.154412708172572; Tue, 20 May 2025 07:13:22 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 7A3251882; Tue, 20 May 2025 10:13:21 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 073691840; Tue, 20 May 2025 10:10:30 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A745B1881; Tue, 20 May 2025 10:10:24 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B8A9A187B for ; Tue, 20 May 2025 10:10:14 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-296-_4PhC601NeeNYwT3ua-Olg-1; Tue, 20 May 2025 10:10:12 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3263D183E07B for ; Tue, 20 May 2025 14:09:00 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.37]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6673319560AD for ; Tue, 20 May 2025 14:08:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747750214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OFfh0NQKLLeWWsguy2xGeL8MkhxR7qwcx2NbeRv4LXY=; b=htoFO8XjVMYbNGDtzGfHIn1Y2dTkSMm67nj93tlPdyWf4rDt2jnmb93Gv6TcDOdyXor0nb v39IqqHNW+oKw7rGiUBhrDRgndrckm+akEHYoneGXVeiZP9ufr/NhdmfDoQUd0Te2Piwmh OBOh3wQenGa7ZD/H0M1feF4l24DLPoI= X-MC-Unique: _4PhC601NeeNYwT3ua-Olg-1 X-Mimecast-MFC-AGG-ID: _4PhC601NeeNYwT3ua-Olg_1747750211 To: devel@lists.libvirt.org Subject: [PATCH 3/4] virsh: Apply empty completer to arguments where completion doesn't make sense Date: Tue, 20 May 2025 16:08:52 +0200 Message-ID: <23af62f001412d0cc2b2276a6959258fbd6ad839.1747750075.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YyqX4ja6KggMrB_sluRrP5x39GGJ3PA2fUyxedpXFlc_1747750211 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: U4TTE4DHYYD6TXP4P2B4TIZ6SPDWTUEN X-Message-ID-Hash: U4TTE4DHYYD6TXP4P2B4TIZ6SPDWTUEN X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747750403516116600 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Few outstanding arguments were not marked with 'virshCompleteEmpty' completer despite the fact that we can't provide any reasonable suggestion, e.g. for the new description of a domain or for the launch secret. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 6 ++++++ tools/virsh-network.c | 1 + 2 files changed, 7 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 7e5e83126e..f9acedf3db 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -8696,6 +8696,7 @@ static const vshCmdOptDef opts_desc[] =3D { {.name =3D "new-desc", .type =3D VSH_OT_ARGV, .positional =3D true, + .completer =3D vshCompleteEmpty, .help =3D N_("message") }, {.name =3D NULL} @@ -9936,10 +9937,12 @@ static const vshCmdOptDef opts_domsetlaunchsecstate= [] =3D { VIRSH_COMMON_OPT_DOMAIN_FULL(0), {.name =3D "secrethdr", .type =3D VSH_OT_STRING, + .completer =3D vshCompleteEmpty, .help =3D N_("path to file containing the secret header"), }, {.name =3D "secret", .type =3D VSH_OT_STRING, + .completer =3D vshCompleteEmpty, .help =3D N_("path to file containing the secret"), }, {.name =3D "set-address", @@ -10119,6 +10122,7 @@ static const vshCmdOptDef opts_qemu_monitor_command= [] =3D { .type =3D VSH_OT_ARGV, .positional =3D true, .required =3D true, + .completer =3D vshCompleteEmpty, .help =3D N_("command") }, {.name =3D NULL} @@ -10503,6 +10507,7 @@ static const vshCmdOptDef opts_qemu_agent_command[]= =3D { .type =3D VSH_OT_ARGV, .positional =3D true, .required =3D true, + .completer =3D vshCompleteEmpty, .help =3D N_("command") }, {.name =3D NULL} @@ -10590,6 +10595,7 @@ static const vshCmdOptDef opts_lxc_enter_namespace[= ] =3D { .type =3D VSH_OT_ARGV, .positional =3D true, .required =3D true, + .completer =3D vshCompleteEmpty, .help =3D N_("command to run") }, {.name =3D NULL} diff --git a/tools/virsh-network.c b/tools/virsh-network.c index 3fd22db2b0..2e9613e01b 100644 --- a/tools/virsh-network.c +++ b/tools/virsh-network.c @@ -325,6 +325,7 @@ static const vshCmdOptDef opts_network_desc[] =3D { {.name =3D "new-desc", .type =3D VSH_OT_ARGV, .positional =3D true, + .completer =3D vshCompleteEmpty, .help =3D N_("message") }, {.name =3D NULL} --=20 2.49.0