From nobody Sat May 2 11:28:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1742481903; cv=none; d=zohomail.com; s=zohoarc; b=U0IB/MyWh23UkUiFMtJOIAEP8ypYqXFBQcJ1XrZVMNHNTQxAEwBVhF9hRDOqE3MSKlsGpQV7X/9mzSBFr4AS0+S8UKvUUNxTQhjC3xLH5VrFO/E4Shen5B+Uh4OvYE+Go/XIgUVqyHPPbqqYid/47R8Z1BBmIarRXyrtf07+tEE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742481903; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id; bh=MFrCUXuqBeKtC1CSa5a2b//IvM6cmC9d5eynzBFH37w=; b=gCsUjoXjNBmZn9ZlETlqzfHC8m7ZMwDTzzbW2Zrj4egwuG3ZsX+9LFz42s3ItwjyiQHvMADxLjXTybIwkuryQ2Gh/jLiB87ETCprG6pJDY2WQI8prBvb2qCZ8O+5/4mLuHgE/Lgwa6TqWHue/2HhRERorc+AzV67TeVLW1xwuhQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1742481903879808.0427717973735; Thu, 20 Mar 2025 07:45:03 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 2B39A15AC; Thu, 20 Mar 2025 10:45:03 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 28E9D15BC; Thu, 20 Mar 2025 10:44:43 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 16B9415A8; Thu, 20 Mar 2025 10:44:37 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 6DFF314DA for ; Thu, 20 Mar 2025 10:44:36 -0400 (EDT) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-57-i0jg_fibOOqGGKGx3Cb92g-1; Thu, 20 Mar 2025 10:44:34 -0400 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-39126c3469fso380643f8f.3 for ; Thu, 20 Mar 2025 07:44:34 -0700 (PDT) Received: from wheatley.localdomain ([85.93.96.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c888117csm23644872f8f.44.2025.03.20.07.44.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Mar 2025 07:44:32 -0700 (PDT) Received: from wheatley.pinto-pinecone.ts.net (wheatley.k8r.cz [127.0.0.1]) by wheatley.localdomain (Postfix) with ESMTP id 4E82596E6B92; Thu, 20 Mar 2025 15:44:32 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742481876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yG4Ji4cA8oieQhZsT1WD351m9ArSyVEm965ase6o81Y=; b=XSb2w0FenEpWCXlTy24QABKWwN3L23mfbPKs+L5r9RKYcmkOzXk2gAZk2u/2g5PMkKRalE Caf//w3BM/kJxZpO8vFT8JFB0DwHhlaEAkJ9BabFxvOoO0w7fKc+ikZKTG+DrpqSlOYpS3 o8Bn1Ei1kbejXySNatlpQ/zhSDml/Y8= X-MC-Unique: i0jg_fibOOqGGKGx3Cb92g-1 X-Mimecast-MFC-AGG-ID: i0jg_fibOOqGGKGx3Cb92g_1742481873 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742481873; x=1743086673; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yG4Ji4cA8oieQhZsT1WD351m9ArSyVEm965ase6o81Y=; b=Rd+ziSuxVbsdAX0cheYa0gT8pnnVo04dzfEzYagGwdbZETxmj1/5KukMHjhgtoQiFH KokHWvWBcnf/SBkfI5PXIk5oDa461HNdUG+9/cXXf6jKvvDRoPsix2iChq2z9A6OsphZ g0Q6pMJh7ki4wrlKNo2LyEAlPNneZHCJWbU+V9o1tDngTzkHR/p1KEMn5W6HgIQDBLfz 6kfqnLs/EJpTcYC+A3TGEtHcrHUpWGuZO7At2dGRNkdY/9SxvIycN3DU56RfrvuHwQyY KTBvu53Ryv0jyX03vksbKIu/iXX0xSw/oBqARF5oLn0QIoKI61hnAJX6vX0UvRt6abAN 6UUg== X-Gm-Message-State: AOJu0Yy5O529EWQ7wGK06FcgbMZEL/9zM9dx//cFnbjjleEUT/vqZ/Pz E5Cia92dHsO7zRn1xTQV2VPnhZRs9FoZpegKZxbGLuqdAzARF2nZMjmjGNMIYgFvseKtzG6yvGS F2WiFsCm3V0E6QuUMYaN/PT/0Y5pjiR0MihM2tyC6Oma/NWVxLgolW2Hh2JZ9GZLf4+7/lBKee4 tGlLQWkrybud0WzHxnR/+Ug3KL2GLSUlpTmMwPOFs= X-Gm-Gg: ASbGncsBuoVuVi1+NlDWAnWpXxutn0rnpd6CDeFJ42GniTb9YAtx7JYpLA9OeIv7yDo 8iNnkblpR98jpRkYGfUUE7tkZMtpSDHFgcj5niycWJXrSuTJxUHwpzu7ZwVhBMEHPnvwU0fsgKl yGf5mPdAu95oMRI/FzAEWD/hZku+eRjeYxCkhHaFcnskbRuQjjWh9qxHYK9szQcCvrFBKde2QL+ vl87pu9k7HzUIO3Mz8V1BA4eeJeVmzqsKmYXgYgYkDbWQgJjU/D9XDp/3BrjJyTpY6jOGikD1/Z l73mBsOjs3s0cjn+olqZjiYI X-Received: by 2002:a5d:6d06:0:b0:391:3b70:2db4 with SMTP id ffacd0b85a97d-399739bfaf7mr7662075f8f.18.1742481873492; Thu, 20 Mar 2025 07:44:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnpZQmsXLFCQFVKdvOivC7xe8k4ij5TweR4bX9CLBxDq8DcYJkb/99+x3CW5f3c5d+bWqdGg== X-Received: by 2002:a5d:6d06:0:b0:391:3b70:2db4 with SMTP id ffacd0b85a97d-399739bfaf7mr7662050f8f.18.1742481873040; Thu, 20 Mar 2025 07:44:33 -0700 (PDT) To: devel@lists.libvirt.org Subject: [PATCH] qemu/dbus: Allow connections from root to the dbus-daemon Date: Thu, 20 Mar 2025 15:44:31 +0100 Message-ID: <22539359cc8cbadba2920b60d16811eb68caf1ca.1742481871.git.mkletzan@redhat.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: E3D0tHjmjIyCEQyeH6aYwOIvKjCOdjzCsghx3xrQcE8_1742481873 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: S4ITU2ZCPWZOTPWAEAGKUBEKPYJO5SBG X-Message-ID-Hash: S4ITU2ZCPWZOTPWAEAGKUBEKPYJO5SBG X-MailFrom: mkletzan@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Martin Kletzander via Devel Reply-To: Martin Kletzander X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1742481905636019000 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Martin Kletzander In commit dbfb96d18c04 libvirt started connecting to the daemon to set RDP credentials, but our configuration file did not allow connections from the root user, so the connection failed and the VM failed to start. In order to avoid such issue allow root to connect if the daemon is running privileged. Signed-off-by: Martin Kletzander Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_dbus.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_dbus.c b/src/qemu/qemu_dbus.c index a9e2fb0fe231..625884ad467f 100644 --- a/src/qemu/qemu_dbus.c +++ b/src/qemu/qemu_dbus.c @@ -116,7 +116,7 @@ qemuDBusConnect(virQEMUDriver *driver, =20 =20 static int -qemuDBusWriteConfig(const char *filename, const char *path) +qemuDBusWriteConfig(const char *filename, const char *path, bool privilege= d) { g_auto(virBuffer) buf =3D VIR_BUFFER_INITIALIZER; g_autofree char *config =3D NULL; @@ -138,6 +138,9 @@ qemuDBusWriteConfig(const char *filename, const char *p= ath) virBufferAddLit(&buf, "\n"); virBufferAddLit(&buf, "\n"); virBufferAddLit(&buf, "\n"); + if (privileged) + virBufferAddLit(&buf, "\n"); + virBufferAdjustIndent(&buf, -2); virBufferAddLit(&buf, "\n"); =20 @@ -242,7 +245,7 @@ qemuDBusStart(virQEMUDriver *driver, configfile =3D qemuDBusCreateConfPath(cfg, shortName); sockpath =3D qemuDBusCreateSocketPath(cfg, shortName); =20 - if (qemuDBusWriteConfig(configfile, sockpath) < 0) { + if (qemuDBusWriteConfig(configfile, sockpath, driver->privileged) < 0)= { virReportSystemError(errno, _("Failed to write '%1$s'"), configfil= e); return -1; } --=20 2.48.1