From nobody Sun Feb 8 18:09:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1698234065; cv=none; d=zohomail.com; s=zohoarc; b=O+j6SpcxB4VUUlVqH99Yw59AYUbUDNuUeFVc/F2P9nBC1dwAJxiM/ZzJqjqWS2a5wf0TB8qTIkQ0AsnwbwiQqQEpJP1NsJh0Tmlq47Q7S8VIjLeTWbxwvChDHdRs8rc2NdMcqNI8OPPvgt+EqPRs9EY+b8pArLpuKoPliogWHE8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1698234065; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=f/GNBRq5IrIVrROkQ9KGlGnGM/M6z3ftKPKag5GsK8o=; b=TJktw7qClOBSlRkpzDiPvT6A7Xpx2ynN94S/hqvTEX16CW5HG5mxSlC69XFFJ7WsCRlzPMS4OHPts+jgcLzefK3sXDLOh4v5v/Pr+wKf6e5gJ3K7/1HHvxu+On1Iqj68yttK4vYL7nnYKGyHEySBp5uxfjMjIU+9y613KynEEyg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1698234065415915.998016114041; Wed, 25 Oct 2023 04:41:05 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-494-EpeXvK1SOT2kHVbOWw3XaQ-1; Wed, 25 Oct 2023 07:40:12 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A85CC80D185; Wed, 25 Oct 2023 11:40:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8E713492BD9; Wed, 25 Oct 2023 11:40:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 74CF019465A0; Wed, 25 Oct 2023 11:40:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BF819194658C for ; Wed, 25 Oct 2023 11:39:59 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 9A43E492BFC; Wed, 25 Oct 2023 11:39:59 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2398E492BFA for ; Wed, 25 Oct 2023 11:39:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698234064; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=f/GNBRq5IrIVrROkQ9KGlGnGM/M6z3ftKPKag5GsK8o=; b=LoaMTa5VQtK8EKX1/tSzKZ2c1ev+Pm93TJQM9LpUN+8yzOk329+fNLA/iWRmHo4rShVC0n Vgmvon2IsZA8HIrFstfC3ZgssNQgIgBlRbd4dBgYMydAb5nfVzSLHZezJ/eXxvjVp9jqGc 2sGmA0wL3dy5Rztxe2cz3oBIIW3XdRk= X-MC-Unique: EpeXvK1SOT2kHVbOWw3XaQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 19/22] qemuBuildHostdevSCSIAttachPrepare: Use "effective node" mode for getting blockdev props Date: Wed, 25 Oct 2023 13:39:29 +0200 Message-ID: <21b147e321fccd2ae5c705d00c9ecf6628dee9d8.1698233503.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1698234067545100001 Content-Type: text/plain; charset="utf-8" The resulting properties are identical, as the hostdev backend code doesn't set any of the extra properties. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 98e7fa3d80..2674dd6959 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -5066,8 +5066,7 @@ qemuBuildHostdevSCSIAttachPrepare(virDomainHostdevDef= *hostdev, ret->storageNodeName =3D qemuBlockStorageSourceGetStorageNodename(src); *backendAlias =3D qemuBlockStorageSourceGetStorageNodename(src); - if (!(ret->storageProps =3D qemuBlockStorageSourceGetBackendProps(src, - QEMU_B= LOCK_STORAGE_SOURCE_BACKEND_PROPS_SKIP_UNMAP))) + if (!(ret->storageProps =3D qemuBlockStorageSourceGetBackendProps(src,= QEMU_BLOCK_STORAGE_SOURCE_BACKEND_PROPS_EFFECTIVE_NODE))) return NULL; if (qemuBuildStorageSourceAttachPrepareCommon(src, ret) < 0) --=20 2.41.0