From nobody Sat May 30 15:29:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1779972610; cv=none; d=zohomail.com; s=zohoarc; b=BXJoKfg+6c9VoyDyHjcF5QScQgzFxFEB8hGR4t9tKBwoM3s+lrXERqWOGDDHY/sEsGSkLlutmHv2kcfhKsGEyca8br+PyKP6pCQmLNzfwkXxnQ5gbXa2xMQTYEkyPJUeWxq42+VbvgABdh6gngsGqB3QzT+eSv8p16eyme0Rcus= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779972610; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=fzVosZsPJwMc0E5e3LU0wtUax/9wxvQA55FEXQDUkEk=; b=RI0ai+VafXjjYq2LUjD6S9C38RHleqhaP3UsCkwgcRl6ixvnVKnIsAdla1veRO/DSXvK3QpfExnpHIos3FXmMKlI5wVbdAKdUFl7BDUBqGWZnoiMpnLb3MaPqNnZ3YrFdVHKGVQh4+s0TPgSmHzneYuZNtuIaTDv2OKbRik+DJE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1779972609993891.5020050098819; Thu, 28 May 2026 05:50:09 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id B654F41B26; Thu, 28 May 2026 08:50:08 -0400 (EDT) Received: from [172.19.199.5] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id E0C7C41D89; Thu, 28 May 2026 08:49:14 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id E3F4E3F338; Thu, 28 May 2026 08:49:05 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id E7F3A41A01 for ; Thu, 28 May 2026 08:49:04 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-453-4ONvd15YPR-EHMVBOXAhgw-1; Thu, 28 May 2026 08:49:03 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 35906195609E for ; Thu, 28 May 2026 12:49:02 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 957C71800465 for ; Thu, 28 May 2026 12:49:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779972544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fzVosZsPJwMc0E5e3LU0wtUax/9wxvQA55FEXQDUkEk=; b=MGWZMn/wysu0OGtk1auL2EF5G0KJkiTj/LWIoeoa/deT29d1bpkdfbKz81DINPJ6m3/mdO YmU1wY36UpWVeDJbSFmJ0pW9llgyMIWmgzp/AgGbGEeT/ScbhoCY2UIVFkzPCZx7elI/rm FrpZMDlWlgZXZZDkOCu3ydpUrQ+MOnY= X-MC-Unique: 4ONvd15YPR-EHMVBOXAhgw-1 X-Mimecast-MFC-AGG-ID: 4ONvd15YPR-EHMVBOXAhgw_1779972542 To: devel@lists.libvirt.org Subject: [PATCH] qemu_nbdkit: Fix format when printing time_t values Date: Thu, 28 May 2026 14:48:58 +0200 Message-ID: <21ac9926dea3592fbf021edc069633ba289d3db4.1779972283.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: n0bV943-1CyHg4N0gcnuJxdHir9goydgy8TicuK-Cig_1779972542 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 6XSM7775ZN4PHV636AEDC4IT6SNWTOIS X-Message-ID-Hash: 6XSM7775ZN4PHV636AEDC4IT6SNWTOIS X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1779972613939158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik The time_t type can be 32bit or 64bit signed integer. There are systems where it's defined as long, or long long (32bit systems usually). Therefore, using just 'l' length modifier is not good enough. Also, using 'u' conversion specifier is also wrong (though, values stored in qemuNbdkitCaps struct reflect mtime of some files, so there won't be a negative value). Anyway, do what we already do for virQEMUCaps - use '%lld' printf format and typecast to long long. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- Spotted this on the following pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-/jobs/14580340190 in which I was testing moving our CI from Debian 12 to 13. Apparently, in Debian they decided to -D_TIME_BITS=3D64 for everything [1] and only when compiling on a 32bit arch it's when time_t expands to 'long long'. 1: https://wiki.debian.org/ReleaseGoals/64bit-time src/qemu/qemu_nbdkit.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_nbdkit.c b/src/qemu/qemu_nbdkit.c index 542a6b1f44..6918fc6631 100644 --- a/src/qemu/qemu_nbdkit.c +++ b/src/qemu/qemu_nbdkit.c @@ -544,18 +544,18 @@ qemuNbdkitCapsFormatCache(qemuNbdkitCaps *nbdkitCaps) =20 virBufferEscapeString(&buf, "%s\n", nbdkitCaps->path); - virBufferAsprintf(&buf, "%lu\n", - nbdkitCaps->ctime); + virBufferAsprintf(&buf, "%lld\n", + (long long)nbdkitCaps->ctime); virBufferEscapeString(&buf, "%s\n", nbdkitCaps->pluginDir); - virBufferAsprintf(&buf, "%lu\n", - nbdkitCaps->pluginDirMtime); + virBufferAsprintf(&buf, "%lld\n", + (long long)nbdkitCaps->pluginDirMtime); virBufferEscapeString(&buf, "%s\n", nbdkitCaps->filterDir); - virBufferAsprintf(&buf, "%lu\n", - nbdkitCaps->filterDirMtime); - virBufferAsprintf(&buf, "%lu\n", - nbdkitCaps->libvirtCtime); + virBufferAsprintf(&buf, "%lld\n", + (long long)nbdkitCaps->filterDirMtime); + virBufferAsprintf(&buf, "%lld\n", + (long long)nbdkitCaps->libvirtCtime); virBufferAsprintf(&buf, "%u\n", nbdkitCaps->libvirtVersion); =20 @@ -593,10 +593,10 @@ virNbdkitCapsSaveFile(void *data, return -1; } =20 - VIR_DEBUG("Saved caps '%s' for '%s' with (%lu, %lu)", + VIR_DEBUG("Saved caps '%s' for '%s' with (%lld, %lld)", filename, nbdkitCaps->path, - nbdkitCaps->ctime, - nbdkitCaps->libvirtCtime); + (long long)nbdkitCaps->ctime, + (long long)nbdkitCaps->libvirtCtime); =20 return 0; } --=20 2.53.0