From nobody Sun Dec 14 08:00:37 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1751634477; cv=none; d=zohomail.com; s=zohoarc; b=BBmniB7syVXCrhnocve10V7tc8LFz8GVnrc0r8R3MPiFnrzIpXG+vxjkQsf4xsYUXQIDuY+FUUwf6QGMKpEaFmV6v2SN3scgf8Bf3fECunI1fmdyiyg5lZU54zfeHKAzfkERiV7EOKb0qDEtgs+hXsnGK2klgYOzCTw90TKxej8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751634477; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=GgjqH4sTojne1HDa7l4bypUpFdIN5eGE3Gl8DirnbkY=; b=D3PAdMANmEE/9WCf4EkGg0BDLlGp31jjatSlT/2V3uIRwxL+N1pbdeGPldlc1xfvPHNyQCvggGiUKwJ7RbRONJKMoPj6DswVprSQKYiJeedBz1pH0WpkPL7/2dFXFfkUFQ2c4VfD6mWy68wGLEPT1zPNy1t/6I4i4qSaPir8MTQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1751634477084399.63527196735515; Fri, 4 Jul 2025 06:07:57 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 26E2D1566; Fri, 4 Jul 2025 09:07:56 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id B68A7125B; Fri, 4 Jul 2025 09:06:23 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3600BA4D; Fri, 4 Jul 2025 09:06:12 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 6D674E7A for ; Fri, 4 Jul 2025 09:06:11 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-132-NklU7RaxNd6fl4tSFBKlWQ-1; Fri, 04 Jul 2025 09:06:10 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5C0AD1800343 for ; Fri, 4 Jul 2025 13:06:09 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.3.236]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AA375180045B for ; Fri, 4 Jul 2025 13:06:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751634371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ar9rQvyWNwVN3d5em6bEnjc00d01PLqgdMViYQ9yKBE=; b=K149gAB2+o801Jv7LOywhgU9wmx5xQ/E04T8fJui5U7TUTGn1kk0LlITssfoqLxlEKuT9z KExraPQUI9mbXLusb1hGkKRZ/rgPlPy9qeCYnfmIPrw/Er/SLy4VKwfBOxq/2VwfObu4FV uS0dKLTSgUxk5Xaz8Fs3Db/T4tAUCGQ= X-MC-Unique: NklU7RaxNd6fl4tSFBKlWQ-1 X-Mimecast-MFC-AGG-ID: NklU7RaxNd6fl4tSFBKlWQ_1751634369 To: devel@lists.libvirt.org Subject: [PATCH 3/6] nss: Make logging conditional on an envvar Date: Fri, 4 Jul 2025 15:05:32 +0200 Message-ID: <21725811cdb882cc880e1838f3b81ad5f8d842aa.1751634227.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6Bpj_uNoCxf4Dws7tWbCm112gPpk-OANol_HMq1evO0_1751634369 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CPVLHXORRY6RX6SGHRYFUG7KPWUSZVC5 X-Message-ID-Hash: CPVLHXORRY6RX6SGHRYFUG7KPWUSZVC5 X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1751634477936116600 Content-Type: text/plain; charset="utf-8" From: Michal Privoznik As promised in previous commit, make NSS modules silent by default and enable debug printings if LIBVIRT_NSS_DEBUG envvar is set. Signed-off-by: Michal Privoznik --- docs/nss.rst | 13 +++++++++++++ tools/nss/libvirt_nss_log.c | 4 ++++ tools/nss/libvirt_nss_log.h | 2 ++ 3 files changed, 19 insertions(+) diff --git a/docs/nss.rst b/docs/nss.rst index be137d987b..3df85cee0a 100644 --- a/docs/nss.rst +++ b/docs/nss.rst @@ -111,6 +111,19 @@ their IP addresses in any other way (usermode networki= ng, assigned network devices and so on) will not be able to have their hostnames resolved throu= gh it. =20 +Debugging +--------- + +:since:`Since 11.5.0` both NSS modules check for ``LIBVIRT_NSS_DEBUG`` +environment variable=C2=B8 which if set to any value turns on printing of = debug and +error messages onto standard error output. This can be useful when debuggi= ng +either of the module. + +:: + + $ LIBVIRT_NSS_DEBUG=3D1 getent hosts mydomain + + Alternatives ------------ =20 diff --git a/tools/nss/libvirt_nss_log.c b/tools/nss/libvirt_nss_log.c index 0863897c07..9a28a91800 100644 --- a/tools/nss/libvirt_nss_log.c +++ b/tools/nss/libvirt_nss_log.c @@ -24,6 +24,7 @@ #include #include #include +#include =20 #include "libvirt_nss_log.h" #include "libvirt_nss.h" @@ -54,6 +55,9 @@ nssLog(nssLogPriority prio, g_autofree char *ebuf =3D NULL; va_list ap; =20 + if (!getenv(NSS_LOG_ENV_VAR)) + return; + fprintf(stderr, "%s %s:%d : ", nssLogPriorityToString(prio), func, lin= enr); =20 va_start(ap, fmt); diff --git a/tools/nss/libvirt_nss_log.h b/tools/nss/libvirt_nss_log.h index bac64d4bc7..25926fb6de 100644 --- a/tools/nss/libvirt_nss_log.h +++ b/tools/nss/libvirt_nss_log.h @@ -31,6 +31,8 @@ typedef enum { #define ERROR(...) \ nssLog(NSS_ERROR, __FUNCTION__, __LINE__, __VA_ARGS__) =20 +#define NSS_LOG_ENV_VAR "LIBVIRT_NSS_DEBUG" + void nssLog(nssLogPriority prio, const char *func, --=20 2.49.0