From nobody Thu Dec 5 01:50:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1732311433576989.9111685462487; Fri, 22 Nov 2024 13:37:13 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id E93481B7A; Fri, 22 Nov 2024 16:37:12 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id DFB9C169F; Fri, 22 Nov 2024 16:34:03 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id C08ED1679; Fri, 22 Nov 2024 16:33:57 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C8C6C164B for ; Fri, 22 Nov 2024 16:33:32 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-394-Tgt-jkjLNbKriA0ALoc0ZQ-1; Fri, 22 Nov 2024 16:33:30 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 013BE19560A6 for ; Fri, 22 Nov 2024 21:33:30 +0000 (UTC) Received: from orkuz (unknown [10.45.224.26]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 789C21955F57 for ; Fri, 22 Nov 2024 21:33:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732311212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X5ckyzjdEB50yJeSe6z/H/FHSQIGY1FoJveajRG3yks=; b=FioMdySOLqH5NHVNn189i8bHiD22g+Z0XR72zWiFjuMRjbSgnvRplpzdZUYPG7stDEocGG df25zvetnKv+9z7Iw1WWdczRYKT+2ajuM+h5hxPJXgEAgafSwWwzRpdkUdtVnSdh/ZMcoZ j+LawKuxgfn7BFo5jL17vVXDLgd+szM= X-MC-Unique: Tgt-jkjLNbKriA0ALoc0ZQ-1 X-Mimecast-MFC-AGG-ID: Tgt-jkjLNbKriA0ALoc0ZQ From: Jiri Denemark To: devel@lists.libvirt.org Subject: [PATCH v2 05/36] sync_qemu_models_i386: Do not overwrite existing models Date: Fri, 22 Nov 2024 22:32:45 +0100 Message-ID: <2112701800d27d9efce5bbe109973c19f45ad4f1.1732311125.git.jdenemar@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qfWu6IHSzCOJKwQ2hxijQrsvfbqwEhPY3fork1BADiQ_1732311210 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 7THPW4UOIW7YKIEONLVSUJBEFVUFWZNT X-Message-ID-Hash: 7THPW4UOIW7YKIEONLVSUJBEFVUFWZNT X-MailFrom: jdenemar@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1732311436165116600 Content-Type: text/plain; charset="utf-8" We don't change definitions of CPU models which were already included in a libvirt release to maintain migration compatibility. Thus the script can just skip existing models and save us from having to drop the changes it would do to them. Signed-off-by: Jiri Denemark Reviewed-by: Daniel P. Berrang=C3=A9 --- Notes: Version 2: - no change src/cpu_map/sync_qemu_models_i386.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/cpu_map/sync_qemu_models_i386.py b/src/cpu_map/sync_qemu_m= odels_i386.py index 78c2bffab2..f7b06a7716 100755 --- a/src/cpu_map/sync_qemu_models_i386.py +++ b/src/cpu_map/sync_qemu_models_i386.py @@ -535,6 +535,10 @@ def main(): =20 for model in models: name =3D os.path.join(args.outdir, f"x86_{model['name']}.xml") + if os.path.isfile(name): + # Ignore existing models as CPU models in libvirt should never + # change once released. + continue with open(name, "wt") as f: output_model(f, model) =20 --=20 2.47.0