From nobody Sun Feb 8 13:32:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.151.124 as permitted sender) client-ip=170.10.151.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.151.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1639421979; cv=none; d=zohomail.com; s=zohoarc; b=HCYi8pYxL5AKqhg091eBI8pSsW5BWsL7QUNWu3ZGnjy8/nK5uTOlnZmVt2xR8D64ZVtmGEDdl0uf16xAFsLXDtYa8r7+W6HatdZBPDYwYCVbPsbtSgxfyRHct25Vc3CIkYlS7Rmu9rXnH59kcvJRKOg53PjgReqHo0vjy8BuldU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639421979; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OWiL4PmEWAnmm1dpSksjFnUCOvPYqkre+FxnZZonYig=; b=ZCx92ndOYMjELQoYIIHkNfpe25sQuOGHyVld1nevZFJagMi4qaAyRvyKoFOrCHuUy0x2/jzR4tBRtF93n5j8BWzB9REnoRSmKcBFkZGM/BVQ2OOGTP6GyybxzfOgO45NqXDtz40ic+xGYMWpRrPhmIaewPEG8ljzawdcY4QI6E8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.151.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.151.124]) by mx.zohomail.com with SMTPS id 1639421979336206.3935733654871; Mon, 13 Dec 2021 10:59:39 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-2-SQnL3B1oO7qghWoHhKv1Lg-1; Mon, 13 Dec 2021 13:59:33 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B739A802928; Mon, 13 Dec 2021 18:59:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9C48445D8A; Mon, 13 Dec 2021 18:59:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 70B9A4A706; Mon, 13 Dec 2021 18:59:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1BDIxGnJ006852 for ; Mon, 13 Dec 2021 13:59:16 -0500 Received: by smtp.corp.redhat.com (Postfix) id 2C1735DF3A; Mon, 13 Dec 2021 18:59:16 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id A82B3ADCB for ; Mon, 13 Dec 2021 18:59:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639421977; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=OWiL4PmEWAnmm1dpSksjFnUCOvPYqkre+FxnZZonYig=; b=UMB83qOqC/MZeCbPuKbdXlR9ptJQtAr8A5zQk/bLhKA6JZPUuq6Kg/EwEBoVt7SYQjFjSX NRdwHq4g9dmj2jkoBE0VoqZqUMxWrzXBlsif0G6eSHqPEy/FilVi2ot2ASMa72AAKQicHU X56OK+PHKZNG24kXWx93NGCbg9gAqmM= X-MC-Unique: SQnL3B1oO7qghWoHhKv1Lg-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 4/5] util: refactor virNodeSuspendSetNodeWakeup Date: Mon, 13 Dec 2021 19:58:49 +0100 Message-Id: <210f84c5aae6fc88741c445ba58cee4ecdc83f0d.1639421880.git.jtomko@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1639421980293100004 Signed-off-by: J=C3=A1n Tomko --- src/util/virnodesuspend.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/util/virnodesuspend.c b/src/util/virnodesuspend.c index 451d798363..c92232dfe9 100644 --- a/src/util/virnodesuspend.c +++ b/src/util/virnodesuspend.c @@ -73,8 +73,7 @@ static void virNodeSuspendUnlock(void) */ static int virNodeSuspendSetNodeWakeup(unsigned long long alarmTime) { - virCommand *setAlarmCmd; - int ret =3D -1; + g_autoptr(virCommand) setAlarmCmd =3D NULL; =20 if (alarmTime < MIN_TIME_REQ_FOR_SUSPEND) { virReportError(VIR_ERR_INVALID_ARG, @@ -86,14 +85,7 @@ static int virNodeSuspendSetNodeWakeup(unsigned long lon= g alarmTime) setAlarmCmd =3D virCommandNewArgList("rtcwake", "-m", "no", "-s", NULL= ); virCommandAddArgFormat(setAlarmCmd, "%lld", alarmTime); =20 - if (virCommandRun(setAlarmCmd, NULL) < 0) - goto cleanup; - - ret =3D 0; - - cleanup: - virCommandFree(setAlarmCmd); - return ret; + return virCommandRun(setAlarmCmd, NULL); } =20 /** --=20 2.31.1