From nobody Thu Nov 12 15:08:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1794334551; cv=none; d=zohomail.com; s=zohoarc; b=EpPjH+dKxG8qEwFrrtn0QT0J/k4ipF9h1xqyB+4L8iSgDPitv/yMb2ugOliuncv0bhmWZjedP43yko7/+utfqEhywlKS/MsMSnb9u54RbI7c+Y1tBlO++t8kuQ0FcV/zxDqGArnEUcF/0+MgocvGeA/AaxgFtA3C9Vf53P+2xN0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1794334551; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=xwJ2f3bi5iGiBNUDjH9plX2jq2DAn+J7USPhoWMG514=; b=AbIRSK+w8jKw5SlwlEm8WyvXjJmpFZzSqUy197b+vXZVMY+P1SCo7ZbvVgLEValWozCXI41QQhSzBNfM/jCIFpJk1/WfAKv+JjHTqcrxQyhT9sDNY6qPI+RTR/Spp40WqMmvYZ8zlHz456YoQI9mp2oSjxTn3robQn18E+Y7HLY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1794334551414255.8485064168591; Tue, 10 Nov 2026 10:15:51 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id A8E8341B3F; Tue, 10 Nov 2026 13:15:49 -0500 (EST) Received: from [172.19.199.22] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id D3E694190E; Tue, 10 Nov 2026 13:15:01 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 704FA41906; Tue, 10 Nov 2026 13:14:54 -0500 (EST) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9E2DB3F290 for ; Tue, 10 Nov 2026 13:14:53 -0500 (EST) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-c40e30c26a4so354689766b.0 for ; Tue, 10 Nov 2026 10:14:53 -0800 (PST) Received: from tulp.my.domain (2001-1c02-1a15-3000-25f6-628e-6064-de9b.cable.dynamic.v6.ziggo.nl. [2001:1c02:1a15:3000:25f6:628e:6064:de9b]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6b75791d210sm1413784a12.37.2026.11.10.10.14.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 10:14:51 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794334492; x=1794939292; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=xwJ2f3bi5iGiBNUDjH9plX2jq2DAn+J7USPhoWMG514=; b=lqeVBLUqFc8+GETS1z2eRObxFWj1LTYkM2Me0XEyCykbjPhvqQqypGrBonB2DBHA2L luIsytIPZnFlrPw5CGdJuMx7HBBtRbQRYv40N0FPJeOwWrhnR9yH0kSKfu4CnPX+hztq M10UX9Ch0lbhyVtmBs77/Ew2C75LHZYp7+g8BuKo3ZcG3qd3BjP09Qf35HP1W1lSjPWC YuNAWt3M4wDl3ns50TV1BJeZKlw+VjmK7BYt0hyyWCd912+CgZ0NHrYuO46Pb49Obm4M /eEJ8oougTisIEPBjb0nUqtAz1/+bwkaw2KrahuHszRvmuPloek5QqcS80ArXBPRyzpJ Ygvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794334492; x=1794939292; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xwJ2f3bi5iGiBNUDjH9plX2jq2DAn+J7USPhoWMG514=; b=rTOZeRcyAODJjO/K6nTuoFsFDoui/3iOnRDn1Xmwlysf07T+zqao7nivJmoGfZgFDM wewwhKLbch4s6xFn7g7YFTM7nQ4ZjFfdr4WbuqsSVH2fbTIhy1PSgIFNmzrTbgWdSewo tOPCh3yPjaUJd3J02J+CT989TwkIT1rmNTOA+4wKyTSc3oAq4/CY/q2Wco70eaXBtoJS 8hom31kZ0bDfg74/oGrCJE7cWfuhZgCeji0TVAd+4KeguIkGnRnj+Zuy2NAVfp856PiP HXf6cqj4CAIlnDbtpee6JOfDLoEgcvZWJZAgtoz5LAue6hl2eFHFk+Qcxl78bpTyQU/G xSbA== X-Gm-Message-State: APuU4Z8TlUmAXOd2gkNEbiyUWrTyKujmRocWlYPA2h09EZgt/9c4qHJv CzUBlsWeg1Xk2DuqrSDbDOBxBLgnRZQ5g9xBCn2csysX5KCv6U/lvJ4fkuTnD0hu X-Gm-Gg: AYBFou1OuYuBbMv/ijm/ciWoDzMhwurbWcsfO9NP6nKPKK+d2PQIrQjL2q7N8466/wb VfwRPO3r2oC9H3/ef8pRMrAekekucFIeU3NXq4e46QTS5uSFM+rPWsgXrDq9weMnzkVYBNo55X3 eoDEuCiH3SdiWFUtuzK9kcyLeZWqpqTqn7iFQzJT57DdJ9X8AhBiYWrGRkK3hkkH1mUh34G8x6V +F1El2Se0AZrjMWJCYqujCLisIncXZcPBMiajNwMmgRF7HNs3Jhm3x4auDbDEeqgH2IAAKUwdom UKpGNvR120iyNhDB+YCfWDlVOChQVmjMqVXEuHdCtZGHVN/LxtWAS1v4lwX2jJNX9OcexxH62iJ hbYwE/f19ua8Y7TM0OxyA/F3YCANOGslPMOLRrYFOjLqS5wbiMtAOtn8Dxdwx1wVnGstlNRGUJ9 p3IYKJgrInZn9YHKUJOCcPaVaPGtoE28nUW7PIEcAMg/bJJ9S2TbPr/RvVfxMVlqeDmJLFDj1Ln W/pSIFBdPymWlhPTjPOT1ShugnFKbALDWYOgD5sz8sarcXBcNVgDtOjRhOzRn4WuuIGxJEwVNVc E6OQJfpfZxx1d+tjn4DXctoMgqRk6N/PKRDgxcoAv/tBOXuuN+aR098JLQE5YN7yO/Pl/jDWsuB TYVkZKFfMKqXemJnaGUE1AVeRgDAxpLyYGYDQ4vCnymfj1KIwktvU3VlEsrMA X-Received: by 2002:a17:907:60cd:b0:c46:9745:ac13 with SMTP id a640c23a62f3a-c506361b70emr29522266b.32.1794334491802; Tue, 10 Nov 2026 10:14:51 -0800 (PST) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH] bhyve: handle unexpected signal exits Date: Tue, 10 Nov 2026 19:13:58 +0100 Message-ID: <20261110181358.79506-1-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.56.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: WEIF7X2KJWK6KWMIQAUJ7CGHGLXDBRQP X-Message-ID-Hash: WEIF7X2KJWK6KWMIQAUJ7CGHGLXDBRQP X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1794334553450158500 Content-Type: text/plain; charset="utf-8" The bhyve monitor currently handles signal exits only when they produce a core dump or are caused by SIGTERM. Since SIGKILL never produces a core dump, a bhyve process killed with SIGKILL remains reported as running. Treat every signal exit except SIGTERM as a crash so that the domain is stopped and its resources are cleaned up properly. Signed-off-by: Roman Bogorodskiy Reviewed-by: Daniel P. Berrang=C3=A9 --- src/bhyve/bhyve_monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_monitor.c b/src/bhyve/bhyve_monitor.c index 8e481b17aa..8740c856a8 100644 --- a/src/bhyve/bhyve_monitor.c +++ b/src/bhyve/bhyve_monitor.c @@ -161,7 +161,7 @@ bhyveMonitorIO(int watch, int kq, int events G_GNUC_UNU= SED, void *opaque) shutdownBySignal =3D WIFSIGNALED(status) && WTERMSIG(status) =3D=3D SIGTERM; =20 - if (WIFSIGNALED(status) && WCOREDUMP(status)) { + if (WIFSIGNALED(status) && !shutdownBySignal) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Guest %1$s got signal %2$d and crashed"), name, WTERMSIG(status)); --=20 2.56.0