From nobody Sat Oct 24 20:18:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1792165173; cv=none; d=zohomail.com; s=zohoarc; b=Xy04mzHI21q9b9Ors3sM+CHKhBOifHNr5OXomzmjLry4zhxfT0g/3EYFdhjcHb5AgAqRKl7opJA3iZM1wOG3j8hD8aVBtvUJvG2gtVvSo1Xx5H+S93ttxFAqOeCDHe9e/sjALjWWm/XghhbQWlq0CcNcWsr+IBIpc+QnGFk/LDE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792165173; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=vYUTEv1R/54IfOqTwr7WcqHE2jGxXqd5E6fRdu63VY8=; b=Lg9sUzFYpleIik1sPVGpKdIFfFSiKYyjDBvpdFbJAQp9cAOMev+N/bZB2NVZFfwrTttUDDoefiS4oQJU+DTeZvUV/JxwqsPEoHKng7cTOW1Z1wUWVs2iiWV5LSp4VHp8344FHxWQ3PAPwc8ukqCzgv8rSzLJ41JgiRQ/EfbPDTk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1792165173164875.383996197875; Fri, 16 Oct 2026 08:39:33 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id C230341D01; Fri, 16 Oct 2026 11:39:31 -0400 (EDT) Received: from [172.19.199.16] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 2CB1C41A71; Fri, 16 Oct 2026 11:36:51 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 3B20841960; Fri, 16 Oct 2026 11:36:36 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 31D6A41960 for ; Fri, 16 Oct 2026 11:36:35 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-10-MNuhCdMOPR6zZxDeE0lrCA-1; Fri, 16 Oct 2026 15:36:33 +0000 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2B2D418007EA for ; Fri, 16 Oct 2026 15:36:32 +0000 (UTC) Received: from berrange.csb (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 39D08195607F; Fri, 16 Oct 2026 15:36:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792164994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vYUTEv1R/54IfOqTwr7WcqHE2jGxXqd5E6fRdu63VY8=; b=ZKluZOyFdBU2mpVZz17sQaBe1JrjdmTi3GCKivuqrgQFuJOt1EIqxOqsSio9jZd/aeXRaE vmzQ4RhR+gJdzI1DyqzlkTfspeMmXw82gApKAi52ElP0KBbTJL7TGHa5VNEKH2euu5xA8s t1ZWq861++7MLKbpVe7H4dxfg1ZOBPc= X-MC-Unique: MNuhCdMOPR6zZxDeE0lrCA-1 X-Mimecast-MFC-AGG-ID: MNuhCdMOPR6zZxDeE0lrCA_1792164992 To: devel@lists.libvirt.org Subject: [PATCH 1/7] meson: group driver_XXX options Date: Fri, 16 Oct 2026 16:36:21 +0100 Message-ID: <20261016153627.2837207-2-berrange@redhat.com> In-Reply-To: <20261016153627.2837207-1-berrange@redhat.com> References: <20261016153627.2837207-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cc4Wobv44KXLk-mwUBXgC6Aqvq9sx9jo7NXdERYpiKY_1792164992 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: TJTUWHL2CXSEQLHYXDG5YFXE5GXOS24A X-Message-ID-Hash: TJTUWHL2CXSEQLHYXDG5YFXE5GXOS24A X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1792165175935158500 From: Daniel P. Berrang=C3=A9 Organize the driver_XXX options into three sets * Common options * Hypervisor drivers * Secondary drivers Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Michal Privoznik --- meson_options.txt | 30 +++++++++++++++++------------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/meson_options.txt b/meson_options.txt index 8592880b7b..1ec3c865fc 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -56,25 +56,25 @@ option('wireshark_plugindir', type: 'string', value: ''= , description: 'wireshark option('libvirtd', type: 'feature', value: 'auto', description: 'monolithi= c libvirt daemon') =20 # build driver options +# dep:driver_remote +option('driver_libvirtd', type: 'feature', value: 'auto', description: 'li= bvirtd driver') +option('driver_remote', type: 'feature', value: 'auto', description: 'remo= te driver') +option('remote_default_mode', type: 'combo', choices: ['legacy', 'direct']= , value: 'direct', description: 'remote driver default mode') + + option('driver_bhyve', type: 'feature', value: 'auto', description: 'bhyve= driver') +# dep:curl dep:json_c dep:driver_remote dep:driver_libvirtd +option('driver_ch', type: 'feature', value: 'auto', description: 'Cloud-Hy= pervisor driver') +option('ch_user', type: 'string', value: '', description: 'username to run= Cloud-Hypervisor system instance as') +option('ch_group', type: 'string', value: '', description: 'groupname to r= un Cloud-Hypervisor system instance as') # dep:curl option('driver_esx', type: 'feature', value: 'auto', description: 'esx dri= ver') # dep:openwsman option('driver_hyperv', type: 'feature', value: 'auto', description: 'Hype= r-V driver') -# dep:pciaccess dep:udev dep:driver_remote dep:driver_libvirtd -option('driver_interface', type: 'feature', value: 'auto', description: 'h= ost interface driver') -# dep:driver_remote -option('driver_libvirtd', type: 'feature', value: 'auto', description: 'li= bvirtd driver') # dep:driver_remote dep:driver_libvirtd option('driver_libxl', type: 'feature', value: 'auto', description: 'libxe= nlight driver') # dep:driver_remote dep:driver_libvirtd option('driver_lxc', type: 'feature', value: 'auto', description: 'Linux C= ontainer driver') -# dep:curl dep:json_c dep:driver_remote dep:driver_libvirtd -option('driver_ch', type: 'feature', value: 'auto', description: 'Cloud-Hy= pervisor driver') -option('ch_user', type: 'string', value: '', description: 'username to run= Cloud-Hypervisor system instance as') -option('ch_group', type: 'string', value: '', description: 'groupname to r= un Cloud-Hypervisor system instance as') -# dep:driver_remote dep:driver_libvirtd -option('driver_network', type: 'feature', value: 'auto', description: 'vir= tual network driver') option('driver_openvz', type: 'feature', value: 'auto', description: 'Open= VZ driver') # dep:json_c dep:driver_remote dep:driver_libvirtd option('driver_qemu', type: 'feature', value: 'auto', description: 'QEMU/K= VM driver') @@ -82,15 +82,19 @@ option('qemu_user', type: 'string', value: '', descript= ion: 'username to run QEM option('qemu_group', type: 'string', value: '', description: 'groupname to= run QEMU system instance as') option('qemu_moddir', type: 'string', value: '', description: 'set the dir= ectory where QEMU modules are located') option('qemu_datadir', type: 'string', value: '', description: 'set the di= rectory where QEMU shared data is located') -option('driver_remote', type: 'feature', value: 'auto', description: 'remo= te driver') -option('remote_default_mode', type: 'combo', choices: ['legacy', 'direct']= , value: 'direct', description: 'remote driver default mode') -option('driver_secrets', type: 'feature', value: 'auto', description: 'loc= al secrets management driver') option('driver_test', type: 'feature', value: 'auto', description: 'test d= river') option('driver_vbox', type: 'feature', value: 'auto', description: 'Virtua= lBox XPCOMC driver') option('vbox_xpcomc_dir', type: 'string', value: '', description: 'Locatio= n of directory containing VirtualBox XPCOMC library') option('driver_vmware', type: 'feature', value: 'auto', description: 'VMwa= re driver') option('driver_vz', type: 'feature', value: 'auto', description: 'Virtuozz= o driver') =20 +# dep:pciaccess dep:udev dep:driver_remote dep:driver_libvirtd +option('driver_interface', type: 'feature', value: 'auto', description: 'h= ost interface driver') +# dep:driver_remote dep:driver_libvirtd +option('driver_network', type: 'feature', value: 'auto', description: 'vir= tual network driver') +option('driver_secrets', type: 'feature', value: 'auto', description: 'loc= al secrets management driver') + + option('secdriver_apparmor', type: 'feature', value: 'auto', description: = 'use AppArmor security driver') # dep:secdriver_apparmor option('apparmor_profiles', type: 'feature', value: 'auto', description: '= install apparmor profiles') --=20 2.56.0 From nobody Sat Oct 24 20:18:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1792165233; cv=none; d=zohomail.com; s=zohoarc; b=V88VifEoueje1d74OFhhhzeFi+NtLNyHKq2A4LgsyeAzm5lzCVmW00UGWK+RCvbdky+q18I3PCfZ9jwe8gul/kpmx/wA32sKRHGcoAHMSK37zQ6N6pP7Vtbb0EvvTtS5dLqpcVn01l4rlV2lcPx6GMGzRd/QiI+YP6Gtc5R59Ko= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792165233; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=scYRRw5xn8hkoj1qp4y+hSxvZCDIyBlEryj6FaoUEfk=; b=MUl68UIy39hPqnpe3iiA7NGao/6QQN/iMfaIh1SSiB1QVJJyVaL8D4xC8b6fTid94/XPifpvstzdUaXLyIkYbTtynDq424G3iXxSaSptVnu3tfeaPs+HHLri/kj5OhyUK7HhFcMiBWDE5uCx8sW9JbHYqJmIxu8BmGhwpLDf1uI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1792165233615940.5540912731171; Fri, 16 Oct 2026 08:40:33 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 7434441BE3; Fri, 16 Oct 2026 11:40:32 -0400 (EDT) Received: from [172.19.199.16] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 0EAC241C62; Fri, 16 Oct 2026 11:36:58 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 9714541960; Fri, 16 Oct 2026 11:36:36 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id ECFC341979 for ; Fri, 16 Oct 2026 11:36:35 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-117-7TBuzJ0SM-uo3SCG2RnDUQ-1; Fri, 16 Oct 2026 15:36:34 +0000 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7A7E01955DE9 for ; Fri, 16 Oct 2026 15:36:33 +0000 (UTC) Received: from berrange.csb (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8CF741956086; Fri, 16 Oct 2026 15:36:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_SBL_CSS, SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792164995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=scYRRw5xn8hkoj1qp4y+hSxvZCDIyBlEryj6FaoUEfk=; b=NOYl2WOFuY3L+oIwADPBg9gBxD9+9wrHi7yBO+mdwlISz9/ujbs88dAzmH4rOKYNjZTq/W XQ1YIdP2KTZtr7LW5J+R436WZ6UUNnPlBDqsMlRTOXGMxI8iekI6YUeCc40WinAUnuiXT7 Dk2K36ION5ZicP7XziaL4o7f6n0+opI= X-MC-Unique: 7TBuzJ0SM-uo3SCG2RnDUQ-1 X-Mimecast-MFC-AGG-ID: 7TBuzJ0SM-uo3SCG2RnDUQ_1792164993 To: devel@lists.libvirt.org Subject: [PATCH 2/7] meson: add dependency comment for driver_secret Date: Fri, 16 Oct 2026 16:36:22 +0100 Message-ID: <20261016153627.2837207-3-berrange@redhat.com> In-Reply-To: <20261016153627.2837207-1-berrange@redhat.com> References: <20261016153627.2837207-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: d55NXO8m7K859yslZKU4cA7naJSQkl5rFHb39kfKQIU_1792164993 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: FH6ZZW47CSUZFZOMXRDMD2PQU4QN64TY X-Message-ID-Hash: FH6ZZW47CSUZFZOMXRDMD2PQU4QN64TY X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1792165237068158500 From: Daniel P. Berrang=C3=A9 This is a stateful driver inside libvirtd Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Michal Privoznik --- meson_options.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/meson_options.txt b/meson_options.txt index 1ec3c865fc..d09c7a630d 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -92,6 +92,7 @@ option('driver_vz', type: 'feature', value: 'auto', descr= iption: 'Virtuozzo driv option('driver_interface', type: 'feature', value: 'auto', description: 'h= ost interface driver') # dep:driver_remote dep:driver_libvirtd option('driver_network', type: 'feature', value: 'auto', description: 'vir= tual network driver') +# dep:driver_remote dep:driver_libvirtd option('driver_secrets', type: 'feature', value: 'auto', description: 'loc= al secrets management driver') =20 =20 --=20 2.56.0 From nobody Sat Oct 24 20:18:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1792165320; cv=none; d=zohomail.com; s=zohoarc; b=MyrqianYGCVLVPvnim4AtKU5PZOmQYOUky7Ay3Iih/FVsZjASW8BiS1Zcn+Dc7pyZLwhlePz3lR+bnqNOZlHfPWVCLnBiCIcZSN9Obg6PbNkamwhdUaoWOFSt03o+orDO6XSuDlS1Fgc+rLMJTcLoRtiCXtZ2k+mMyo47nc5kj0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792165320; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=5RF8nqiR1U4fYVCY/iqBjhysvGDt0R9NvlTJ7r5PplU=; b=PZacM4el4Sn2fG09bEejc3y6N6/IUVvRpFdIVcIoYmoSZ38Oc9W6qXAgcKoar8x/z/z86k6MBikdUhoe1I09uPCWjMZGDejEL4P6j/zpRUADvcp6DXIoeW7SOqlJdYgCX60Sw1SFpaNdy0PXlijJmUOP7IDVxsKCu45NIW6uHfo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1792165320584802.8498771710667; Fri, 16 Oct 2026 08:42:00 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 533EC41BBB; Fri, 16 Oct 2026 11:41:59 -0400 (EDT) Received: from [172.19.199.16] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 345A641C84; Fri, 16 Oct 2026 11:37:03 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 0A2BF41960; Fri, 16 Oct 2026 11:36:37 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 6251841960 for ; Fri, 16 Oct 2026 11:36:37 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-168-l-_s6AwuMUaTffg7LTrq2Q-1; Fri, 16 Oct 2026 15:36:35 +0000 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C4F1A1955DD3 for ; Fri, 16 Oct 2026 15:36:34 +0000 (UTC) Received: from berrange.csb (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DE35E1956086; Fri, 16 Oct 2026 15:36:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792164997; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5RF8nqiR1U4fYVCY/iqBjhysvGDt0R9NvlTJ7r5PplU=; b=aEluCMTitdjirJCmyjUKNYgkvpf6W3QLWucUlYtHiai8rWot9c2Pilnoou4wI+5ofCGlRB ah1oEM+TKPT4ck4fEWZSvALHqbSd6sFss4qM3WqPSnrs24w8JYP+p2PBy6X2xBVjd1E9Hu xrO4IR7pn30MSo6xxb++4GYIAKTxBIk= X-MC-Unique: l-_s6AwuMUaTffg7LTrq2Q-1 X-Mimecast-MFC-AGG-ID: l-_s6AwuMUaTffg7LTrq2Q_1792164995 To: devel@lists.libvirt.org Subject: [PATCH 3/7] meson: add 'driver_nwfilter' option Date: Fri, 16 Oct 2026 16:36:23 +0100 Message-ID: <20261016153627.2837207-4-berrange@redhat.com> In-Reply-To: <20261016153627.2837207-1-berrange@redhat.com> References: <20261016153627.2837207-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2x4ddc3AuJmPZXqadciFDJtNHvCAR1cap6wfOOqca0o_1792164995 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: B376HNDAUGQPKJC42UWHZJXLWM754OWW X-Message-ID-Hash: B376HNDAUGQPKJC42UWHZJXLWM754OWW X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1792165322525158500 From: Daniel P. Berrang=C3=A9 Allow building of the nwfilter driver to be directly controlled. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Michal Privoznik --- libvirt.spec.in | 2 ++ meson.build | 9 ++++++++- meson_options.txt | 2 ++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index a5bb59a105..13ba0a7670 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1393,6 +1393,7 @@ export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{_= specdir}/libvirt.spec) %{?arg_remote_mode} \ -Ddriver_interface=3Denabled \ -Ddriver_network=3Denabled \ + -Ddriver_nwfilter=3Denabled \ -Dstorage_fs=3Denabled \ -Dstorage_lvm=3Denabled \ -Dstorage_iscsi=3Denabled \ @@ -1475,6 +1476,7 @@ export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{_= specdir}/libvirt.spec) -Ddriver_libxl=3Ddisabled \ -Ddriver_lxc=3Ddisabled \ -Ddriver_network=3Ddisabled \ + -Ddriver_nwfilter=3Ddisabled \ -Ddriver_openvz=3Ddisabled \ -Ddriver_qemu=3Ddisabled \ -Ddriver_secrets=3Ddisabled \ diff --git a/meson.build b/meson.build index 6d5ae23e3e..fb95a73928 100644 --- a/meson.build +++ b/meson.build @@ -2006,8 +2006,14 @@ endif =20 # nwfilter should only be compiled for linux, and only if the # libvirt daemon is also being compiled -if conf.has('WITH_LIBVIRTD') and host_machine.system() =3D=3D 'linux' +if not get_option('driver_nwfilter').disabled() and conf.has('WITH_LIBVIRT= D') and host_machine.system() =3D=3D 'linux' conf.set('WITH_NWFILTER', 1) +elif get_option('driver_nwfilter').enabled() + if not conf.has('WITH_LIBVIRTD') + error('libvirtd must be enabled to build the network driver') + else + error('linux host is required to build the nwfilter driver') + endif endif =20 if conf.has('WITH_NWFILTER') or conf.has('WITH_NETWORK') @@ -2259,6 +2265,7 @@ driver_summary =3D { 'LXC': conf.has('WITH_LXC'), 'Monolithic libvirtd': conf.has('WITH_MONOLITHIC_LIBVIRTD'), 'Network': conf.has('WITH_NETWORK'), + 'NWFilter': conf.has('WITH_NWFLTER'), 'OpenVZ': conf.has('WITH_OPENVZ'), 'QEMU': conf.has('WITH_QEMU'), 'Remote': conf.has('WITH_REMOTE'), diff --git a/meson_options.txt b/meson_options.txt index d09c7a630d..4df99a5f87 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -93,6 +93,8 @@ option('driver_interface', type: 'feature', value: 'auto'= , description: 'host in # dep:driver_remote dep:driver_libvirtd option('driver_network', type: 'feature', value: 'auto', description: 'vir= tual network driver') # dep:driver_remote dep:driver_libvirtd +option('driver_nwfilter', type: 'feature', value: 'auto', description: 'ne= twork filter driver') +# dep:driver_remote dep:driver_libvirtd option('driver_secrets', type: 'feature', value: 'auto', description: 'loc= al secrets management driver') =20 =20 --=20 2.56.0 From nobody Sat Oct 24 20:18:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1792165407; cv=none; d=zohomail.com; s=zohoarc; b=A/0zFKweSC1wh1lZuo8OJ9APxLfIQ/xsRnANaLh5X2QZ5T+ywWeUBMWhM/GXCm1xXzfzLVAjnr9rdhY262aq85AMvYpdC+u277+3mOJyrKBhGunD/Y9cC+rv87uYsjN0m1M/qKx2AaastUB6FlZcPTpkjThAnVCTQOMzpAZe0sA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792165407; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=mc8JHx1Y/NC2oY7aQ1d4VbS/yZJ/oGYkFI/JG2O2gPA=; b=Jl2JyKKW4Ez0AKwZyTVwtpfSWtFOKIypKQDlsVP6Zh/x3D4Mza+VUz7qb6OwIZPd3qpHpZyQ4bpAK+bpFD0EETNxHHt2ufJ8Jlb3KyigkRtsCgtKVA71oVnFtc6U4dqnl7P9eDGwtam90kZ699uQStmfSpAWo/BeRdFM1BXgXmQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1792165407092593.3335537081304; Fri, 16 Oct 2026 08:43:27 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id CEFCF41B35; Fri, 16 Oct 2026 11:43:25 -0400 (EDT) Received: from [172.19.199.16] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id D729441D07; Fri, 16 Oct 2026 11:37:09 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 57DAF419C3; Fri, 16 Oct 2026 11:36:47 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B9DB9419C0 for ; Fri, 16 Oct 2026 11:36:38 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-327-8C1WVBB_OrORtA7jfVGHjA-1; Fri, 16 Oct 2026 15:36:36 +0000 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 26E7E1955F14 for ; Fri, 16 Oct 2026 15:36:36 +0000 (UTC) Received: from berrange.csb (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3821F1956086; Fri, 16 Oct 2026 15:36:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_SBL_CSS, SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792164998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mc8JHx1Y/NC2oY7aQ1d4VbS/yZJ/oGYkFI/JG2O2gPA=; b=S/Z+ptoSY8vYlSRIQ/Nttf2H9m22YJ80djywBM+1EivwHfJPVPjFnOtQVpT3834bgWdykB 7SGwNFupVpk2GC1FHJSEET/UEfbYCGc89qSxxPbZYwP0nmRDk9AgHvVty37jp+xJ9DQNBb tclRyn3PXUoRYeOgJnDbG3QQ8XCuHMw= X-MC-Unique: 8C1WVBB_OrORtA7jfVGHjA-1 X-Mimecast-MFC-AGG-ID: 8C1WVBB_OrORtA7jfVGHjA_1792164996 To: devel@lists.libvirt.org Subject: [PATCH 4/7] meson: add 'driver_nodedev' option Date: Fri, 16 Oct 2026 16:36:24 +0100 Message-ID: <20261016153627.2837207-5-berrange@redhat.com> In-Reply-To: <20261016153627.2837207-1-berrange@redhat.com> References: <20261016153627.2837207-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: EnKZFzCBEu5urJJZGnGFxgNpzkmcbwlreGL__0NNgpU_1792164996 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: A3D2TKERY3DKYWN3L7NTKWSIDXRVVCO7 X-Message-ID-Hash: A3D2TKERY3DKYWN3L7NTKWSIDXRVVCO7 X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1792165408490158500 From: Daniel P. Berrang=C3=A9 Allow building of the node device driver to be directly controlled. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Michal Privoznik --- libvirt.spec.in | 2 ++ meson.build | 9 ++++++++- meson_options.txt | 2 ++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 13ba0a7670..a8034744e8 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1393,6 +1393,7 @@ export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{_= specdir}/libvirt.spec) %{?arg_remote_mode} \ -Ddriver_interface=3Denabled \ -Ddriver_network=3Denabled \ + -Ddriver_nodedev=3Denabled \ -Ddriver_nwfilter=3Denabled \ -Dstorage_fs=3Denabled \ -Dstorage_lvm=3Denabled \ @@ -1476,6 +1477,7 @@ export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{_= specdir}/libvirt.spec) -Ddriver_libxl=3Ddisabled \ -Ddriver_lxc=3Ddisabled \ -Ddriver_network=3Ddisabled \ + -Ddriver_nodedev=3Ddisabled \ -Ddriver_nwfilter=3Ddisabled \ -Ddriver_openvz=3Ddisabled \ -Ddriver_qemu=3Ddisabled \ diff --git a/meson.build b/meson.build index fb95a73928..581f642b34 100644 --- a/meson.build +++ b/meson.build @@ -1654,8 +1654,14 @@ elif get_option('driver_network').enabled() error('libvirtd must be enabled to build the network driver') endif =20 -if udev_dep.found() and conf.has('WITH_LIBVIRTD') +if not get_option('driver_nodedev').disabled() and conf.has('WITH_LIBVIRTD= ') and udev_dep.found() conf.set('WITH_NODE_DEVICES', 1) +elif get_option('driver_nodedev').enabled() + if not conf.has('WITH_LIBVIRTD') + error('libvirtd must be enabled to build the node device driver') + elif not udev_dep.found() + error('udev library is required to build the node device driver') + endif endif =20 if not get_option('driver_openvz').disabled() and host_machine.system() = =3D=3D 'linux' @@ -2265,6 +2271,7 @@ driver_summary =3D { 'LXC': conf.has('WITH_LXC'), 'Monolithic libvirtd': conf.has('WITH_MONOLITHIC_LIBVIRTD'), 'Network': conf.has('WITH_NETWORK'), + 'Node device': conf.has('WITH_NODEDEV'), 'NWFilter': conf.has('WITH_NWFLTER'), 'OpenVZ': conf.has('WITH_OPENVZ'), 'QEMU': conf.has('WITH_QEMU'), diff --git a/meson_options.txt b/meson_options.txt index 4df99a5f87..3faed935ac 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -93,6 +93,8 @@ option('driver_interface', type: 'feature', value: 'auto'= , description: 'host in # dep:driver_remote dep:driver_libvirtd option('driver_network', type: 'feature', value: 'auto', description: 'vir= tual network driver') # dep:driver_remote dep:driver_libvirtd +option('driver_nodedev', type: 'feature', value: 'auto', description: 'nod= e device driver') +# dep:driver_remote dep:driver_libvirtd option('driver_nwfilter', type: 'feature', value: 'auto', description: 'ne= twork filter driver') # dep:driver_remote dep:driver_libvirtd option('driver_secrets', type: 'feature', value: 'auto', description: 'loc= al secrets management driver') --=20 2.56.0 From nobody Sat Oct 24 20:18:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1792165498; cv=none; d=zohomail.com; s=zohoarc; b=ZLtSLi5/wyC+De2nfr7No6DsqVuNQmOCItljQSVc5409TiZN7hTgdTzKJqUnVB1DT9YbX+QtSC/rOqsfUlpP7MdhhpwosAKIvNeLolNbkK+oaA1YgCTKkIEVx+R0shJ1gbR3B7Y79GnIFkWMTTdru5bNYM42f+ep3elpO6FxpH0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792165498; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=sRwqGSfHDXgdMsXCnhnO59GUdB4G+Y4PORByQYOY+hU=; b=IrUi9xJGO0Hl4yw/mGfEVR1C9kRLfvS9lptn9we8qfcuoVjr/9Y8DGvF9E8YcB7ah4nDPu6mfcPHzD8wS2HmFKQVZVr4xWYMzPNlZ4rbdibY2h2kZPeyuY0BYJg8G5rLhGvLNxArZgvphCyVTx5AwKNmrcavcw70WYsr/Bj8JBY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1792165498975991.8586915737401; Fri, 16 Oct 2026 08:44:58 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id D476441AF4; Fri, 16 Oct 2026 11:44:57 -0400 (EDT) Received: from [172.19.199.16] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 3E7A541D95; Fri, 16 Oct 2026 11:37:22 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 0837C41AFB; Fri, 16 Oct 2026 11:36:54 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 07F8141AB5 for ; Fri, 16 Oct 2026 11:36:40 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-384-AX7csIrKOkOLzmu_01pWtw-1; Fri, 16 Oct 2026 15:36:38 +0000 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7AF251800594 for ; Fri, 16 Oct 2026 15:36:37 +0000 (UTC) Received: from berrange.csb (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8DF3D1956086; Fri, 16 Oct 2026 15:36:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792164999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sRwqGSfHDXgdMsXCnhnO59GUdB4G+Y4PORByQYOY+hU=; b=GxvMDMZAUdw4l0tWGMkeXJMe1gOz0vCuKjECJn9jWNgDKTlFsyS/BLpBTUcmzzIkLK6P32 xz5fH5yu4APqT5mbMCuug0DCUEU4+WbjqAcA6CpTC6v4bK7EYTUxZxn8x0RYnT477U4A+D 7yxaeIuKKQiH18Pkg/yipS7tV8V1w+c= X-MC-Unique: AX7csIrKOkOLzmu_01pWtw-1 X-Mimecast-MFC-AGG-ID: AX7csIrKOkOLzmu_01pWtw_1792164997 To: devel@lists.libvirt.org Subject: [PATCH 5/7] meson: add 'driver_storage' option Date: Fri, 16 Oct 2026 16:36:25 +0100 Message-ID: <20261016153627.2837207-6-berrange@redhat.com> In-Reply-To: <20261016153627.2837207-1-berrange@redhat.com> References: <20261016153627.2837207-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: F3iIj_FYGBXm7XWksG7Wrbc8t9-CRijP7Epe9EzI_Zk_1792164997 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: LXLT4COUJOUKB24IW74RJUHGA36NDH2H X-Message-ID-Hash: LXLT4COUJOUKB24IW74RJUHGA36NDH2H X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1792165499822158500 From: Daniel P. Berrang=C3=A9 Allow building of the storage driver to be directly controlled. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Michal Privoznik --- libvirt.spec.in | 2 ++ meson.build | 14 ++++++++++---- meson_options.txt | 2 ++ 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index a8034744e8..7997c305b3 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1395,6 +1395,7 @@ export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{_= specdir}/libvirt.spec) -Ddriver_network=3Denabled \ -Ddriver_nodedev=3Denabled \ -Ddriver_nwfilter=3Denabled \ + -Ddriver_storage=3Denabled \ -Dstorage_fs=3Denabled \ -Dstorage_lvm=3Denabled \ -Dstorage_iscsi=3Denabled \ @@ -1482,6 +1483,7 @@ export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{_= specdir}/libvirt.spec) -Ddriver_openvz=3Ddisabled \ -Ddriver_qemu=3Ddisabled \ -Ddriver_secrets=3Ddisabled \ + -Ddriver_storage=3Ddisabled \ -Ddriver_vbox=3Ddisabled \ -Ddriver_vmware=3Ddisabled \ -Ddriver_vz=3Ddisabled \ diff --git a/meson.build b/meson.build index 581f642b34..16f88658c4 100644 --- a/meson.build +++ b/meson.build @@ -1794,7 +1794,7 @@ endif =20 use_storage =3D false =20 -if conf.has('WITH_LIBVIRTD') +if not get_option('driver_storage').disabled() and conf.has('WITH_LIBVIRTD= ') if not get_option('storage_dir').disabled() use_storage =3D true conf.set('WITH_STORAGE_DIR', 1) @@ -1897,10 +1897,15 @@ if conf.has('WITH_LIBVIRTD') use_storage =3D true conf.set('WITH_STORAGE_ZFS', 1) endif -endif =20 -if use_storage - conf.set('WITH_STORAGE', 1) + if use_storage + conf.set('WITH_STORAGE', 1) + elif get_option('driver_storage').enabled() + error('storage driver enabled but no storage backends enabled') + endif + +elif get_option('driver_storage').enabled() and not conf.has('WITH_LIBVIRT= D') + error('libvirtd must be enabled to build the storage driver') endif =20 =20 @@ -2276,6 +2281,7 @@ driver_summary =3D { 'OpenVZ': conf.has('WITH_OPENVZ'), 'QEMU': conf.has('WITH_QEMU'), 'Remote': conf.has('WITH_REMOTE'), + 'Storage': conf.has('WITH_STORAGE'), 'Test': conf.has('WITH_TEST'), 'VBox': conf.has('WITH_VBOX'), 'VMware': conf.has('WITH_VMWARE'), diff --git a/meson_options.txt b/meson_options.txt index 3faed935ac..7020cb2e6a 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -97,6 +97,8 @@ option('driver_nodedev', type: 'feature', value: 'auto', = description: 'node devi # dep:driver_remote dep:driver_libvirtd option('driver_nwfilter', type: 'feature', value: 'auto', description: 'ne= twork filter driver') # dep:driver_remote dep:driver_libvirtd +option('driver_storage', type: 'feature', value: 'auto', description: 'sto= rage driver') +# dep:driver_remote dep:driver_libvirtd option('driver_secrets', type: 'feature', value: 'auto', description: 'loc= al secrets management driver') =20 =20 --=20 2.56.0 From nobody Sat Oct 24 20:18:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1792165551; cv=none; d=zohomail.com; s=zohoarc; b=A71iINZisyGwPy3OynOcHjn+6L2c56lWsK7I02bOgDhZi6cxciv8TJFa+wLOU57Vl5D2r/yo8lzYHLjL9GzxSM7ZGbcwNx9xz9q2L707shY31s5wtiAFR9WyZV2Fpoi763Y7GRrep2p/DVCHQWpYgv5BjVwsj+m7gtx/ggzFixc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792165551; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=QRtfd/ppu1p0CmqsM9m2M7ItSadRyRRLazW/mLpv9Rw=; b=lHXWCDNx+kXBJxi73RKDSQb9p0HIazn8E4k3/i4bs/kJTIZVzjfELp0TWCahgDCdsU4CvUskAW7D11lpIccekQlah2HItwDwKyd+KwLgTiiY5DnsQAMec14yQnZYTwFNIVk9lXj+fJ91pVYsRDe5jaIJjZ8VtBzOqfaRoubfPNA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1792165551049970.7313573166689; Fri, 16 Oct 2026 08:45:51 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id DD874419EE; Fri, 16 Oct 2026 11:45:49 -0400 (EDT) Received: from [172.19.199.16] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 56D35419B2; Fri, 16 Oct 2026 11:37:29 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id BB2CA41B0B; Fri, 16 Oct 2026 11:37:02 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4B73341B5A for ; Fri, 16 Oct 2026 11:36:41 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-527-gXyTnGwVMRGBNR8i9NnU1Q-1; Fri, 16 Oct 2026 15:36:39 +0000 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CEE971955EB4 for ; Fri, 16 Oct 2026 15:36:38 +0000 (UTC) Received: from berrange.csb (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E273B1956086; Fri, 16 Oct 2026 15:36:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_SBL_CSS, SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792165001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QRtfd/ppu1p0CmqsM9m2M7ItSadRyRRLazW/mLpv9Rw=; b=ZhoNuxsp6gexxl0p7gB+Tn/6867PA3jBxESMso+csaThU7ChL6PQsUB9/iYIwosSOATQun aYpadFOVDC5MP07M0wcdSBi2oVW4Eg4AVgGJjvQoB/GVHEhqzd9uz2xVjGWqycoIEc3JMT lP00ZMjaugTHtFZhjuixW829g1mnCNo= X-MC-Unique: gXyTnGwVMRGBNR8i9NnU1Q-1 X-Mimecast-MFC-AGG-ID: gXyTnGwVMRGBNR8i9NnU1Q_1792164998 To: devel@lists.libvirt.org Subject: [PATCH 6/7] meson: rename driver_secrets to driver_secret Date: Fri, 16 Oct 2026 16:36:26 +0100 Message-ID: <20261016153627.2837207-7-berrange@redhat.com> In-Reply-To: <20261016153627.2837207-1-berrange@redhat.com> References: <20261016153627.2837207-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: EAIRAxQB-tOLdZkDSXkCZWEDuQAKawNfaEQbiDCWSQk_1792164998 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: QSDEZWXQRDOCUQ7MKAGODALXH2NYT3AF X-Message-ID-Hash: QSDEZWXQRDOCUQ7MKAGODALXH2NYT3AF X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1792165554631158500 From: Daniel P. Berrang=C3=A9 The driver/daemon name is 'secret' without the plural. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Michal Privoznik --- libvirt.spec.in | 2 +- meson.build | 2 +- meson_options.txt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 7997c305b3..0dda7b792d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1482,7 +1482,7 @@ export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{_= specdir}/libvirt.spec) -Ddriver_nwfilter=3Ddisabled \ -Ddriver_openvz=3Ddisabled \ -Ddriver_qemu=3Ddisabled \ - -Ddriver_secrets=3Ddisabled \ + -Ddriver_secret=3Ddisabled \ -Ddriver_storage=3Ddisabled \ -Ddriver_vbox=3Ddisabled \ -Ddriver_vmware=3Ddisabled \ diff --git a/meson.build b/meson.build index 16f88658c4..a5b1ad28d9 100644 --- a/meson.build +++ b/meson.build @@ -1749,7 +1749,7 @@ if not get_option('driver_qemu').disabled() endif endif =20 -if not get_option('driver_secrets').disabled() and conf.has('WITH_LIBVIRTD= ') +if not get_option('driver_secret').disabled() and conf.has('WITH_LIBVIRTD') conf.set('WITH_SECRETS', 1) endif =20 diff --git a/meson_options.txt b/meson_options.txt index 7020cb2e6a..476e87f1da 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -99,7 +99,7 @@ option('driver_nwfilter', type: 'feature', value: 'auto',= description: 'network # dep:driver_remote dep:driver_libvirtd option('driver_storage', type: 'feature', value: 'auto', description: 'sto= rage driver') # dep:driver_remote dep:driver_libvirtd -option('driver_secrets', type: 'feature', value: 'auto', description: 'loc= al secrets management driver') +option('driver_secret', type: 'feature', value: 'auto', description: 'loca= l secret management driver') =20 =20 option('secdriver_apparmor', type: 'feature', value: 'auto', description: = 'use AppArmor security driver') --=20 2.56.0 From nobody Sat Oct 24 20:18:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1792165597; cv=none; d=zohomail.com; s=zohoarc; b=c2EOnAR5bJApb4mNYc35VaHG/q3CJ3LmtodNNXKCL2dmuhu+uMeN2+kDP+4E4mRii8hzzz2nyaiTYO5bglszDyTRBwXJ9CWypLEK7CaCrZM0IplWUtL1IM5VXsuVo3rIMCgDni85NDecIbGU77wYZPN6BvpcUH8TMpXbaITkACQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792165597; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=0iFrkg0BdMRB8meT8zrOrUXVjaGSr54UIjV+QIk58PU=; b=cAbO1tkWPS+gLv8bkvswuTmfCp31FKu8Ve4KcyIRsWypACgWkJzYZgakBRYn2mRphEo5w538YOEWdCUORGr9ThkK3inuoagLthMf2rh+gh6Xhy9xM6xyw7D0Khe37ihlWor6TaFHVGrVywqCiNzwx9dz7Wv5P/RxKXrtOC0kiIk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1792165597681426.56462309999756; Fri, 16 Oct 2026 08:46:37 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 7358E41AE2; Fri, 16 Oct 2026 11:46:36 -0400 (EDT) Received: from [172.19.199.16] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 157DB41E0C; Fri, 16 Oct 2026 11:38:28 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id DE4D841B78; Fri, 16 Oct 2026 11:37:50 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id A594B41B76 for ; Fri, 16 Oct 2026 11:36:43 -0400 (EDT) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-i7-KTwyTOHuV4_EFxds8qQ-1; Fri, 16 Oct 2026 15:36:41 +0000 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 36D72195607F for ; Fri, 16 Oct 2026 15:36:40 +0000 (UTC) Received: from berrange.csb (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 41FFE1956086; Fri, 16 Oct 2026 15:36:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_SBL_CSS, SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792165003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0iFrkg0BdMRB8meT8zrOrUXVjaGSr54UIjV+QIk58PU=; b=XfCjo/DNrhsH8ACyi7la0xxKw5TCq6BA42moJEgHiYoslV93LjOHznFHhXV8qciHOBqDam h3x5deo0X045SS6iNjf8X4TqMeoIUmpzwjM+6UOtXepMo5VQ6ZIRuQ88BVpOBLGX+zedK3 pQozJfNa1U8KuZY3Zwm024lCz7AMrwc= X-MC-Unique: i7-KTwyTOHuV4_EFxds8qQ-1 X-Mimecast-MFC-AGG-ID: i7-KTwyTOHuV4_EFxds8qQ_1792165000 To: devel@lists.libvirt.org Subject: [PATCH 7/7] rpm: add explicit driver_secret=enabled Date: Fri, 16 Oct 2026 16:36:27 +0100 Message-ID: <20261016153627.2837207-8-berrange@redhat.com> In-Reply-To: <20261016153627.2837207-1-berrange@redhat.com> References: <20261016153627.2837207-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 52D7aY1aRNcr-5zzCWmaIhNpvHPcCWhK6HT2YxtqWoM_1792165000 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: GAA2OHJBVKRKQLB6XBWA57LL2PW7H6ER X-Message-ID-Hash: GAA2OHJBVKRKQLB6XBWA57LL2PW7H6ER X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1792165599427158500 From: Daniel P. Berrang=C3=A9 Best practice is to not rely on automatic enablement in builds. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Michal Privoznik --- libvirt.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 0dda7b792d..341c31a148 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1395,6 +1395,7 @@ export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{_= specdir}/libvirt.spec) -Ddriver_network=3Denabled \ -Ddriver_nodedev=3Denabled \ -Ddriver_nwfilter=3Denabled \ + -Ddriver_secret=3Denabled \ -Ddriver_storage=3Denabled \ -Dstorage_fs=3Denabled \ -Dstorage_lvm=3Denabled \ --=20 2.56.0