From nobody Sat Oct 24 20:21:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=invisiblethingslab.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1792154534041767.0738741973753; Fri, 16 Oct 2026 05:42:14 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id C2B2A41979; Fri, 16 Oct 2026 08:42:11 -0400 (EDT) Received: from [172.19.199.16] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 6AE9141999; Fri, 16 Oct 2026 08:41:06 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 833E93F332; Fri, 16 Oct 2026 08:40:54 -0400 (EDT) Received: from fhigh-a8-smtp.messagingengine.com (fhigh-a8-smtp.messagingengine.com [103.168.172.159]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 488A43F2F3 for ; Fri, 16 Oct 2026 08:40:53 -0400 (EDT) Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfhigh.phl.internal (Postfix) with ESMTP id A1665140010D for ; Fri, 16 Oct 2026 08:40:52 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Fri, 16 Oct 2026 08:40:52 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Oct 2026 08:40:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm2; t=1792154452; x=1792240852; bh=lwQhWTa/b1MvKNJGvkPw5z/Ht7xZ7FcP W1h6wn3/K7I=; b=ZVhKlGk6PZh3tAUUfI5Sn1wWhmzhgJQIB4vBYx7sbsJTsMUh wV1cy+jEFiibJv9tORoLonB65CjMy+fBYw1GhOSZuOmgNvtuZwJlkyceGBM9GcYb 4stBqta8fzQ2pHL9tW6lAEHWT/fqUF0JikIxebL4OdtT471Z9fw2iCsZnip3csg4 S1YbawqAp/ZutK8YU4in3nC/z+3Siof3Hx7rjbuZE6iEZ9ypH/+xYPuCcrSgmbuQ 6+HmOHHhhp7Nozr+9iIJLB7rdG4XgYXH8cbATDLtmyrCbsoVEDjOlmjmIjVXx9EM jLgFJwFt5oUI8fIgDEFM8K8ddxBPdqGQTnGB3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1792154452; x=1792240852; bh=lwQhWTa/b1MvKNJGvkPw5z/Ht7xZ 7FcPW1h6wn3/K7I=; b=h3hQRdEDiQiMZd23SdL+K5cTSefSk3BwRe3uitlma77Z v5FFS3qTJObz2LOkoNU++Rj4T8aeXE2DdzPYOdwG9fdtgzl9jeDpFpHP53quaAHt cfHBhqUJazBng/gN38rn+gD9kVXzNcr76tSdVuEjA3Aabj5z2lK28bBWceRvSB17 baTghvSWyKsP4bunO0wJTcw/Vwob1ASnD0+/wtLXy8YNmsZjTBko5jz74fEkxPgQ exCjjriP9XgaYhEnWR/ubS7WQxFZU9ur1n/cImW5P8FgPL/IB43uBiNX8lP0NLe9 dQ9q5qMSlo39NjwGXybG/NJqkrn60f5BfHgJbZDVhQ== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-10-08; sw=lmtpprox; action=sign d=invisiblethingslab.com a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1792154452; d=invisiblethingslab.com; mf=PG1hcm1hcmVrQGludmlzaWJsZXRoaW5nc2xhYi5jb20+; rt=PGRldmVsQGxpc3RzLmxpYnZpcnQub3JnPg==; s=fm2:rsa-sha256:kWvjgrk7kMKO6TcUOi+Ch5g6g+kM963K5BeizeI9m/21g38 DaEIsvInJMszQBW9XmBP27otCjiTbzdD4m90p4KcyRo+lqS3bRZQ6MID2txzv/kZ ijCKdowPzXViCjbn4j5GtmbUvSIj7vWkRGEQR8jTit3RgdVTzBPPZb9UL1vSeNVP XfknnK+yeDljNfe/wWsQiNqWfWKxXJGF/BFVmN57zgicPhcTFeFemgUVXauHW9d5 J/1OEh3kvIPZ+99ACeBuSPQaC4csXmXsmMKL5LB5PZ3KhNhLNW8Qdv5jguQwwJjo ALEos7JSqBO/tAmbyUMBn7RC5VRi1Za5rpHrrLQ==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-10-08; sw=lmtpprox; action=mi-m=1; hc=10; hn=cc,content-transfer-encoding,content-type,date,feedback-id, from,message-id,mime-version,subject,to; Message-Instance: m=1; h=sha256:E9/LOg9P1e+lGzzxdpbaDY/eLy2MYCxN98FrwbwgodY=:UaqjTDGo/l6CxRvo3q+vkyPwu6Dw/jDh5zehIUXsuss=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTG0rIn0Fub5MUltGshlWGf3AKCouUmoMKXhD1W86U749DcXSgTw5868cfIeZMfwBa KHvFShBfCdjwxqHYLkDW9yOZVIjZaR7J4hnh9Q5ntSSUALIWlLWskGPdPDC5aO4Mih5eRa b2Sr4dKF/PW5uPFiThrWr/i+m1aPbBVzfxl1IAnufy07QerC3nee6BwMq//eUroDBIIuED Zg0SIAueBXohY6JeTmtbAQJbi1zMSn7HCdNLbpySMcxaeEZFglP2JLNiCB/iNgDUtcGsiw MmOgLf84oSIiFwuMyf96+1Px1OGOkkdBuygghZuQd0wtN5V0PTBzfdjBnPdGs1u1EQVafJ 80L1O2rps6wPq8jbd+chgKwGyF5Tp6QwiawSS0BjDDVcmifZp1QJmE8R3oeGXNq3w1/1Yg tqSZSyzzq36m5K7erfGV5MoyVp6aFRKZxr2NvJ3WFX6TXtP/eAwzHqEagDGNNC+fXEhjVx Bz2aNpH93AlpLnNoYJO5f64s1oXM/+I12E/WYc0XqW9nAoKI/kev9raM3WG3OQNdKhP3do eW4hHVTWrXOr8pZ2getn/SwKV1bNqK+m1gnSUTk4B5rr7xTOt76Wfnnbrew8uJ9t1i0Lhr yrykLudgpCtNK+kL7mx8+0m4Gr3dtb5cjVHrvvkLwo5WEgNIS51h0OEQ+Jxg X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: devel@lists.libvirt.org Subject: [PATCH v3] build: set firewall_backend_priority regardless of driver_network Date: Fri, 16 Oct 2026 14:40:44 +0200 Message-ID: <20261016124045.414106-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 5K5MCID4WGFPDCMNT2LIGT5EKZMZ5YA7 X-Message-ID-Hash: 5K5MCID4WGFPDCMNT2LIGT5EKZMZ5YA7 X-MailFrom: marmarek@invisiblethingslab.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1792154536429158500 Set firewall_backend_priority whenever WITH_NWFILTER or WITH_NETWORK is set. And similarly, print firewall backends on the same condition. Otherwise a build with -Ddriver_network=3Ddisabled fails with: src/nwfilter/meson.build:51:43: ERROR: Unknown variable "firewall_backe= nd_priority". Signed-off-by: Marek Marczykowski-G=C3=B3recki Reviewed-by: Daniel P. Berrang=C3=A9 --- meson.build | 54 +++++++++++++++++++++++++++-------------------------- 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/meson.build b/meson.build index 927665b5fb..c15e4b43bf 100644 --- a/meson.build +++ b/meson.build @@ -1650,31 +1650,6 @@ endif =20 if not get_option('driver_network').disabled() and conf.has('WITH_LIBVIRTD= ') conf.set('WITH_NETWORK', 1) - - firewall_backend_priority =3D get_option('firewall_backend_priority') - if firewall_backend_priority.length() =3D=3D 0 - if host_machine.system() =3D=3D 'linux' - firewall_backend_priority =3D ['nftables', 'iptables'] - elif host_machine.system() =3D=3D 'freebsd' - firewall_backend_priority =3D ['pf'] - else - # No firewall impl on non-Linux so far, so force 'none' - # as placeholder - firewall_backend_priority =3D ['none'] - endif - else - if host_machine.system() !=3D 'linux' - error('firewall backend priority only supported on linux hosts') - endif - endif - - backends =3D [] - foreach backend: firewall_backend_priority - backend =3D 'VIR_FIREWALL_BACKEND_' + backend.to_upper() - backends +=3D backend - endforeach - - conf.set('FIREWALL_BACKENDS', ', '.join(backends)) elif get_option('driver_network').enabled() error('libvirtd must be enabled to build the network driver') endif @@ -2035,6 +2010,33 @@ if conf.has('WITH_LIBVIRTD') and host_machine.system= () =3D=3D 'linux' conf.set('WITH_NWFILTER', 1) endif =20 +if conf.has('WITH_NWFILTER') or conf.has('WITH_NETWORK') + firewall_backend_priority =3D get_option('firewall_backend_priority') + if firewall_backend_priority.length() =3D=3D 0 + if host_machine.system() =3D=3D 'linux' + firewall_backend_priority =3D ['nftables', 'iptables'] + elif host_machine.system() =3D=3D 'freebsd' + firewall_backend_priority =3D ['pf'] + else + # No firewall impl on non-Linux so far, so force 'none' + # as placeholder + firewall_backend_priority =3D ['none'] + endif + else + if host_machine.system() !=3D 'linux' + error('firewall backend priority only supported on linux hosts') + endif + endif + + backends =3D [] + foreach backend: firewall_backend_priority + backend =3D 'VIR_FIREWALL_BACKEND_' + backend.to_upper() + backends +=3D backend + endforeach + + conf.set('FIREWALL_BACKENDS', ', '.join(backends)) +endif + if not get_option('pm_utils').disabled() use_pm_utils =3D true if init_script =3D=3D 'systemd' @@ -2373,7 +2375,7 @@ misc_summary =3D { 'virt-login-shell': conf.has('WITH_LOGIN_SHELL'), 'Warning Flags': supported_cc_flags, } -if conf.has('WITH_NETWORK') +if conf.has('WITH_NWFILTER') or conf.has('WITH_NETWORK') misc_summary +=3D { 'firewall backends': firewall_backend_priority, } --=20 2.54.0