From nobody Sat Oct 24 20:21:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=invisiblethingslab.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1792152778118296.8642118776844; Fri, 16 Oct 2026 05:12:58 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id BAADD419FD; Fri, 16 Oct 2026 08:12:55 -0400 (EDT) Received: from [172.19.199.16] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 5DE0441B9B; Fri, 16 Oct 2026 08:11:28 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 348F541976; Fri, 16 Oct 2026 08:11:19 -0400 (EDT) Received: from fout-a1-smtp.messagingengine.com (fout-a1-smtp.messagingengine.com [103.168.172.144]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 11C244196F for ; Fri, 16 Oct 2026 08:11:14 -0400 (EDT) Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.phl.internal (Postfix) with ESMTP id 5F3E2EC0178 for ; Fri, 16 Oct 2026 08:03:21 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Fri, 16 Oct 2026 08:03:21 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Oct 2026 08:03:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Greylist: delayed 473 seconds by postgrey-1.37 at lists.libvirt.org; Fri, 16 Oct 2026 08:11:15 EDT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm2; t=1792152201; x=1792238601; bh=BGN59jfR0qEE7JZE8xUR4AwebmL/2lqJ 3yrExZ0qQZE=; b=PgqSLlwqiAebhrSlOM0dHheErhP9JDxW5R6hOz9lJ6TckvNm nzExmOKHTse5DsEVENuQAGKQ+5/2WIwlkpkwcpiix7si30Vhk2DtjiUweDtE5s/A H9W2BsQ/cKBRpZ+wqJ8Y9eCszZgKn/UIuu7wmFk5DjV+IfhJOpup0iU2nV/Fo62+ fL9tMwJMhQRjL0seAwzjZcXY31h5eUeCQTahLRKAkiZQCWYYgWX/5GEF1MQzy4lE U6la0aRO9QLuQnhXsgy0Wp9DwG1hsuvYH+qHjqob6bkvnkaiTXvkdvAP8srwEr10 ChK18nXtcxMM1YFdcl1Bcrv+94eZ/W1XRoGgIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1792152201; x=1792238601; bh=BGN59jfR0qEE7JZE8xUR4AwebmL/ 2lqJ3yrExZ0qQZE=; b=yqVk3GOiD5Lh0NKp8N1ohEdrOA6JFasIEEFFoM4hKYbI MifXA0OPsnVYH8s4nfSd4fiTr3k+8YtGlk3yAGXzM2E4bCE1dWD9iMSDVZdrOBTu S0pDqCqXUB2K5xhDUvISuYTCTHei//Psu7nLm6blWmmCJtW8HndGvkzkMXyrkL9+ P2lpmd1b1zAkrkYEVgXm0I+kt+7Kn6co/j0F5hRmhbVfDigddTLrAWrmoZ9ssk/X FRCdbGJduQGl2rQYJT0TF+Zt6I/FqH/GJka9iRluzNAue5R+jINEQnai9v4LrUYp mhHUDxIiQjwNfXukDdfL8XYwuASQGfmZfnm7sFUbIQ== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-10-08; sw=lmtpprox; action=sign d=invisiblethingslab.com a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1792152201; d=invisiblethingslab.com; mf=PG1hcm1hcmVrQGludmlzaWJsZXRoaW5nc2xhYi5jb20+; rt=PGRldmVsQGxpc3RzLmxpYnZpcnQub3JnPg==; s=fm2:rsa-sha256:J1Phv/d9a8nvJS2h1lLsmJOCMVMgJfSyPqFyXNo/IeWT0gb 33Pk9/Z2TSOeR1wGXcgWK+Hz/smpxmVyRQKY75lcDA9WmYsJwVw90wLq+ZNT464L Nh5vuQ1L7yzeNhAH8rf2P6kLUwv0WuVHw5QW0DitbXgGjf4LWU4cnVVr9OV63NNg bDnckGrtQEcvJe6wbUmHa7QpjdtVH5F2SxyLH1jU1+FsNT0bL09Ejp6p7g1TqNfg MmnZQTLhWhJ7MELUaoHGQu5eNOaHx91JaYM9tNAe9MKuNclLAwVl3YMgVLXf/1z9 ycaSLLiWpMBBa+1rSk04zPKaZ8ERrNbuOKnYtrA==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-10-08; sw=lmtpprox; action=mi-m=1; hc=10; hn=cc,content-transfer-encoding,content-type,date,feedback-id, from,message-id,mime-version,subject,to; Message-Instance: m=1; h=sha256:LrstDuVVG2YH7MhVg39COL73k+YNcNNl5RWM39bln8M=:MrE9cu6E+z+F/jDZBK6NgnwZqI2pSa7M611KX0HPTbw=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFNWw/G9u9lhNvkz6YrgnO9VYhVrFpiNb1DSVPxcZhcU0TafLPs6DNXu1p+EAu3/M 7cE7bBdd4NR517GwruRE+ZpavpJ8TWJiDQDbqBtLeZmvQDxJZqxOaYPEx7N98njo4gM4B/ QVmbnRUrn9DuDzdfsEHuB6b8/0QXGMcs7bUL7B70WlsxQ2snlsxT3dntJyWwozpNoDkrkL UvntSipwjdD+y5444sEG8hDXYKm+VPMqOMYvFe1Zh0C5hlgpyqd97M9ko15vZrovSE9Wns xVTP0JVJbDx8hMWGTkwgbGKVq7dqCutSZhao7CMjgg4u7yvHLbsjBHuWqEHfgbtVSYKbPV pkuJDhYx/yB3Epv86ntw/+hC0piOlGYeSPtKhS+HLeUNV1rmH9FUxmGmC+nFnu8NoGLAdb h1zJiLBUqrQykhY6RDat+a55YnIS0jRbdiYYiRHkpUuZQKk6pvC5aHmOtouTl4NXA9sF/e ixpBCcGY9L6rZTjtSCL/ieTaXFN3RidW3kzGFv+2k0pGmlqzQ3rOxIT0jJQ88rGzaE5nyu b24yjE14pbKWxKDeOkwKmrAU3FNebFYnOQD7qCp0xkIiOIwPuTOtMIcKB0Yn2TSXJb8zgA CYVUad3HMgoy0qosscJmQpMLtIg/S7V/OXJGCMpkKabygLPL3nLdqtnOgrFQ X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: devel@lists.libvirt.org Subject: [PATCH v2] build: set firewall_backend_priority regardless of driver_network Date: Fri, 16 Oct 2026 14:02:19 +0200 Message-ID: <20261016120314.413628-1-marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 7FTOA2O3NUUM5532G4J45TSUTAHXAAGV X-Message-ID-Hash: 7FTOA2O3NUUM5532G4J45TSUTAHXAAGV X-MailFrom: marmarek@invisiblethingslab.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1792152781807158500 Set firewall_backend_priority whenever WITH_NWFILTER is set. And similarly, print firewall backends on the same condition. Otherwise a build with -Ddriver_network=3Ddisabled fails with: src/nwfilter/meson.build:51:43: ERROR: Unknown variable "firewall_backe= nd_priority". Signed-off-by: Marek Marczykowski-G=C3=B3recki --- meson.build | 52 ++++++++++++++++++++++++++-------------------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/meson.build b/meson.build index 927665b5fb..049d259555 100644 --- a/meson.build +++ b/meson.build @@ -1650,31 +1650,6 @@ endif =20 if not get_option('driver_network').disabled() and conf.has('WITH_LIBVIRTD= ') conf.set('WITH_NETWORK', 1) - - firewall_backend_priority =3D get_option('firewall_backend_priority') - if firewall_backend_priority.length() =3D=3D 0 - if host_machine.system() =3D=3D 'linux' - firewall_backend_priority =3D ['nftables', 'iptables'] - elif host_machine.system() =3D=3D 'freebsd' - firewall_backend_priority =3D ['pf'] - else - # No firewall impl on non-Linux so far, so force 'none' - # as placeholder - firewall_backend_priority =3D ['none'] - endif - else - if host_machine.system() !=3D 'linux' - error('firewall backend priority only supported on linux hosts') - endif - endif - - backends =3D [] - foreach backend: firewall_backend_priority - backend =3D 'VIR_FIREWALL_BACKEND_' + backend.to_upper() - backends +=3D backend - endforeach - - conf.set('FIREWALL_BACKENDS', ', '.join(backends)) elif get_option('driver_network').enabled() error('libvirtd must be enabled to build the network driver') endif @@ -2033,6 +2008,31 @@ endif # libvirt daemon is also being compiled if conf.has('WITH_LIBVIRTD') and host_machine.system() =3D=3D 'linux' conf.set('WITH_NWFILTER', 1) + + firewall_backend_priority =3D get_option('firewall_backend_priority') + if firewall_backend_priority.length() =3D=3D 0 + if host_machine.system() =3D=3D 'linux' + firewall_backend_priority =3D ['nftables', 'iptables'] + elif host_machine.system() =3D=3D 'freebsd' + firewall_backend_priority =3D ['pf'] + else + # No firewall impl on non-Linux so far, so force 'none' + # as placeholder + firewall_backend_priority =3D ['none'] + endif + else + if host_machine.system() !=3D 'linux' + error('firewall backend priority only supported on linux hosts') + endif + endif + + backends =3D [] + foreach backend: firewall_backend_priority + backend =3D 'VIR_FIREWALL_BACKEND_' + backend.to_upper() + backends +=3D backend + endforeach + + conf.set('FIREWALL_BACKENDS', ', '.join(backends)) endif =20 if not get_option('pm_utils').disabled() @@ -2373,7 +2373,7 @@ misc_summary =3D { 'virt-login-shell': conf.has('WITH_LOGIN_SHELL'), 'Warning Flags': supported_cc_flags, } -if conf.has('WITH_NETWORK') +if conf.has('WITH_NWFILTER') misc_summary +=3D { 'firewall backends': firewall_backend_priority, } --=20 2.54.0