From nobody Sat Oct 24 20:20:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1791156922; cv=none; d=zohomail.com; s=zohoarc; b=FiGzy06vtiZ5pXGx19wOfQ4kBZ1EIW9P7O1gR05ia4shxBRRpUPtGNnVvOtzATpJrI2TRRgWbv/X5/uLtI2QcX9qO+jcnD9MRVa5Ahpv6A4Ok+yZjOGBS1geh2IpQJRul3E1q5NVBZVvG8FAQ14TgSKk1jluDZ9JMw9LjRA4WwM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791156922; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=VJoc0M9YenFL7uBjlxDVAHXwujVAaoq88PzRbQsDzOE=; b=P5tt/uzUlQrMui68mk/IDRsEjvkBV/i41eeqP56KyvJoxJbbQMogwXw8bAyrbSG/Axave/RNTcMTKZdI+CMC7Ixi96i+EpPWvzRfvWlcRolLX9utmGK5Q6hyzboDSvmd8UsbTUX84AoG00YQ9e15z0rGpd6L9av5Z3esQIm9APQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 179115692237626.330530683211805; Sun, 4 Oct 2026 16:35:22 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 85D623F2FC; Sun, 4 Oct 2026 19:35:19 -0400 (EDT) Received: from [172.19.199.16] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 4C61A41A1A; Sun, 4 Oct 2026 19:34:22 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id AC9CD3F2FC; Sun, 4 Oct 2026 19:34:10 -0400 (EDT) Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 07C893F320 for ; Sun, 4 Oct 2026 19:34:10 -0400 (EDT) Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-5bcb4f23ddeso643154e87.3 for ; Sun, 04 Oct 2026 16:34:09 -0700 (PDT) Received: from rbta-spb-lt-115149.astralinux.ru ([91.108.1.56]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5bb7c79d908sm2721993e87.49.2026.10.04.16.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Oct 2026 16:34:07 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE,RCVD_IN_SBL_CSS,SPF_HELO_NONE autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791156848; x=1791761648; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=VJoc0M9YenFL7uBjlxDVAHXwujVAaoq88PzRbQsDzOE=; b=UXlBVoXXGW1i8XtcriL7qzeDTrh3VCz9rGMEqQuLJi7TW44b2S8oVbxpuHfD2jjZsi JzVH3nFI6dLTx3HA5ou3e5xI7h2p725GIp6iDIIfqMk375m8jgdFdJTLn6NYQn73xA08 OdWelCxTKWrZMfT+Kzp9lfBhCs+GHN/e5+knzEgEkJDEzYcpQpeynw7MtvVDaUQsN1KT kDadCWvcpYLIuRoRnPecJyPHydyW0LENFANuqXRq9hPek2LnsLjzrxeTe2lk7jauX+tf xCR7ahsPgJJSdtD6E0RbXNGAIwSWu1wmn832Zxbr0YL1gkf6Gtet5VVU9bgM7b7L1h5W MJow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791156848; x=1791761648; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VJoc0M9YenFL7uBjlxDVAHXwujVAaoq88PzRbQsDzOE=; b=I9XbACRXmn2kmsm1+6Z5MgHXum/s4b6os3ozAnJEPWakIDmeo7bAszvQYi+jdIjIe6 s4pxlm2D3NJjLsOOrIA2AnEp1xlG9RfDNxnUMefJvQSbXUbXA1kDZJLg2BXMrKIfGR30 mBnFMxjP71ASrkV26+uuJb1DE63bT+tjtr7jiAtTVsNHqo0Tf2J5l+7WyjGxQqPUj3Xk Uak/gW94aUT3gAUUmfYtTGi/5Ev2wZccYoJinPO1qL5EsJT0z8S60suWb621IGiOtvlO ulxTHVW9FaXfTmXAUbZ5U6bXCLMZX/ScdQeRyjzrlCEGFKQlHS5df1OLM2Bj3DVX/PSh IiRg== X-Gm-Message-State: AFq9FYKntftIBXbDtzHy7tKTDZpfQHdcWF6+35oDDHgh7O5U3i9CIgiT paG4pixTIUEWD0vgEQSvoK1vndOmpdWnV3pVyS0pYLRDyfz/SCtNcw2Wv/9e/i3y X-Gm-Gg: AYBFou0WPKLkNuvkkgkHp0S1pItIJjPn1gprZ3X1lMqX4Y4iUaX2l0s5G58YeXu9cqA fZavuHPqASQfZbVKJ6U9dvhnojD94sJumnYhB5kIu1yDhWzk9laVeG7FYwuZtI3EY98vYQQiLl5 mMfTRBldUXx0VwamTCXkC92AUGLt1Zyp9esAjYE6dBOWYWgQrfSN0obOSknLHzE0j14QYkWFstQ /CMUIucjiZOe8/yAlBtmqcgMS9Pw5S76taaDReqxMWmVOZ6Pm4MnvMAB4Pa2ZVgTuOGLYC+p/vX 4rUdCiQPC73Iq42MoPBWr3gNtZpSnhX9kFLVO3gsQyB06aG1U/vTb0IJ3mFKpeTVqIB6lzlF5nb AnSom/MDrbskggiAewXLYvo7Y8RO6ObsCoVnznJuo6bnAIVKw1znsns36GNscJ+q+UneK1sGvZ3 2YH+etn8BefZIqwBDq4OzOjuCEq9I+2W05jWKbIoLoMbdwb8spEYzE1x7GjPJIZJDSAqhe+QWpl CC/tUEL/Mvacwc4cUM3Vpv9RPL/P7LEIzE2LXSXBMXcJY49TKfei8sPHkFv2HuO90mIUh4= X-Received: by 2002:ac2:4c55:0:b0:5b4:c00d:23f3 with SMTP id 2adb3069b0e04-5bcb544a418mr2001998e87.14.1791156848130; Sun, 04 Oct 2026 16:34:08 -0700 (PDT) From: Elizaveta Tereshkina To: devel@lists.libvirt.org Subject: [PATCH] qemu_driver: fix potential null pointer dereference in qemuConnectCPUModelBaseline() Date: Mon, 5 Oct 2026 02:33:00 +0300 Message-ID: <20261004233315.67471-1-teryoshkina.ea@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: K5LFCPOKMJFCZCIYOTK7K45BH6X5MPCP X-Message-ID-Hash: K5LFCPOKMJFCZCIYOTK7K45BH6X5MPCP X-MailFrom: teryoshkina.ea@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elizaveta Tereshkina X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1791156923169158500 Content-Type: text/plain; charset="utf-8" qemuMonitorGetCPUModelExpansion() may return 0 without assigning a value to model_info if QEMU returns a GenericError. Passing NULL to qemuConnectStealCPUModelFromInfo() can lead to the NULL pointer dereference. Check the result before stealing the CPU model to avoid this. Fixes: aa797c6625 (qemu_driver: expand cpu features after baseline) Signed-off-by: Elizaveta Tereshkina Reviewed-by: Jiri Denemark --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ebf19d7c0f..5922065897 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -12382,7 +12382,7 @@ qemuConnectCPUModelBaseline(virQEMUCaps *qemuCaps, false, false, &result) < 0) return NULL; =20 - if (qemuConnectStealCPUModelFromInfo(baseline, &result) < 0) + if (result && qemuConnectStealCPUModelFromInfo(baseline, &result) = < 0) return NULL; } =20 --=20 2.43.0